[PATCH] D54945: This commit adds a chapter about clang-tidy integrations

[Eugene Zelenko via Phabricator via cfe-commits]

Eugene.Zelenko added a comment.

I requested merge of updated documentation into 8.0 branch in PR40369.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54945/new/

https://reviews.llvm.org/D54945



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D54945: This commit adds a chapter about clang-tidy integrations

[Eugene Zelenko via Phabricator via cfe-commits]

Eugene.Zelenko added a comment.

I fixed links.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54945/new/

https://reviews.llvm.org/D54945



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D54945: This commit adds a chapter about clang-tidy integrations

[Eugene Zelenko via Phabricator via cfe-commits]

Eugene.Zelenko added a comment.

By the word, I noticed that HTTP was used and replaced it with HTTPS in 
Contributing.rst. Will be good idea to do the same in other documentation.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54945/new/

https://reviews.llvm.org/D54945



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D54945: This commit adds a chapter about clang-tidy integrations

[Eugene Zelenko via Phabricator via cfe-commits]

Eugene.Zelenko added a comment.

clang-tools-sphinx-docs bot is failing because of:

Warning, treated as error:
/home/buildbot/llvm-build-dir/clang-tools-sphinx-docs/llvm/src/tools/clang/tools/extra/docs/clang-tidy/Contributing.rst:61:
 ERROR: Unknown target name: "how to setup tooling for llvm".

Frankly I don't know what is proper way to handle cross-module documentation 
links.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54945/new/

https://reviews.llvm.org/D54945



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D54945: This commit adds a chapter about clang-tidy integrations

[Phabricator via Phabricator via cfe-commits]

This revision was automatically updated to reflect the committed changes.
Closed by commit rL351463: [Documentation] Add a chapter about Clang-tidy 
integrations. (authored by eugenezelenko, committed by ).
Herald added a subscriber: llvm-commits.

Changed prior to commit:
  https://reviews.llvm.org/D54945?vs=181528=182341#toc

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54945/new/

https://reviews.llvm.org/D54945

Files:
  clang-tools-extra/trunk/docs/clang-tidy/Contributing.rst
  clang-tools-extra/trunk/docs/clang-tidy/Integrations.rst
  clang-tools-extra/trunk/docs/clang-tidy/index.rst

Index: clang-tools-extra/trunk/docs/clang-tidy/index.rst
===
--- clang-tools-extra/trunk/docs/clang-tidy/index.rst
+++ clang-tools-extra/trunk/docs/clang-tidy/index.rst
@@ -10,6 +10,8 @@
:maxdepth: 1
 
The list of clang-tidy checks 
+   Clang-tidy IDE/Editor Integrations 
+   Getting Involved 
 
 :program:`clang-tidy` is a clang-based C++ "linter" tool. Its purpose is to
 provide an extensible framework for diagnosing and fixing typical programming
@@ -310,511 +312,3 @@
 
 .. _LibTooling: http://clang.llvm.org/docs/LibTooling.html
 .. _How To Setup Tooling For LLVM: http://clang.llvm.org/docs/HowToSetupToolingForLLVM.html
-
-
-Getting Involved
-
-
-:program:`clang-tidy` has several own checks and can run Clang static analyzer
-checks, but its power is in the ability to easily write custom checks.
-
-Checks are organized in modules, which can be linked into :program:`clang-tidy`
-with minimal or no code changes in :program:`clang-tidy`.
-
-Checks can plug into the analysis on the preprocessor level using `PPCallbacks`_
-or on the AST level using `AST Matchers`_. When an error is found, checks can
-report them in a way similar to how Clang diagnostics work. A fix-it hint can be
-attached to a diagnostic message.
-
-The interface provided by :program:`clang-tidy` makes it easy to write useful
-and precise checks in just a few lines of code. If you have an idea for a good
-check, the rest of this document explains how to do this.
-
-There are a few tools particularly useful when developing clang-tidy checks:
-  * ``add_new_check.py`` is a script to automate the process of adding a new
-check, it will create the check, update the CMake file and create a test;
-  * ``rename_check.py`` does what the script name suggests, renames an existing
-check;
-  * :program:`clang-query` is invaluable for interactive prototyping of AST
-matchers and exploration of the Clang AST;
-  * `clang-check`_ with the ``-ast-dump`` (and optionally ``-ast-dump-filter``)
-provides a convenient way to dump AST of a C++ program.
-
-If CMake is configured with ``CLANG_ENABLE_STATIC_ANALYZER``,
-:program:`clang-tidy` will not be built with support for the 
-``clang-analyzer-*`` checks or the ``mpi-*`` checks.
-
-
-.. _AST Matchers: http://clang.llvm.org/docs/LibASTMatchers.html
-.. _PPCallbacks: http://clang.llvm.org/doxygen/classclang_1_1PPCallbacks.html
-.. _clang-check: http://clang.llvm.org/docs/ClangCheck.html
-
-
-Choosing the Right Place for your Check

-
-If you have an idea of a check, you should decide whether it should be
-implemented as a:
-
-+ *Clang diagnostic*: if the check is generic enough, targets code patterns that
-  most probably are bugs (rather than style or readability issues), can be
-  implemented effectively and with extremely low false positive rate, it may
-  make a good Clang diagnostic.
-
-+ *Clang static analyzer check*: if the check requires some sort of control flow
-  analysis, it should probably be implemented as a static analyzer check.
-
-+ *clang-tidy check* is a good choice for linter-style checks, checks that are
-  related to a certain coding style, checks that address code readability, etc.
-
-
-Preparing your Workspace
-
-
-If you are new to LLVM development, you should read the `Getting Started with
-the LLVM System`_, `Using Clang Tools`_ and `How To Setup Tooling For LLVM`_
-documents to check out and build LLVM, Clang and Clang Extra Tools with CMake.
-
-Once you are done, change to the ``llvm/tools/clang/tools/extra`` directory, and
-let's start!
-
-.. _Getting Started with the LLVM System: http://llvm.org/docs/GettingStarted.html
-.. _Using Clang Tools: http://clang.llvm.org/docs/ClangTools.html
-
-
-The Directory Structure

-
-:program:`clang-tidy` source code resides in the
-``llvm/tools/clang/tools/extra`` directory and is structured as follows:
-
-::
-
-  clang-tidy/   # Clang-tidy core.
-  |-- ClangTidy.h   # Interfaces for users and checks.
-  |-- ClangTidyModule.h # Interface for clang-tidy modules.
-  |-- ClangTidyModuleRegistry.h # Interface for registering of modules.
- ...
-  |-- google/   # Google 

[PATCH] D54945: This commit adds a chapter about clang-tidy integrations

[Marina Kalashina via Phabricator via cfe-commits]

MarinaKalashina added a comment.

@Eugene.Zelenko  @alexfh Thank you! How should I proceed with the revision now? 
Do I get it right from 
https://llvm.org/docs/Phabricator.html#committing-a-change, that without commit 
access, I need to ask for committing the changes for me?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54945/new/

https://reviews.llvm.org/D54945



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D54945: This commit adds a chapter about clang-tidy integrations

[Eugene Zelenko via Phabricator via cfe-commits]

Eugene.Zelenko added a comment.

In D54945#1355920 , @MarinaKalashina 
wrote:

> @Eugene.Zelenko
>
> > I would suggest to rename contribution to Contributing (see LLVM 
> > documentation) and integrations to Integrations.
>
> Sure, done.
>
> > Will be also good idea to fix D55523  
> > script warnings.
>
> The script warns about double spaces and line width in the table, for example:
>
>   warning: line 39 contains double spaces
>   warning: line 39 is in excess of 80 characters (196)
>
>
> These spaces and width are intended since they 'draw' the table layout. Do 
> you think we could ignore such warnings in this particular case?


Sure, it's fine to leave table as it is. Same thing is done in LLDB code where 
tables are excluded from Clang-format.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54945/new/

https://reviews.llvm.org/D54945



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D54945: This commit adds a chapter about clang-tidy integrations

[Marina Kalashina via Phabricator via cfe-commits]

MarinaKalashina added a comment.

@Eugene.Zelenko

> I would suggest to rename contribution to Contributing (see LLVM 
> documentation) and integrations to Integrations.

Sure, done.

> Will be also good idea to fix D55523  script 
> warnings.

The script warns about double spaces and line width in the table, for example:

  warning: line 39 contains double spaces
  warning: line 39 is in excess of 80 characters (196)

These spaces and width are intended since they 'draw' the table layout. Do you 
think we could ignore such warnings in this particular case?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54945/new/

https://reviews.llvm.org/D54945



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D54945: This commit adds a chapter about clang-tidy integrations

[Marina Kalashina via Phabricator via cfe-commits]

MarinaKalashina updated this revision to Diff 181528.
MarinaKalashina marked an inline comment as done.
MarinaKalashina added a comment.

files renamed: //contribution.rst// to //Contributing.rst//, // 
integrations.rst// to //Integrations.rst//


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54945/new/

https://reviews.llvm.org/D54945

Files:
  docs/clang-tidy/Contributing.rst
  docs/clang-tidy/Integrations.rst
  docs/clang-tidy/index.rst

Index: docs/clang-tidy/Integrations.rst
===
--- /dev/null
+++ docs/clang-tidy/Integrations.rst
@@ -0,0 +1,117 @@
+==
+Clang-tidy IDE/Editor Integrations
+==
+
+.. _Clangd: https://clang.llvm.org/extra/clangd.html
+
+Apart from being a standalone tool, :program:`clang-tidy` is integrated into
+various IDEs, code analyzers, and editors. Besides, it is currently being
+integrated into Clangd_. The following table shows the most
+well-known :program:`clang-tidy` integrations in detail.
+
++--++-+--+-+--+
+|  |Feature   |
++==++=+==+=+==+
+|  **Tool**| On-the-fly inspection  | Check list configuration (GUI)  | Options to checks (GUI)  | Configuration via ``.clang-tidy`` files | Custom clang-tidy binary |
++--++-+--+-+--+
+|A.L.E. for Vim| \+\|   \-\   |   \-\| \-\ |   \+\|
++--++-+--+-+--+
+|Clang Power Tools for Visual Studio   | \-\|   \+\   |   \-\| \+\ |   \-\|
++--++-+--+-+--+
+|Clangd| \+\|   \-\   |   \-\| \-\ |   \-\|
++--++-+--+-+--+
+|CLion IDE | \+\|   \+\   |   \+\| \+\ |   \+\|
++--++-+--+-+--+
+|CodeChecker   | \-\|   \-\   |   \-\| \-\ |   \+\|
++--++-+--+-+--+
+|CPPCheck  | \-\|   \-\   |   \-\| \-\ |   \-\|
++--++-+--+-+--+
+|CPPDepend | \-\|   \-\   |   \-\| \-\ |   \-\|
++--++-+--+-+--+
+|Flycheck for Emacs| \+\|   \-\   |   \-\| \+\ |   \+\   

[PATCH] D54945: This commit adds a chapter about clang-tidy integrations

[Eugene Zelenko via Phabricator via cfe-commits]

Eugene.Zelenko added a comment.

I would suggest to rename //contribution// to //Contributing// (see LLVM 
documentation) and //integrations// to //Integrations//.

Will be also good idea to fix D55523  script 
warnings.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54945/new/

https://reviews.llvm.org/D54945



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D54945: This commit adds a chapter about clang-tidy integrations

[Alexander Kornienko via Phabricator via cfe-commits]

alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.

Awesome! Thanks a lot ! LG


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54945/new/

https://reviews.llvm.org/D54945



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D54945: This commit adds a chapter about clang-tidy integrations

[Marina Kalashina via Phabricator via cfe-commits]

MarinaKalashina updated this revision to Diff 181217.
MarinaKalashina added a comment.

restoring full content


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54945/new/

https://reviews.llvm.org/D54945

Files:
  docs/clang-tidy/contribution.rst
  docs/clang-tidy/index.rst
  docs/clang-tidy/integrations.rst

Index: docs/clang-tidy/integrations.rst
===
--- /dev/null
+++ docs/clang-tidy/integrations.rst
@@ -0,0 +1,117 @@
+==
+Clang-tidy IDE/Editor Integrations
+==
+
+.. _Clangd: https://clang.llvm.org/extra/clangd.html
+
+Apart from being a standalone tool, :program:`clang-tidy` is integrated into
+various IDEs, code analyzers, and editors. Besides, it is currently being
+integrated into Clangd_. The following table shows the most
+well-known :program:`clang-tidy` integrations in detail.
+
++--++-+--+-+--+
+|  |Feature   |
++==++=+==+=+==+
+|  **Tool**| On-the-fly inspection  | Check list configuration (GUI)  | Options to checks (GUI)  | Configuration via ``.clang-tidy`` files | Custom clang-tidy binary |
++--++-+--+-+--+
+|A.L.E. for Vim| \+\|   \-\   |   \-\| \-\ |   \+\|
++--++-+--+-+--+
+|Clang Power Tools for Visual Studio   | \-\|   \+\   |   \-\| \+\ |   \-\|
++--++-+--+-+--+
+|Clangd| \+\|   \-\   |   \-\| \-\ |   \-\|
++--++-+--+-+--+
+|CLion IDE | \+\|   \+\   |   \+\| \+\ |   \+\|
++--++-+--+-+--+
+|CodeChecker   | \-\|   \-\   |   \-\| \-\ |   \+\|
++--++-+--+-+--+
+|CPPCheck  | \-\|   \-\   |   \-\| \-\ |   \-\|
++--++-+--+-+--+
+|CPPDepend | \-\|   \-\   |   \-\| \-\ |   \-\|
++--++-+--+-+--+
+|Flycheck for Emacs| \+\|   \-\   |   \-\| \+\ |   \+\|

[PATCH] D54945: This commit adds a chapter about clang-tidy integrations

[Marina Kalashina via Phabricator via cfe-commits]

MarinaKalashina updated this revision to Diff 181216.
MarinaKalashina added a comment.

integrations.rst - end of file new line


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54945/new/

https://reviews.llvm.org/D54945

Files:
  docs/clang-tidy/integrations.rst


Index: docs/clang-tidy/integrations.rst
===
--- docs/clang-tidy/integrations.rst
+++ docs/clang-tidy/integrations.rst
@@ -114,4 +114,4 @@
 solutions and run the :program:`clang-tidy` inspection on them. The
 CodeChecker_ application of version 5.3 or later, which also comes as a plugin_
 for Eclipse, supports :program:`clang-tidy` as a static analysis instrument and
-allows to use a custom :program:`clang-tidy` binary.
\ No newline at end of file
+allows to use a custom :program:`clang-tidy` binary.


Index: docs/clang-tidy/integrations.rst
===
--- docs/clang-tidy/integrations.rst
+++ docs/clang-tidy/integrations.rst
@@ -114,4 +114,4 @@
 solutions and run the :program:`clang-tidy` inspection on them. The
 CodeChecker_ application of version 5.3 or later, which also comes as a plugin_
 for Eclipse, supports :program:`clang-tidy` as a static analysis instrument and
-allows to use a custom :program:`clang-tidy` binary.
\ No newline at end of file
+allows to use a custom :program:`clang-tidy` binary.
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D54945: This commit adds a chapter about clang-tidy integrations

[Eugene Zelenko via Phabricator via cfe-commits]

Eugene.Zelenko added inline comments.



Comment at: docs/clang-tidy/integrations.rst:118
+allows to use a custom :program:`clang-tidy` binary.
\ No newline at end of file


Please add newline.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54945/new/

https://reviews.llvm.org/D54945



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D54945: This commit adds a chapter about clang-tidy integrations

[Marina Kalashina via Phabricator via cfe-commits]

MarinaKalashina added a comment.

@alexfh Thank you, please see the updated structure.
@Eugene.Zelenko Done, the only warnings I got were about the table rows width.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54945/new/

https://reviews.llvm.org/D54945



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D54945: This commit adds a chapter about clang-tidy integrations

[Marina Kalashina via Phabricator via cfe-commits]

MarinaKalashina updated this revision to Diff 181018.
MarinaKalashina added a comment.

Extracting 'Getting Involved' and 'Clang-tidy integrations' to separate pages 
linked in See Also.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54945/new/

https://reviews.llvm.org/D54945

Files:
  docs/clang-tidy/contribution.rst
  docs/clang-tidy/index.rst
  docs/clang-tidy/integrations.rst

Index: docs/clang-tidy/integrations.rst
===
--- /dev/null
+++ docs/clang-tidy/integrations.rst
@@ -0,0 +1,117 @@
+==
+Clang-tidy IDE/Editor Integrations
+==
+
+.. _Clangd: https://clang.llvm.org/extra/clangd.html
+
+Apart from being a standalone tool, :program:`clang-tidy` is integrated into
+various IDEs, code analyzers, and editors. Besides, it is currently being
+integrated into Clangd_. The following table shows the most
+well-known :program:`clang-tidy` integrations in detail.
+
++--++-+--+-+--+
+|  |Feature   |
++==++=+==+=+==+
+|  **Tool**| On-the-fly inspection  | Check list configuration (GUI)  | Options to checks (GUI)  | Configuration via ``.clang-tidy`` files | Custom clang-tidy binary |
++--++-+--+-+--+
+|A.L.E. for Vim| \+\|   \-\   |   \-\| \-\ |   \+\|
++--++-+--+-+--+
+|Clang Power Tools for Visual Studio   | \-\|   \+\   |   \-\| \+\ |   \-\|
++--++-+--+-+--+
+|Clangd| \+\|   \-\   |   \-\| \-\ |   \-\|
++--++-+--+-+--+
+|CLion IDE | \+\|   \+\   |   \+\| \+\ |   \+\|
++--++-+--+-+--+
+|CodeChecker   | \-\|   \-\   |   \-\| \-\ |   \+\|
++--++-+--+-+--+
+|CPPCheck  | \-\|   \-\   |   \-\| \-\ |   \-\|
++--++-+--+-+--+
+|CPPDepend | \-\|   \-\   |   \-\| \-\ |   \-\|
++--++-+--+-+--+
+|Flycheck for Emacs| \+\|   \-\   |   \-\| \+\ |   \+\|

[PATCH] D54945: This commit adds a chapter about clang-tidy integrations

[Alexander Kornienko via Phabricator via cfe-commits]

alexfh added a comment.

In D54945#1340528 , @MarinaKalashina 
wrote:

> @alexfh Just for me to be sure, should there be the following structure in 
> http://clang.llvm.org/extra/index.html: ...


Roughly like that. More specifically, I'd suggest to modify the See also 
section of clang-tidy/index.rst as follows:

  See also:
  
  .. toctree::
 :maxdepth: 1
  
 The list of clang-tidy checks 
 Clang-tidy IDE/Editor Integrations 
 Getting Involved 

The order of TOC items in http://clang.llvm.org/extra/index.html will be 
slightly weird (the three external docs will be placed before the headings of 
the main document), but that doesn't seem like a huge problem (and may be 
fixable).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54945/new/

https://reviews.llvm.org/D54945



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D54945: This commit adds a chapter about clang-tidy integrations

[Marina Kalashina via Phabricator via cfe-commits]

MarinaKalashina added a comment.

@alexfh Just for me to be sure, should there be the following structure in 
http://clang.llvm.org/extra/index.html:
Clang-Tidy

  The list of clang-tidy checks
  Using clang-tidy
  Suppressing Undesired Diagnostics
  Clang-tidy Integrated (separate page)
  Getting Involved (separate page)

And should the latter two pages be linked from 'Clang-Tidy' index.rs like 'The 
list of clang-tidy checks', which is placed in 'See also'?
Thank you.




Comment at: docs/clang-tidy/index.rst:262
+
+Clang-tidy integrated
+-

alexfh wrote:
> So how about moving this chapter to a separate page and adding a link to it 
> at the top of this document? While certainly useful, the information in this 
> section has a different focus from the rest of the documentation. Given that 
> the document has grown significantly, I suggest to split out this section and 
> the "Getting involved" section. (The latter can be done separately)
Just for me to be sure, should there be the following structure in 
http://clang.llvm.org/extra/index.html:
Clang-Tidy
  The list of clang-tidy checks
  Using clang-tidy
  Suppressing Undesired Diagnostics
  Clang-tidy Integrated (separate page)
  Getting Involved (separate page)
And should the latter two pages be linked from 'Clang-Tidy' index.rs like 'The 
list of clang-tidy checks', which is placed in 'See also'?
Thank you.



CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54945/new/

https://reviews.llvm.org/D54945



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D54945: This commit adds a chapter about clang-tidy integrations

[Alexander Kornienko via Phabricator via cfe-commits]

alexfh added inline comments.



Comment at: docs/clang-tidy/index.rst:262
+
+Clang-tidy integrated
+-

So how about moving this chapter to a separate page and adding a link to it at 
the top of this document? While certainly useful, the information in this 
section has a different focus from the rest of the documentation. Given that 
the document has grown significantly, I suggest to split out this section and 
the "Getting involved" section. (The latter can be done separately)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54945/new/

https://reviews.llvm.org/D54945



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D54945: This commit adds a chapter about clang-tidy integrations

[Eugene Zelenko via Phabricator via cfe-commits]

Eugene.Zelenko added a comment.

Please run script from D55523  over your 
changes.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54945/new/

https://reviews.llvm.org/D54945



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D54945: This commit adds a chapter about clang-tidy integrations

[Marina Kalashina via Phabricator via cfe-commits]

MarinaKalashina added a comment.

@ilya-biryukov  Thank you for a quick response and sorry for so many 
iterations. I uploaded a full-context version; hopefully this time it's alright 
- on my side, it finally looks like a proper full-context diff.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54945/new/

https://reviews.llvm.org/D54945



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D54945: This commit adds a chapter about clang-tidy integrations

[Marina Kalashina via Phabricator via cfe-commits]

MarinaKalashina updated this revision to Diff 178647.
MarinaKalashina added a comment.

Full-context patch


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54945/new/

https://reviews.llvm.org/D54945

Files:
  docs/clang-tidy/index.rst

Index: docs/clang-tidy/index.rst
===
--- docs/clang-tidy/index.rst
+++ docs/clang-tidy/index.rst
@@ -21,6 +21,9 @@
 Using clang-tidy
 
 
+Standalone tool
+---
+
 :program:`clang-tidy` is a `LibTooling`_-based tool, and it's easier to work
 with if you set up a compile command database for your project (for an example
 of how to do this see `How To Setup Tooling For LLVM`_). You can also specify
@@ -255,6 +258,125 @@
   value:   'some value'
   ...
 
+
+Clang-tidy integrated
+-
+
+.. _Clangd: https://clang.llvm.org/extra/clangd.html
+
+Apart from being a standalone tool, :program:`clang-tidy` is integrated into
+various IDEs, code analyzers, and editors. Besides, it is currently being
+integrated into Clangd_. The following table shows the most
+well-known :program:`clang-tidy` integrations in detail.
+
++--++-+--+-+--+
+|  |Feature   |
++==++=+==+=+==+
+|  **Tool**| On-the-fly inspection  | Check list configuration (GUI)  | Options to checks (GUI)  | Configuration via ``.clang-tidy`` files | Custom clang-tidy binary |
++--++-+--+-+--+
+|A.L.E. for Vim| \+\|   \-\   |   \-\| \-\ |   \+\|
++--++-+--+-+--+
+|Clang Power Tools for Visual Studio   | \-\|   \+\   |   \-\| \+\ |   \-\|
++--++-+--+-+--+
+|Clangd| \+\|   \-\   |   \-\| \-\ |   \-\|
++--++-+--+-+--+
+|CLion IDE | \+\|   \+\   |   \+\| \+\ |   \+\|
++--++-+--+-+--+
+|CodeChecker   | \-\|   \-\   |   \-\| \-\ |   \+\|
++--++-+--+-+--+
+|CPPCheck  | \-\|   \-\   |   \-\| \-\ |   \-\|
++--++-+--+-+--+
+|CPPDepend | \-\|   \-\   |   \-\| \-\ |   \-\|
++--++-+--+-+--+
+|Flycheck for Emacs| \+\

[PATCH] D54945: This commit adds a chapter about clang-tidy integrations

[Ilya Biryukov via Phabricator via cfe-commits]

ilya-biryukov added a comment.

Thanks for the update! We still need to solve the technicality here: could you 
please upload the diff with full context? See LLVM docs 

 for an example on how this can be done with various version controls  (the 
`-U9` args are important, they are the ones that produce diffs with enough 
lines around it)


Repository:
  rCTE Clang Tools Extra

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54945/new/

https://reviews.llvm.org/D54945



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D54945: This commit adds a chapter about clang-tidy integrations

[Marina Kalashina via Phabricator via cfe-commits]

MarinaKalashina updated this revision to Diff 178623.
MarinaKalashina set the repository for this revision to rCTE Clang Tools Extra.
MarinaKalashina added a comment.

Another attempt to update the patch with the following fixes:

- empty line before 'Standalone tool'
- table columns with '+/-' aligned
- line width limited to 80 (except for the table)
- clang-tidy-vs plugin added
- Clangd added to the intro, the table, and the CLion's paragraph


Repository:
  rCTE Clang Tools Extra

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54945/new/

https://reviews.llvm.org/D54945

Files:
  docs/clang-tidy/index.rst

Index: docs/clang-tidy/index.rst
===
--- docs/clang-tidy/index.rst
+++ docs/clang-tidy/index.rst
@@ -21,6 +21,9 @@
 Using clang-tidy
 
 
+Standalone tool
+---
+
 :program:`clang-tidy` is a `LibTooling`_-based tool, and it's easier to work
 with if you set up a compile command database for your project (for an example
 of how to do this see `How To Setup Tooling For LLVM`_). You can also specify
@@ -255,6 +258,125 @@
   value:   'some value'
   ...
 
+
+Clang-tidy integrated
+-
+
+.. _Clangd: https://clang.llvm.org/extra/clangd.html
+
+Apart from being a standalone tool, :program:`clang-tidy` is integrated into
+various IDEs, code analyzers, and editors. Besides, it is currently being
+integrated into Clangd_. The following table shows the most
+well-known :program:`clang-tidy` integrations in detail.
+
++--++-+--+-+--+
+|  |Feature   |
++==++=+==+=+==+
+|  **Tool**| On-the-fly inspection  | Check list configuration (GUI)  | Options to checks (GUI)  | Configuration via ``.clang-tidy`` files | Custom clang-tidy binary |
++--++-+--+-+--+
+|A.L.E. for Vim| \+\|   \-\   |   \-\| \-\ |   \+\|
++--++-+--+-+--+
+|Clang Power Tools for Visual Studio   | \-\|   \+\   |   \-\| \+\ |   \-\|
++--++-+--+-+--+
+|Clangd| \+\|   \-\   |   \-\| \-\ |   \-\|
++--++-+--+-+--+
+|CLion IDE | \+\|   \+\   |   \+\| \+\ |   \+\|
++--++-+--+-+--+
+|CodeChecker   | \-\|   \-\   |   \-\| \-\ |   \+\|
++--++-+--+-+--+
+|CPPCheck  | \-\|   \-\   |   \-\| \-\ |   \-\|
++--++-+--+-+--+
+|CPPDepend | \-\|  

[PATCH] D54945: This commit adds a chapter about clang-tidy integrations

[Ilya Biryukov via Phabricator via cfe-commits]

ilya-biryukov added a comment.

Maybe try to use Arcanist for uploading diffs?
The web interface can be confusing at times, Arcanist is more reliable (LLVM 
docs 

 have pointers to the Arcanist documentation to get started)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54945/new/

https://reviews.llvm.org/D54945



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D54945: This commit adds a chapter about clang-tidy integrations

[Alexander Kornienko via Phabricator via cfe-commits]

alexfh added a comment.

In D54945#1321301 , @alexfh wrote:

> In D54945#1318343 , @MarinaKalashina 
> wrote:
>
> > @alexfh Thanks a lot for your patience and help. I've made another 
> > revision, now with the diff made by 'git show HEAD -U99' to have the 
> > full context availlable.
>
>
> I don't know how this happened, but the diff is still almost empty.


A correction: it's now empty (and it was broken in a different way last time).

Could you verify that you're correctly following one of the processed described 
in the documentation (https://llvm.org/docs/Phabricator.html)? It looks like 
you're uploading only one commit from the whole branch.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54945/new/

https://reviews.llvm.org/D54945



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D54945: This commit adds a chapter about clang-tidy integrations

[Alexander Kornienko via Phabricator via cfe-commits]

alexfh added a comment.

In D54945#1318343 , @MarinaKalashina 
wrote:

> @alexfh Thanks a lot for your patience and help. I've made another revision, 
> now with the diff made by 'git show HEAD -U99' to have the full context 
> availlable.


I don't know how this happened, but the diff is still almost empty. This is 
what I get when I click on the "Download raw diff":

  Index: docs/clang-tidy/index.rst
  ===
  --- docs/clang-tidy/index.rst
  +++ docs/clang-tidy/index.rst
  @@ -403,7 +403,7 @@
   
   // Silent only the specified diagnostics for the next line
   // NOLINTNEXTLINE(google-explicit-constructor, google-runtime-int)
  -Foo(bool param);
  +Foo(bool param); 
 };
   
   The formal syntax of ``NOLINT``/``NOLINTNEXTLINE`` is the following:

It's definitely not a common problem, since there are other patches in review, 
which are displayed just fine.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54945/new/

https://reviews.llvm.org/D54945



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D54945: This commit adds a chapter about clang-tidy integrations

[Marina Kalashina via Phabricator via cfe-commits]

MarinaKalashina added a comment.

@alexfh Thanks a lot for your patience and help. I've made another revision, 
now with the diff made by 'git show HEAD -U99' to have the full context 
availlable.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54945/new/

https://reviews.llvm.org/D54945



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D54945: This commit adds a chapter about clang-tidy integrations

[Marina Kalashina via Phabricator via cfe-commits]

MarinaKalashina updated this revision to Diff 176601.
MarinaKalashina added a comment.

Full-context patch for the changes introduced in the previous commit.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54945/new/

https://reviews.llvm.org/D54945

Files:
  docs/clang-tidy/index.rst


Index: docs/clang-tidy/index.rst
===
--- docs/clang-tidy/index.rst
+++ docs/clang-tidy/index.rst
@@ -403,7 +403,7 @@
 
 // Silent only the specified diagnostics for the next line
 // NOLINTNEXTLINE(google-explicit-constructor, google-runtime-int)
-Foo(bool param);
+Foo(bool param); 
   };
 
 The formal syntax of ``NOLINT``/``NOLINTNEXTLINE`` is the following:


Index: docs/clang-tidy/index.rst
===
--- docs/clang-tidy/index.rst
+++ docs/clang-tidy/index.rst
@@ -403,7 +403,7 @@
 
 // Silent only the specified diagnostics for the next line
 // NOLINTNEXTLINE(google-explicit-constructor, google-runtime-int)
-Foo(bool param);
+Foo(bool param); 
   };
 
 The formal syntax of ``NOLINT``/``NOLINTNEXTLINE`` is the following:
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D54945: This commit adds a chapter about clang-tidy integrations

[Alexander Kornienko via Phabricator via cfe-commits]

alexfh added a comment.

In D54945#1318283 , @MarinaKalashina 
wrote:

> In D54945#1318278 , @alexfh wrote:
>
> > In D54945#1316251 , 
> > @MarinaKalashina wrote:
> >
> > > Fixes:
> > >
> > > - empty line before 'Standalone tool'
> > > - table columns with '+/-' aligned
> > > - line width limited to 80 (except for the table)
> > >
> > >   Additions:
> > > - clang-tidy-vs plugin
> > > - Clangd in the intro, the table, and CLion's paragraph
> >
> >
> > Did you forget to add a new file to the patch?
> >
> > Please also include full context into the diff. See 
> > https://llvm.org/docs/Phabricator.html
>
>
> Sorry but the new diff was included to the patch.. I can see the updates as 
> Diff 176328. Could you please check and let me know if it does not work? 
> Thank you.


Please see the screenshot. The diff might be reversed (new vs. old) or just 
wrong. And there's no context (not overly important in this particular patch, 
but still makes it more convenient to review).
F7647494: Screenshot from 2018-12-04 13-04-11.jpg 



CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54945/new/

https://reviews.llvm.org/D54945



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D54945: This commit adds a chapter about clang-tidy integrations

[Marina Kalashina via Phabricator via cfe-commits]

MarinaKalashina marked 4 inline comments as done.
MarinaKalashina added a comment.

In D54945#1318278 , @alexfh wrote:

> In D54945#1316251 , @MarinaKalashina 
> wrote:
>
> > Fixes:
> >
> > - empty line before 'Standalone tool'
> > - table columns with '+/-' aligned
> > - line width limited to 80 (except for the table)
> >
> >   Additions:
> > - clang-tidy-vs plugin
> > - Clangd in the intro, the table, and CLion's paragraph
>
>
> Did you forget to add a new file to the patch?
>
> Please also include full context into the diff. See 
> https://llvm.org/docs/Phabricator.html


Sorry but the new diff was included to the patch.. I can see the updates as 
Diff 176328. Could you please check and let me know if it does not work? Thank 
you.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54945/new/

https://reviews.llvm.org/D54945



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D54945: This commit adds a chapter about clang-tidy integrations

[Alexander Kornienko via Phabricator via cfe-commits]

alexfh added a comment.

In D54945#1316251 , @MarinaKalashina 
wrote:

> Fixes:
>
> - empty line before 'Standalone tool'
> - table columns with '+/-' aligned
> - line width limited to 80 (except for the table)
>
>   Additions:
> - clang-tidy-vs plugin
> - Clangd in the intro, the table, and CLion's paragraph


Did you forget to add a new file to the patch?

Please also include full context into the diff. See 
https://llvm.org/docs/Phabricator.html


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54945/new/

https://reviews.llvm.org/D54945



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D54945: This commit adds a chapter about clang-tidy integrations

[Marina Kalashina via Phabricator via cfe-commits]

MarinaKalashina updated this revision to Diff 176328.
MarinaKalashina added a comment.

Fixes:

- empty line before 'Standalone tool'
- table columns with '+/-' aligned
- line width limited to 80 (except for the table)

Additions:

- clang-tidy-vs plugin
- Clangd in the intro, the table, and CLion's paragraph


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54945/new/

https://reviews.llvm.org/D54945

Files:
  docs/clang-tidy/index.rst

Index: docs/clang-tidy/index.rst
===
--- docs/clang-tidy/index.rst
+++ docs/clang-tidy/index.rst
@@ -21,9 +21,6 @@
 Using clang-tidy
 
 
-Standalone tool

-
 :program:`clang-tidy` is a `LibTooling`_-based tool, and it's easier to work
 with if you set up a compile command database for your project (for an example
 of how to do this see `How To Setup Tooling For LLVM`_). You can also specify
@@ -258,125 +255,6 @@
   value:   'some value'
   ...
 
-
-Clang-tidy integrated
--
-
-.. _Clangd: https://clang.llvm.org/extra/clangd.html
-
-Apart from being a standalone tool, :program:`clang-tidy` is integrated into
-various IDEs, code analyzers, and editors. Besides, it is currently being
-integrated into Clangd_. The following table shows the most
-well-known :program:`clang-tidy` integrations in detail.
-
-+--++-+--+-+--+
-|  |Feature   |
-+==++=+==+=+==+
-|  **Tool**| On-the-fly inspection  | Check list configuration (GUI)  | Options to checks (GUI)  | Configuration via ``.clang-tidy`` files | Custom clang-tidy binary |
-+--++-+--+-+--+
-|A.L.E. for Vim| \+\|   \-\   |   \-\| \-\ |   \+\|
-+--++-+--+-+--+
-|Clang Power Tools for Visual Studio   | \-\|   \+\   |   \-\| \+\ |   \-\|
-+--++-+--+-+--+
-|Clangd| \+\|   \-\   |   \-\| \-\ |   \-\|
-+--++-+--+-+--+
-|CLion IDE | \+\|   \+\   |   \+\| \+\ |   \+\|
-+--++-+--+-+--+
-|CodeChecker   | \-\|   \-\   |   \-\| \-\ |   \+\|
-+--++-+--+-+--+
-|CPPCheck  | \-\|   \-\   |   \-\| \-\ |   \-\|
-+--++-+--+-+--+
-|CPPDepend | \-\|   \-\   |   \-\| \-\ |   \-\|

[PATCH] D54945: This commit adds a chapter about clang-tidy integrations

[Eugene Zelenko via Phabricator via cfe-commits]

Eugene.Zelenko added inline comments.



Comment at: docs/clang-tidy/index.rst:304
+CLion_ 2017.2 and later `integrates clang-tidy`_ as an extension to the 
built-in code analyzer.
+Inspections and applicable quick-fixes are performed on the fly, and checks 
can be configured in the standard command line
+format. In this integration, you can switch to the :program:`clang-tidy` 
binary different from the bundled one and pass

Please limit line width to 80 characters. Same in other places.



Comment at: docs/clang-tidy/index.rst:327
+
+`MS Visual Studio`_ can integrate :program:`clang-tidy` by means of three 
different tools.
+The `ReSharper C++`_ extension, version 2017.3 and later, provides seamless 
:program:`clang-tidy` integration:

Will be good idea to mention native plugin, clang-tidy-vs.


Repository:
  rCTE Clang Tools Extra

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54945/new/

https://reviews.llvm.org/D54945



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D54945: This commit adds a chapter about clang-tidy integrations

[Sam McCall via Phabricator via cfe-commits]

sammccall added a comment.

In D54945#1309467 , @JonasToth wrote:

> I like the overview, maybe a link to `clangd` here might help, as there is 
> currently a lot of effort of integrating `clang-tidy` into it. (@sammccall 
> WDYT?)


This would be great! The integration is not yet complete, so I'm not sure if 
it's best to add now or later.

For the table:

- on-the-fly inspection: yes (I think - this means showing fixes overlaid on 
the code as you edit, right?)
- check list configuration (GUI): no
- options to checks (GUI): no
- configuration via .clang-tidy file: this will be the supported mechanism. Not 
done yet.
- custom clang-tidy binary: no

The behavior today is that three hard-coded checks are always enabled, as a 
proof-of-concept. Configuration via .clang-tidy is the main missing piece.
Clang-tidy diagnostics are shown along with others, as-you-type. Fixes can be 
applied.
Static analyzer checks will probably never be supported.


Repository:
  rCTE Clang Tools Extra

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54945/new/

https://reviews.llvm.org/D54945



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D54945: This commit adds a chapter about clang-tidy integrations

[Alexander Kornienko via Phabricator via cfe-commits]

alexfh added a comment.

Should this chapter be a separate page linked from index.md?


Repository:
  rCTE Clang Tools Extra

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54945/new/

https://reviews.llvm.org/D54945



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D54945: This commit adds a chapter about clang-tidy integrations

[Jonas Toth via Phabricator via cfe-commits]

JonasToth added subscribers: sammccall, JonasToth.
JonasToth added a comment.

I like the overview, maybe a link to `clangd` here might help, as there is 
currently a lot of effort of integrating `clang-tidy` into it. (@sammccall 
WDYT?)




Comment at: docs/clang-tidy/index.rst:23
 
+Standalone tool
+---

I think a blank line here would not hurt.



Comment at: docs/clang-tidy/index.rst:274
++--++-+--+-+--+
+|Clang Power Tools for Visual Studio   |  \-\   |  
  \+\  |   \-\| \+\ 
|\-\   |
++--++-+--+-+--+

Could you please align the elements in the columns, some are off by one.


Repository:
  rCTE Clang Tools Extra

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54945/new/

https://reviews.llvm.org/D54945



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D54945: This commit adds a chapter about clang-tidy integrations

[Marina Kalashina via Phabricator via cfe-commits]

MarinaKalashina created this revision.
MarinaKalashina added a reviewer: asl.
Herald added subscribers: cfe-commits, arphaman.

Proposing changes to //clang-tools-extra/docs/clang-tidy/index.rst//

'Using clang-tidy' was split into 2 chapters:

- 'Standalone tool' (the previous content of 'Using clang-tidy')
- 'Clang-tidy integrated' (a new chapter)


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D54945

Files:
  docs/clang-tidy/index.rst

Index: docs/clang-tidy/index.rst
===
--- docs/clang-tidy/index.rst
+++ docs/clang-tidy/index.rst
@@ -20,6 +20,8 @@
 
 Using clang-tidy
 
+Standalone tool
+---
 
 :program:`clang-tidy` is a `LibTooling`_-based tool, and it's easier to work
 with if you set up a compile command database for your project (for an example
@@ -255,6 +257,105 @@
   value:   'some value'
   ...
 
+
+Clang-tidy integrated
+-
+Apart from being a standalone tool, :program:`clang-tidy` is integrated into various IDEs,
+code analyzers, and editors. The following table shows the most well-known :program:`clang-tidy` integrations
+in detail.
+
++--++-+--+-+--+
+|  |Feature   |
++==++=+==+=+==+
+|  **Tool**| On-the-fly inspection  | Check list configuration (GUI)  | Options to checks (GUI)  | Configuration via ``.clang-tidy`` files | Custom clang-tidy binary |
++--++-+--+-+--+
+|A.L.E. for Vim| \+\|   \-\   |   \-\| \-\ |   \+\|
++--++-+--+-+--+
+|Clang Power Tools for Visual Studio   |  \-\   |\+\  |   \-\| \+\ |\-\   |
++--++-+--+-+--+
+|CLion IDE | \+\|\+\  |   \+\| \+\ |   \+\|
++--++-+--+-+--+
+|CodeChecker   |  \-\   |   \-\   |   \-\| \-\ |   \+\|
++--++-+--+-+--+
+|CPPCheck  |  \-\   |   \-\   |   \-\| \-\ |   \-\|
++--++-+--+-+--+
+|CPPDepend |  \-\   |   \-\   |   \-\| \-\ |   \-\|
++--++-+--+-+--+
+|Flycheck for Emacs|  \+\   |   \-\   |   \-\| \+\ |   \+\|
++--++-+--+-+--+
+|KDevelop IDE  |