[PATCH] D59621: [libcxx] [test] Add (void) casts to operator new calls, to suppress warnings generated by [[nodiscard]].

[Louis Dionne via Phabricator via cfe-commits]

ldionne added a comment.

In D59621#1439870 , @BillyONeal wrote:

> This didn't work out, we'll just skip the tests for MSVC++ for now.


I'd like to understand what's breaking on MSVC so we can address the problem 
properly -- but I won't push if you just want to skip the tests.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59621/new/

https://reviews.llvm.org/D59621



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D59621: [libcxx] [test] Add (void) casts to operator new calls, to suppress warnings generated by [[nodiscard]].

[Billy Robert O'Neal III via Phabricator via cfe-commits]

BillyONeal abandoned this revision.
BillyONeal added a comment.

This didn't work out, we'll just skip the tests for MSVC++ for now.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59621/new/

https://reviews.llvm.org/D59621



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D59621: [libcxx] [test] Add (void) casts to operator new calls, to suppress warnings generated by [[nodiscard]].

[Billy Robert O'Neal III via Phabricator via cfe-commits]

BillyONeal added a comment.

This broke all the build bots, so I reverted the SVN change. I thought the 
nodiscard-ness was tested elsewhere but I'm not sure about interaction between 
this and -faligned-allocation.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59621/new/

https://reviews.llvm.org/D59621



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D59621: [libcxx] [test] Add (void) casts to operator new calls, to suppress warnings generated by [[nodiscard]].

[Billy Robert O'Neal III via Phabricator via cfe-commits]

BillyONeal added a comment.

As an FYI, I committed this to subversion as r356632 since I haven't figured 
out the new git world order yet.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59621/new/

https://reviews.llvm.org/D59621



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D59621: [libcxx] [test] Add (void) casts to operator new calls, to suppress warnings generated by [[nodiscard]].

[Billy Robert O'Neal III via Phabricator via cfe-commits]

BillyONeal created this revision.
BillyONeal added reviewers: EricWF, mclow.lists, ldionne.
Herald added a subscriber: jdoerfert.

Add (void) casts to operator new calls, to suppress warnings generated by 
[[nodiscard]].

This allows these tests to pass when compiled by MSVC++.


https://reviews.llvm.org/D59621

Files:
  
test/std/language.support/support.dynamic/new.delete/new.delete.array/new_size.sh.cpp
  
test/std/language.support/support.dynamic/new.delete/new.delete.array/new_size_align.sh.cpp
  
test/std/language.support/support.dynamic/new.delete/new.delete.array/new_size_align_nothrow.sh.cpp
  
test/std/language.support/support.dynamic/new.delete/new.delete.array/new_size_nothrow.sh.cpp
  
test/std/language.support/support.dynamic/new.delete/new.delete.single/new_size_align.sh.cpp
  
test/std/language.support/support.dynamic/new.delete/new.delete.single/new_size_align_nothrow.sh.cpp


Index: 
test/std/language.support/support.dynamic/new.delete/new.delete.single/new_size_align_nothrow.sh.cpp
===
--- 
test/std/language.support/support.dynamic/new.delete/new.delete.single/new_size_align_nothrow.sh.cpp
+++ 
test/std/language.support/support.dynamic/new.delete/new.delete.single/new_size_align_nothrow.sh.cpp
@@ -21,5 +21,5 @@
 
 int main ()
 {
-::operator new(4, std::align_val_t{4}, std::nothrow);  // expected-warning 
{{ignoring return value of function declared with 'nodiscard' attribute}}
+(void)::operator new(4, std::align_val_t{4}, std::nothrow);
 }
Index: 
test/std/language.support/support.dynamic/new.delete/new.delete.single/new_size_align.sh.cpp
===
--- 
test/std/language.support/support.dynamic/new.delete/new.delete.single/new_size_align.sh.cpp
+++ 
test/std/language.support/support.dynamic/new.delete/new.delete.single/new_size_align.sh.cpp
@@ -21,5 +21,5 @@
 
 int main ()
 {
-::operator new(4, std::align_val_t{4});  // expected-warning {{ignoring 
return value of function declared with 'nodiscard' attribute}}
+(void)::operator new(4, std::align_val_t{4});
 }
Index: 
test/std/language.support/support.dynamic/new.delete/new.delete.array/new_size_nothrow.sh.cpp
===
--- 
test/std/language.support/support.dynamic/new.delete/new.delete.array/new_size_nothrow.sh.cpp
+++ 
test/std/language.support/support.dynamic/new.delete/new.delete.array/new_size_nothrow.sh.cpp
@@ -21,5 +21,5 @@
 
 int main ()
 {
-::operator new[](4, std::nothrow);  // expected-warning {{ignoring return 
value of function declared with 'nodiscard' attribute}}
+(void)::operator new[](4, std::nothrow);
 }
Index: 
test/std/language.support/support.dynamic/new.delete/new.delete.array/new_size_align_nothrow.sh.cpp
===
--- 
test/std/language.support/support.dynamic/new.delete/new.delete.array/new_size_align_nothrow.sh.cpp
+++ 
test/std/language.support/support.dynamic/new.delete/new.delete.array/new_size_align_nothrow.sh.cpp
@@ -21,5 +21,5 @@
 
 int main ()
 {
-::operator new[](4, std::align_val_t{4}, std::nothrow);  // 
expected-warning {{ignoring return value of function declared with 'nodiscard' 
attribute}}
+(void)::operator new[](4, std::align_val_t{4}, std::nothrow);
 }
Index: 
test/std/language.support/support.dynamic/new.delete/new.delete.array/new_size_align.sh.cpp
===
--- 
test/std/language.support/support.dynamic/new.delete/new.delete.array/new_size_align.sh.cpp
+++ 
test/std/language.support/support.dynamic/new.delete/new.delete.array/new_size_align.sh.cpp
@@ -21,5 +21,5 @@
 
 int main ()
 {
-::operator new[](4, std::align_val_t{4});  // expected-warning {{ignoring 
return value of function declared with 'nodiscard' attribute}}
+(void)::operator new[](4, std::align_val_t{4});
 }
Index: 
test/std/language.support/support.dynamic/new.delete/new.delete.array/new_size.sh.cpp
===
--- 
test/std/language.support/support.dynamic/new.delete/new.delete.array/new_size.sh.cpp
+++ 
test/std/language.support/support.dynamic/new.delete/new.delete.array/new_size.sh.cpp
@@ -21,5 +21,5 @@
 
 int main ()
 {
-::operator new[](4);  // expected-warning {{ignoring return value of 
function declared with 'nodiscard' attribute}}
+(void)::operator new[](4);
 }


Index: test/std/language.support/support.dynamic/new.delete/new.delete.single/new_size_align_nothrow.sh.cpp
===
--- test/std/language.support/support.dynamic/new.delete/new.delete.single/new_size_align_nothrow.sh.cpp
+++ test/std/language.support/support.dynamic/new.delete/new.delete.single/new_size_align_nothrow.sh.cpp
@@ -21,5 +21,5 @@
 
 int main ()
 {
-::operator new(4, std::align_val_t{4},