[PATCH] D60238: Verify that Android targets generate DWARF 4 by default.
This revision was automatically updated to reflect the committed changes. Closed by commit rL357713: Verify that Android targets generate DWARF 4 by default. (authored by srhines, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D60238?vs=193621=193753#toc Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60238/new/ https://reviews.llvm.org/D60238 Files: cfe/trunk/test/Driver/debug-options.c Index: cfe/trunk/test/Driver/debug-options.c === --- cfe/trunk/test/Driver/debug-options.c +++ cfe/trunk/test/Driver/debug-options.c @@ -17,9 +17,14 @@ // RUN: %clang -### -c -glldb %s -target x86_64-linux-gnu 2>&1 \ // RUN: | FileCheck -check-prefix=G -check-prefix=G_LLDB %s // RUN: %clang -### -c -gsce %s -target x86_64-linux-gnu 2>&1 \ +// RUN: | FileCheck -check-prefix=G -check-prefix=G_SCE %s + +// Android. +// Android should always generate DWARF4. +// RUN: %clang -### -c -g %s -target arm-linux-androideabi 2>&1 \ +// RUN: | FileCheck -check-prefix=G -check-prefix=G_DWARF4 %s // Darwin. -// RUN: | FileCheck -check-prefix=G -check-prefix=G_SCE %s // RUN: %clang -### -c -g %s -target x86_64-apple-darwin 2>&1 \ // RUN: | FileCheck -check-prefix=G_STANDALONE \ // RUN: -check-prefix=G_DWARF2 \ @@ -272,6 +277,7 @@ // // G_STANDALONE: "-cc1" // G_STANDALONE: "-debug-info-kind=standalone" +// G_DWARF2: "-dwarf-version=2" // G_DWARF4: "-dwarf-version=4" // // G_GDB: "-debugger-tuning=gdb" Index: cfe/trunk/test/Driver/debug-options.c === --- cfe/trunk/test/Driver/debug-options.c +++ cfe/trunk/test/Driver/debug-options.c @@ -17,9 +17,14 @@ // RUN: %clang -### -c -glldb %s -target x86_64-linux-gnu 2>&1 \ // RUN: | FileCheck -check-prefix=G -check-prefix=G_LLDB %s // RUN: %clang -### -c -gsce %s -target x86_64-linux-gnu 2>&1 \ +// RUN: | FileCheck -check-prefix=G -check-prefix=G_SCE %s + +// Android. +// Android should always generate DWARF4. +// RUN: %clang -### -c -g %s -target arm-linux-androideabi 2>&1 \ +// RUN: | FileCheck -check-prefix=G -check-prefix=G_DWARF4 %s // Darwin. -// RUN: | FileCheck -check-prefix=G -check-prefix=G_SCE %s // RUN: %clang -### -c -g %s -target x86_64-apple-darwin 2>&1 \ // RUN: | FileCheck -check-prefix=G_STANDALONE \ // RUN: -check-prefix=G_DWARF2 \ @@ -272,6 +277,7 @@ // // G_STANDALONE: "-cc1" // G_STANDALONE: "-debug-info-kind=standalone" +// G_DWARF2: "-dwarf-version=2" // G_DWARF4: "-dwarf-version=4" // // G_GDB: "-debugger-tuning=gdb" ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D60238: Verify that Android targets generate DWARF 4 by default.
aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. Good catch! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60238/new/ https://reviews.llvm.org/D60238 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D60238: Verify that Android targets generate DWARF 4 by default.
srhines marked an inline comment as done. srhines added inline comments. Comment at: clang/test/Driver/debug-options.c:280 // G_STANDALONE: "-debug-info-kind=standalone" +// G_DWARF2: "-dwarf-version=2" // G_DWARF4: "-dwarf-version=4" aprantl wrote: > What's that for? Look at Line 30. You added references to it from a while ago, but it didn't exist. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60238/new/ https://reviews.llvm.org/D60238 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D60238: Verify that Android targets generate DWARF 4 by default.
aprantl added inline comments. Comment at: clang/test/Driver/debug-options.c:280 // G_STANDALONE: "-debug-info-kind=standalone" +// G_DWARF2: "-dwarf-version=2" // G_DWARF4: "-dwarf-version=4" What's that for? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60238/new/ https://reviews.llvm.org/D60238 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D60238: Verify that Android targets generate DWARF 4 by default.
srhines created this revision. srhines added a reviewer: aprantl. Herald added a project: clang. Herald added a subscriber: cfe-commits. srhines added subscribers: pirama, chh. In the future, Android releases will support DWARF 5, but we need to ensure that older targets only have DWARF 4 generated for them. This patch inserts that verification for all Android releases now. The patch also fixes 2 minor mistakes (a mistakenly moved RUN line, and the missing G_DWARF2 check label). Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D60238 Files: clang/test/Driver/debug-options.c Index: clang/test/Driver/debug-options.c === --- clang/test/Driver/debug-options.c +++ clang/test/Driver/debug-options.c @@ -17,9 +17,14 @@ // RUN: %clang -### -c -glldb %s -target x86_64-linux-gnu 2>&1 \ // RUN: | FileCheck -check-prefix=G -check-prefix=G_LLDB %s // RUN: %clang -### -c -gsce %s -target x86_64-linux-gnu 2>&1 \ +// RUN: | FileCheck -check-prefix=G -check-prefix=G_SCE %s + +// Android. +// Android should always generate DWARF4. +// RUN: %clang -### -c -g %s -target arm-linux-androideabi 2>&1 \ +// RUN: | FileCheck -check-prefix=G -check-prefix=G_DWARF4 %s // Darwin. -// RUN: | FileCheck -check-prefix=G -check-prefix=G_SCE %s // RUN: %clang -### -c -g %s -target x86_64-apple-darwin 2>&1 \ // RUN: | FileCheck -check-prefix=G_STANDALONE \ // RUN: -check-prefix=G_DWARF2 \ @@ -272,6 +277,7 @@ // // G_STANDALONE: "-cc1" // G_STANDALONE: "-debug-info-kind=standalone" +// G_DWARF2: "-dwarf-version=2" // G_DWARF4: "-dwarf-version=4" // // G_GDB: "-debugger-tuning=gdb" Index: clang/test/Driver/debug-options.c === --- clang/test/Driver/debug-options.c +++ clang/test/Driver/debug-options.c @@ -17,9 +17,14 @@ // RUN: %clang -### -c -glldb %s -target x86_64-linux-gnu 2>&1 \ // RUN: | FileCheck -check-prefix=G -check-prefix=G_LLDB %s // RUN: %clang -### -c -gsce %s -target x86_64-linux-gnu 2>&1 \ +// RUN: | FileCheck -check-prefix=G -check-prefix=G_SCE %s + +// Android. +// Android should always generate DWARF4. +// RUN: %clang -### -c -g %s -target arm-linux-androideabi 2>&1 \ +// RUN: | FileCheck -check-prefix=G -check-prefix=G_DWARF4 %s // Darwin. -// RUN: | FileCheck -check-prefix=G -check-prefix=G_SCE %s // RUN: %clang -### -c -g %s -target x86_64-apple-darwin 2>&1 \ // RUN: | FileCheck -check-prefix=G_STANDALONE \ // RUN: -check-prefix=G_DWARF2 \ @@ -272,6 +277,7 @@ // // G_STANDALONE: "-cc1" // G_STANDALONE: "-debug-info-kind=standalone" +// G_DWARF2: "-dwarf-version=2" // G_DWARF4: "-dwarf-version=4" // // G_GDB: "-debugger-tuning=gdb" ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
