[PATCH] D61002: <[analyzer][CrossTU][NFC] Fix sanitizer test failure
r.stahl added a comment. @xazax.hun Yes, I planned to just commit. Set you as Subscriber not Reviewer in Arc. Was just a bit confused why it fails at first :) Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61002/new/ https://reviews.llvm.org/D61002 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D61002: <[analyzer][CrossTU][NFC] Fix sanitizer test failure
xazax.hun accepted this revision. xazax.hun added a comment. This revision is now accepted and ready to land. Herald added a subscriber: rnkovacs. Feel free to commit such trivial fixes without reviews. Alternatively, you could use LLVM_FALLTHROUGH, but I have no strong preference in this case. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61002/new/ https://reviews.llvm.org/D61002 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D61002: <[analyzer][CrossTU][NFC] Fix sanitizer test failure
r.stahl abandoned this revision. r.stahl added a comment. Was already done: https://github.com/llvm-mirror/clang/commit/bacdda22396c39181aa0e641182e01a0b3cf43ea Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61002/new/ https://reviews.llvm.org/D61002 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D61002: <[analyzer][CrossTU][NFC] Fix sanitizer test failure
r.stahl created this revision. Herald added subscribers: cfe-commits, Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware. Herald added a project: clang. Missing break/fallthrough Repository: rC Clang https://reviews.llvm.org/D61002 Files: tools/clang-extdef-mapping/ClangExtDefMapGen.cpp Index: tools/clang-extdef-mapping/ClangExtDefMapGen.cpp === --- tools/clang-extdef-mapping/ClangExtDefMapGen.cpp +++ tools/clang-extdef-mapping/ClangExtDefMapGen.cpp @@ -90,6 +90,7 @@ case UniqueExternalLinkage: if (SM.isInMainFile(defStart)) Index[LookupName] = CurrentFileName; +break; default: break; } Index: tools/clang-extdef-mapping/ClangExtDefMapGen.cpp === --- tools/clang-extdef-mapping/ClangExtDefMapGen.cpp +++ tools/clang-extdef-mapping/ClangExtDefMapGen.cpp @@ -90,6 +90,7 @@ case UniqueExternalLinkage: if (SM.isInMainFile(defStart)) Index[LookupName] = CurrentFileName; +break; default: break; } ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
