[PATCH] D64278: Rename libclang_shared to libclang-cpp
sylvestre.ledru added a comment. @beanz By the way, maybe we should add this in the 9 release notes? Thanks Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64278/new/ https://reviews.llvm.org/D64278 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D64278: Rename libclang_shared to libclang-cpp
This revision was automatically updated to reflect the committed changes. Closed by commit rL365831: Rename libclang_shared to libclang-cpp (authored by sylvestre, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D64278?vs=208258&id=209346#toc Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64278/new/ https://reviews.llvm.org/D64278 Files: cfe/trunk/CMakeLists.txt cfe/trunk/cmake/modules/AddClang.cmake cfe/trunk/tools/clang-shlib/CMakeLists.txt Index: cfe/trunk/CMakeLists.txt === --- cfe/trunk/CMakeLists.txt +++ cfe/trunk/CMakeLists.txt @@ -324,7 +324,7 @@ "Python versions to install libclang python bindings for") set(CLANG_LINK_CLANG_DYLIB ${LLVM_LINK_LLVM_DYLIB} CACHE BOOL -"Link tools against libclang_shared.so") +"Link tools against libclang-cpp.so") if (NOT LLVM_LINK_LLVM_DYLIB AND CLANG_LINK_CLANG_DYLIB) message(FATAL_ERROR "Cannot set CLANG_LINK_CLANG_DYLIB=ON when " Index: cfe/trunk/tools/clang-shlib/CMakeLists.txt === --- cfe/trunk/tools/clang-shlib/CMakeLists.txt +++ cfe/trunk/tools/clang-shlib/CMakeLists.txt @@ -1,4 +1,4 @@ -# Building libclang_shared.so fails if LLVM_ENABLE_PIC=Off +# Building libclang-cpp.so fails if LLVM_ENABLE_PIC=Off if (NOT LLVM_ENABLE_PIC) return() endif() @@ -38,7 +38,7 @@ list(APPEND _DEPS ${lib}) endforeach () -add_clang_library(clang_shared +add_clang_library(clang-cpp SHARED clang-shlib.cpp ${_OBJECTS} Index: cfe/trunk/cmake/modules/AddClang.cmake === --- cfe/trunk/cmake/modules/AddClang.cmake +++ cfe/trunk/cmake/modules/AddClang.cmake @@ -175,7 +175,7 @@ function(clang_target_link_libraries target type) if (CLANG_LINK_CLANG_DYLIB) -target_link_libraries(${target} ${type} clang_shared) +target_link_libraries(${target} ${type} clang-cpp) else() target_link_libraries(${target} ${type} ${ARGN}) endif() Index: cfe/trunk/CMakeLists.txt === --- cfe/trunk/CMakeLists.txt +++ cfe/trunk/CMakeLists.txt @@ -324,7 +324,7 @@ "Python versions to install libclang python bindings for") set(CLANG_LINK_CLANG_DYLIB ${LLVM_LINK_LLVM_DYLIB} CACHE BOOL -"Link tools against libclang_shared.so") +"Link tools against libclang-cpp.so") if (NOT LLVM_LINK_LLVM_DYLIB AND CLANG_LINK_CLANG_DYLIB) message(FATAL_ERROR "Cannot set CLANG_LINK_CLANG_DYLIB=ON when " Index: cfe/trunk/tools/clang-shlib/CMakeLists.txt === --- cfe/trunk/tools/clang-shlib/CMakeLists.txt +++ cfe/trunk/tools/clang-shlib/CMakeLists.txt @@ -1,4 +1,4 @@ -# Building libclang_shared.so fails if LLVM_ENABLE_PIC=Off +# Building libclang-cpp.so fails if LLVM_ENABLE_PIC=Off if (NOT LLVM_ENABLE_PIC) return() endif() @@ -38,7 +38,7 @@ list(APPEND _DEPS ${lib}) endforeach () -add_clang_library(clang_shared +add_clang_library(clang-cpp SHARED clang-shlib.cpp ${_OBJECTS} Index: cfe/trunk/cmake/modules/AddClang.cmake === --- cfe/trunk/cmake/modules/AddClang.cmake +++ cfe/trunk/cmake/modules/AddClang.cmake @@ -175,7 +175,7 @@ function(clang_target_link_libraries target type) if (CLANG_LINK_CLANG_DYLIB) -target_link_libraries(${target} ${type} clang_shared) +target_link_libraries(${target} ${type} clang-cpp) else() target_link_libraries(${target} ${type} ${ARGN}) endif() ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D64278: Rename libclang_shared to libclang-cpp
beanz accepted this revision. beanz added a comment. This revision is now accepted and ready to land. This is fine with me. I have no real attachment to the name. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64278/new/ https://reviews.llvm.org/D64278 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D64278: Rename libclang_shared to libclang-cpp
sylvestre.ledru added a comment. I would like to land that before the 9 branch. @tstellar do you sign off on this change? Thanks Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64278/new/ https://reviews.llvm.org/D64278 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D64278: Rename libclang_shared to libclang-cpp
sylvestre.ledru added a comment. @beanz works for you? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64278/new/ https://reviews.llvm.org/D64278 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D64278: Rename libclang_shared to libclang-cpp
tstellar added a comment. I'm fine with this new name. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64278/new/ https://reviews.llvm.org/D64278 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D64278: Rename libclang_shared to libclang-cpp
sylvestre.ledru created this revision. sylvestre.ledru added reviewers: beanz, tstellar. Herald added subscribers: cfe-commits, mgorny. Herald added a project: clang. sylvestre.ledru edited the summary of this revision. Fix bug 42475 Repository: rC Clang https://reviews.llvm.org/D64278 Files: CMakeLists.txt cmake/modules/AddClang.cmake tools/clang-shlib/CMakeLists.txt Index: tools/clang-shlib/CMakeLists.txt === --- tools/clang-shlib/CMakeLists.txt +++ tools/clang-shlib/CMakeLists.txt @@ -1,4 +1,4 @@ -# Building libclang_shared.so fails if LLVM_ENABLE_PIC=Off +# Building libclang-cpp.so fails if LLVM_ENABLE_PIC=Off if (NOT LLVM_ENABLE_PIC) return() endif() @@ -11,7 +11,7 @@ list(APPEND _DEPS $) endforeach () -add_clang_library(clang_shared +add_clang_library(clang-cpp SHARED clang-shlib.cpp ${_OBJECTS} Index: cmake/modules/AddClang.cmake === --- cmake/modules/AddClang.cmake +++ cmake/modules/AddClang.cmake @@ -175,7 +175,7 @@ function(clang_target_link_libraries target type) if (CLANG_LINK_CLANG_DYLIB) -target_link_libraries(${target} ${type} clang_shared) +target_link_libraries(${target} ${type} clang-cpp) else() target_link_libraries(${target} ${type} ${ARGN}) endif() Index: CMakeLists.txt === --- CMakeLists.txt +++ CMakeLists.txt @@ -324,7 +324,7 @@ "Python versions to install libclang python bindings for") set(CLANG_LINK_CLANG_DYLIB ${LLVM_LINK_LLVM_DYLIB} CACHE BOOL -"Link tools against libclang_shared.so") +"Link tools against libclang-cpp.so") if (NOT LLVM_LINK_LLVM_DYLIB AND CLANG_LINK_CLANG_DYLIB) message(FATAL_ERROR "Cannot set CLANG_LINK_CLANG_DYLIB=ON when " Index: tools/clang-shlib/CMakeLists.txt === --- tools/clang-shlib/CMakeLists.txt +++ tools/clang-shlib/CMakeLists.txt @@ -1,4 +1,4 @@ -# Building libclang_shared.so fails if LLVM_ENABLE_PIC=Off +# Building libclang-cpp.so fails if LLVM_ENABLE_PIC=Off if (NOT LLVM_ENABLE_PIC) return() endif() @@ -11,7 +11,7 @@ list(APPEND _DEPS $) endforeach () -add_clang_library(clang_shared +add_clang_library(clang-cpp SHARED clang-shlib.cpp ${_OBJECTS} Index: cmake/modules/AddClang.cmake === --- cmake/modules/AddClang.cmake +++ cmake/modules/AddClang.cmake @@ -175,7 +175,7 @@ function(clang_target_link_libraries target type) if (CLANG_LINK_CLANG_DYLIB) -target_link_libraries(${target} ${type} clang_shared) +target_link_libraries(${target} ${type} clang-cpp) else() target_link_libraries(${target} ${type} ${ARGN}) endif() Index: CMakeLists.txt === --- CMakeLists.txt +++ CMakeLists.txt @@ -324,7 +324,7 @@ "Python versions to install libclang python bindings for") set(CLANG_LINK_CLANG_DYLIB ${LLVM_LINK_LLVM_DYLIB} CACHE BOOL -"Link tools against libclang_shared.so") +"Link tools against libclang-cpp.so") if (NOT LLVM_LINK_LLVM_DYLIB AND CLANG_LINK_CLANG_DYLIB) message(FATAL_ERROR "Cannot set CLANG_LINK_CLANG_DYLIB=ON when " ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits