[PATCH] D68321: Fix clang Visual Studio build instructions
This revision was automatically updated to reflect the committed changes. Closed by commit rG6e77a67171e6: Fix clang Visual Studio build instructions (authored by Loghorn, committed by amccarth). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68321/new/ https://reviews.llvm.org/D68321 Files: clang/www/get_started.html Index: clang/www/get_started.html === --- clang/www/get_started.html +++ clang/www/get_started.html @@ -137,7 +137,7 @@ Run CMake to generate the Visual Studio solution and project files: -cd ..\.. (back to where you started) +cd llvm-project mkdir build (for building without polluting the source dir) cd build Index: clang/www/get_started.html === --- clang/www/get_started.html +++ clang/www/get_started.html @@ -137,7 +137,7 @@ Run CMake to generate the Visual Studio solution and project files: -cd ..\.. (back to where you started) +cd llvm-project mkdir build (for building without polluting the source dir) cd build ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D68321: Fix clang Visual Studio build instructions
amccarth added a comment. I'll merge it for you. Reviewers generally assume you have commit access and will submit it yourself unless tell them otherwise. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68321/new/ https://reviews.llvm.org/D68321 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D68321: Fix clang Visual Studio build instructions
Loghorn added a comment. Is there a chance this will ever be merged? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68321/new/ https://reviews.llvm.org/D68321 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D68321: Fix clang Visual Studio build instructions
rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68321/new/ https://reviews.llvm.org/D68321 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D68321: Fix clang Visual Studio build instructions
Loghorn created this revision. Loghorn added reviewers: rnk, rsmith. Loghorn added a project: clang. Herald added a subscriber: cfe-commits. Change cd ..\.. to cd llvm-project (the former is probably a leftover of the old svn instructions) Repository: rC Clang https://reviews.llvm.org/D68321 Files: clang/www/get_started.html Index: clang/www/get_started.html === --- clang/www/get_started.html +++ clang/www/get_started.html @@ -137,7 +137,7 @@ Run CMake to generate the Visual Studio solution and project files: -cd ..\.. (back to where you started) +cd llvm-project mkdir build (for building without polluting the source dir) cd build Index: clang/www/get_started.html === --- clang/www/get_started.html +++ clang/www/get_started.html @@ -137,7 +137,7 @@ Run CMake to generate the Visual Studio solution and project files: -cd ..\.. (back to where you started) +cd llvm-project mkdir build (for building without polluting the source dir) cd build ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
