[PATCH] D74384: Use std::foo_t rather than std::foo in LLVM.

[Nico Weber via Phabricator via cfe-commits]

thakis added a comment.

That landed in 17b77418121139c4e8cfb050d82ead3f29db7132 
. Sounds 
like there's more SFINAE to be fixed here, but my build is happy again. Thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74384/new/

https://reviews.llvm.org/D74384



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D74384: Use std::foo_t rather than std::foo in LLVM.

[Justin Lebar via Phabricator via cfe-commits]

jlebar added a comment.

In D74384#1872246 , @thakis wrote:

> Looks like this broke building on windows with clang-cl as host compiler in 
> some situations: http://45.33.8.238/win/8160/step_4.txt


I'm testing out the following fix, which we verified works for Nico.

No idea why this only affects clang-cl.  SFINAE is hard.

  commit 10cf8de244df1402c2b87205f427440fb4c0d7b9
  Author: Justin Lebar 
  Date:   Wed Feb 12 08:05:00 2020 -0800
  
  Fix compilation of Any.h header.
  
  In a previous patch I changed `std::decay::type` to `std::decay`
  rather than `std::decay_t`.  This seems to have broken the build
  *only for clang-cl*.  I don't know why.
  
  diff --git a/llvm/include/llvm/ADT/Any.h b/llvm/include/llvm/ADT/Any.h
  index 9d819841e3f..0aded628cda 100644
  --- a/llvm/include/llvm/ADT/Any.h
  +++ b/llvm/include/llvm/ADT/Any.h
  @@ -74,7 +74,7 @@ public:
   // adopting it to work-around usage of `Any` with types 
that
   // need to be implicitly convertible from an `Any`.
   llvm::negation>>,
  -std::is_copy_constructible>>::value,
  +std::is_copy_constructible>>::value,
   int> = 0>
 Any(T &) {
   Storage =


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74384/new/

https://reviews.llvm.org/D74384



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D74384: Use std::foo_t rather than std::foo in LLVM.

[Nico Weber via Phabricator via cfe-commits]

thakis added a comment.

Looks like this broke building on windows with clang-cl as host compiler in 
some situations: http://45.33.8.238/win/8160/step_4.txt

I'm not sure if that's a bug in the version of the host clang I'm using yet. 
I'll poke around a bit and let you know.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74384/new/

https://reviews.llvm.org/D74384



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D74384: Use std::foo_t rather than std::foo in LLVM.

[Benjamin Kramer via Phabricator via cfe-commits]

bkramer accepted this revision.
bkramer added a comment.

Push and watch the bots


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74384/new/

https://reviews.llvm.org/D74384



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D74384: Use std::foo_t rather than std::foo in LLVM.

[Kadir Çetinkaya via cfe-commits]

> I joined the group; what do I do to get tests run for this?

you need to upload a diff to trigger the bots


> > Hope someone can verify the build on Windows.
> Do you think I should go on IRC and ask?

Not much help before committing, but for post-commit there is
http://45.33.8.238/.
Doesn't contain all different configurations but they are fast, so you can
revert swiftly at leat

On Tue, Feb 11, 2020 at 8:25 AM Justin Lebar via Phabricator <
revi...@reviews.llvm.org> wrote:

> jlebar added a comment.
>
> > Such changes can be risky.
>
> Heh, well said.  I feel good about it because I found two or three real
> bugs in clang/llvm as a result of this cleanup.  But still, we've got to
> land it safely...
>
> I joined the group; what do I do to get tests run for this?
>
> > Hope someone can verify the build on Windows.
>
> Do you think I should go on IRC and ask?
>
>
> Repository:
>   rG LLVM Github Monorepo
>
> CHANGES SINCE LAST ACTION
>   https://reviews.llvm.org/D74384/new/
>
> https://reviews.llvm.org/D74384
>
>
>
>
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D74384: Use std::foo_t rather than std::foo in LLVM.

[Justin Lebar via Phabricator via cfe-commits]

jlebar added a comment.

> Such changes can be risky.

Heh, well said.  I feel good about it because I found two or three real bugs in 
clang/llvm as a result of this cleanup.  But still, we've got to land it 
safely...

I joined the group; what do I do to get tests run for this?

> Hope someone can verify the build on Windows.

Do you think I should go on IRC and ask?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74384/new/

https://reviews.llvm.org/D74384



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D74384: Use std::foo_t rather than std::foo in LLVM.

[Fangrui Song via Phabricator via cfe-commits]

MaskRay added a comment.

You may join https://reviews.llvm.org/project/view/78/ and let the bot test 
Linux for you..


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74384/new/

https://reviews.llvm.org/D74384



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D74384: Use std::foo_t rather than std::foo in LLVM.

[Fangrui Song via Phabricator via cfe-commits]

MaskRay accepted this revision.
MaskRay added a comment.
This revision is now accepted and ready to land.

Such changes can be risky. Hope someone can verify the build on Windows.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74384/new/

https://reviews.llvm.org/D74384



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits