[PATCH] D74464: Fix integration of pass plugins with llvm dylib
This revision was automatically updated to reflect the committed changes. Closed by commit rGd21664cce1db: Fix integration of pass plugins with llvm dylib (authored by serge-sans-paille). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74464/new/ https://reviews.llvm.org/D74464 Files: clang/CMakeLists.txt llvm/CMakeLists.txt Index: llvm/CMakeLists.txt === --- llvm/CMakeLists.txt +++ llvm/CMakeLists.txt @@ -1075,6 +1075,7 @@ # after all targets are created. include(LLVMDistributionSupport) llvm_distribution_add_targets() +process_llvm_pass_plugins() # This allows us to deploy the Universal CRT DLLs by passing -DCMAKE_INSTALL_UCRT_LIBRARIES=ON to CMake if (MSVC AND CMAKE_HOST_SYSTEM_NAME STREQUAL "Windows" AND CMAKE_INSTALL_UCRT_LIBRARIES) @@ -1099,5 +1100,3 @@ if (LLVM_INCLUDE_UTILS AND LLVM_INCLUDE_TOOLS) add_subdirectory(utils/llvm-locstats) endif() - -process_llvm_pass_plugins() Index: clang/CMakeLists.txt === --- clang/CMakeLists.txt +++ clang/CMakeLists.txt @@ -864,6 +864,7 @@ if(CLANG_BUILT_STANDALONE) llvm_distribution_add_targets() + process_llvm_pass_plugins() endif() configure_file( Index: llvm/CMakeLists.txt === --- llvm/CMakeLists.txt +++ llvm/CMakeLists.txt @@ -1075,6 +1075,7 @@ # after all targets are created. include(LLVMDistributionSupport) llvm_distribution_add_targets() +process_llvm_pass_plugins() # This allows us to deploy the Universal CRT DLLs by passing -DCMAKE_INSTALL_UCRT_LIBRARIES=ON to CMake if (MSVC AND CMAKE_HOST_SYSTEM_NAME STREQUAL "Windows" AND CMAKE_INSTALL_UCRT_LIBRARIES) @@ -1099,5 +1100,3 @@ if (LLVM_INCLUDE_UTILS AND LLVM_INCLUDE_TOOLS) add_subdirectory(utils/llvm-locstats) endif() - -process_llvm_pass_plugins() Index: clang/CMakeLists.txt === --- clang/CMakeLists.txt +++ clang/CMakeLists.txt @@ -864,6 +864,7 @@ if(CLANG_BUILT_STANDALONE) llvm_distribution_add_targets() + process_llvm_pass_plugins() endif() configure_file( ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D74464: Fix integration of pass plugins with llvm dylib
hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. Looks reasonable to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74464/new/ https://reviews.llvm.org/D74464 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D74464: Fix integration of pass plugins with llvm dylib
serge-sans-paille updated this revision to Diff 244150. serge-sans-paille edited the summary of this revision. serge-sans-paille added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Totally different, and much cleaner approach of the issue. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74464/new/ https://reviews.llvm.org/D74464 Files: clang/CMakeLists.txt llvm/CMakeLists.txt Index: llvm/CMakeLists.txt === --- llvm/CMakeLists.txt +++ llvm/CMakeLists.txt @@ -1075,6 +1075,7 @@ # after all targets are created. include(LLVMDistributionSupport) llvm_distribution_add_targets() +process_llvm_pass_plugins() # This allows us to deploy the Universal CRT DLLs by passing -DCMAKE_INSTALL_UCRT_LIBRARIES=ON to CMake if (MSVC AND CMAKE_HOST_SYSTEM_NAME STREQUAL "Windows" AND CMAKE_INSTALL_UCRT_LIBRARIES) @@ -1099,5 +1100,3 @@ if (LLVM_INCLUDE_UTILS AND LLVM_INCLUDE_TOOLS) add_subdirectory(utils/llvm-locstats) endif() - -process_llvm_pass_plugins() Index: clang/CMakeLists.txt === --- clang/CMakeLists.txt +++ clang/CMakeLists.txt @@ -864,6 +864,7 @@ if(CLANG_BUILT_STANDALONE) llvm_distribution_add_targets() + process_llvm_pass_plugins() endif() configure_file( Index: llvm/CMakeLists.txt === --- llvm/CMakeLists.txt +++ llvm/CMakeLists.txt @@ -1075,6 +1075,7 @@ # after all targets are created. include(LLVMDistributionSupport) llvm_distribution_add_targets() +process_llvm_pass_plugins() # This allows us to deploy the Universal CRT DLLs by passing -DCMAKE_INSTALL_UCRT_LIBRARIES=ON to CMake if (MSVC AND CMAKE_HOST_SYSTEM_NAME STREQUAL "Windows" AND CMAKE_INSTALL_UCRT_LIBRARIES) @@ -1099,5 +1100,3 @@ if (LLVM_INCLUDE_UTILS AND LLVM_INCLUDE_TOOLS) add_subdirectory(utils/llvm-locstats) endif() - -process_llvm_pass_plugins() Index: clang/CMakeLists.txt === --- clang/CMakeLists.txt +++ clang/CMakeLists.txt @@ -864,6 +864,7 @@ if(CLANG_BUILT_STANDALONE) llvm_distribution_add_targets() + process_llvm_pass_plugins() endif() configure_file( ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
