[PATCH] D75573: [Sema][SVE] Reject aligned/_Alignas for sizeless types
This revision was automatically updated to reflect the committed changes.
Closed by commit rG627b5c12068c: [Sema][SVE] Reject aligned/_Alignas for
sizeless types (authored by rsandifo-arm).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D75573/new/
https://reviews.llvm.org/D75573
Files:
clang/include/clang/Basic/DiagnosticSemaKinds.td
clang/lib/Sema/SemaDeclAttr.cpp
clang/test/Sema/sizeless-1.c
clang/test/SemaCXX/sizeless-1.cpp
Index: clang/test/SemaCXX/sizeless-1.cpp
===
--- clang/test/SemaCXX/sizeless-1.cpp
+++ clang/test/SemaCXX/sizeless-1.cpp
@@ -61,6 +61,10 @@
svint8_t local_int8;
svint16_t local_int16;
+ svint8_t __attribute__((aligned)) aligned_int8_1;// expected-error
{{'aligned' attribute cannot be applied to sizeless type 'svint8_t'}}
+ svint8_t __attribute__((aligned(4))) aligned_int8_2; // expected-error
{{'aligned' attribute cannot be applied to sizeless type 'svint8_t'}}
+ svint8_t _Alignas(int) aligned_int8_3; // expected-error
{{'_Alignas' attribute cannot be applied to sizeless type 'svint8_t'}}
+
int _Alignas(svint8_t) aligned_int; // expected-error {{invalid application
of 'alignof' to sizeless type 'svint8_t'}}
// Using pointers to sizeless data isn't wrong here, but because the
Index: clang/test/Sema/sizeless-1.c
===
--- clang/test/Sema/sizeless-1.c
+++ clang/test/Sema/sizeless-1.c
@@ -51,6 +51,10 @@
svint8_t local_int8;
svint16_t local_int16;
+ svint8_t __attribute__((aligned)) aligned_int8_1;// expected-error
{{'aligned' attribute cannot be applied to sizeless type 'svint8_t'}}
+ svint8_t __attribute__((aligned(4))) aligned_int8_2; // expected-error
{{'aligned' attribute cannot be applied to sizeless type 'svint8_t'}}
+ svint8_t _Alignas(int) aligned_int8_3; // expected-error
{{'_Alignas' attribute cannot be applied to sizeless type 'svint8_t'}}
+
int _Alignas(svint8_t) aligned_int; // expected-error {{invalid application
of 'alignof' to sizeless type 'svint8_t'}}
// Using pointers to sizeless data isn't wrong here, but because the
Index: clang/lib/Sema/SemaDeclAttr.cpp
===
--- clang/lib/Sema/SemaDeclAttr.cpp
+++ clang/lib/Sema/SemaDeclAttr.cpp
@@ -3868,6 +3868,7 @@
// not specify an alignment that is less strict than the alignment that
// would otherwise be required for the entity being declared.
AlignedAttr *AlignasAttr = nullptr;
+ AlignedAttr *LastAlignedAttr = nullptr;
unsigned Align = 0;
for (auto *I : D->specific_attrs()) {
if (I->isAlignmentDependent())
@@ -3875,9 +3876,13 @@
if (I->isAlignas())
AlignasAttr = I;
Align = std::max(Align, I->getAlignment(Context));
+LastAlignedAttr = I;
}
- if (AlignasAttr && Align) {
+ if (Align && DiagTy->isSizelessType()) {
+Diag(LastAlignedAttr->getLocation(), diag::err_attribute_sizeless_type)
+<< LastAlignedAttr << DiagTy;
+ } else if (AlignasAttr && Align) {
CharUnits RequestedAlign = Context.toCharUnitsFromBits(Align);
CharUnits NaturalAlign = Context.getTypeAlignInChars(UnderlyingTy);
if (NaturalAlign > RequestedAlign)
Index: clang/include/clang/Basic/DiagnosticSemaKinds.td
===
--- clang/include/clang/Basic/DiagnosticSemaKinds.td
+++ clang/include/clang/Basic/DiagnosticSemaKinds.td
@@ -2807,6 +2807,8 @@
"redeclaration has different alignment requirement (%1 vs %0)">;
def err_alignas_underaligned : Error<
"requested alignment is less than minimum alignment of %1 for type %0">;
+def err_attribute_sizeless_type : Error<
+ "%0 attribute cannot be applied to sizeless type %1">;
def err_attribute_argument_n_type : Error<
"%0 attribute requires parameter %1 to be %select{int or bool|an integer "
"constant|a string|an identifier}2">;
Index: clang/test/SemaCXX/sizeless-1.cpp
===
--- clang/test/SemaCXX/sizeless-1.cpp
+++ clang/test/SemaCXX/sizeless-1.cpp
@@ -61,6 +61,10 @@
svint8_t local_int8;
svint16_t local_int16;
+ svint8_t __attribute__((aligned)) aligned_int8_1;// expected-error {{'aligned' attribute cannot be applied to sizeless type 'svint8_t'}}
+ svint8_t __attribute__((aligned(4))) aligned_int8_2; // expected-error {{'aligned' attribute cannot be applied to sizeless type 'svint8_t'}}
+ svint8_t _Alignas(int) aligned_int8_3; // expected-error {{'_Alignas' attribute cannot be applied to sizeless type 'svint8_t'}}
+
int _Alignas(svint8_t) aligned_int; // expected-error {{invalid application of 'alignof' to sizeless type 'svint8_t'}}
// Using pointers to sizeless data isn't wrong here, but because the
Index: clang/test/Sema/sizeless-1.c
[PATCH] D75573: [Sema][SVE] Reject aligned/_Alignas for sizeless types
efriedma added a comment. LGTM Technically, you could still do math on the address, and the difference would be visible. Granted, it's unlikely to matter in practice. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75573/new/ https://reviews.llvm.org/D75573 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D75573: [Sema][SVE] Reject aligned/_Alignas for sizeless types
rsandifo-arm updated this revision to Diff 248672.
rsandifo-arm added a comment.
Apply changes from git-clang-format.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D75573/new/
https://reviews.llvm.org/D75573
Files:
clang/include/clang/Basic/DiagnosticSemaKinds.td
clang/lib/Sema/SemaDeclAttr.cpp
clang/test/Sema/sizeless-1.c
clang/test/SemaCXX/sizeless-1.cpp
Index: clang/test/SemaCXX/sizeless-1.cpp
===
--- clang/test/SemaCXX/sizeless-1.cpp
+++ clang/test/SemaCXX/sizeless-1.cpp
@@ -61,6 +61,10 @@
svint8_t local_int8;
svint16_t local_int16;
+ svint8_t __attribute__((aligned)) aligned_int8_1;// expected-error
{{'aligned' attribute cannot be applied to sizeless type 'svint8_t'}}
+ svint8_t __attribute__((aligned(4))) aligned_int8_2; // expected-error
{{'aligned' attribute cannot be applied to sizeless type 'svint8_t'}}
+ svint8_t _Alignas(int) aligned_int8_3; // expected-error
{{'_Alignas' attribute cannot be applied to sizeless type 'svint8_t'}}
+
int _Alignas(svint8_t) aligned_int; // expected-error {{invalid application
of 'alignof' to sizeless type 'svint8_t'}}
// Using pointers to sizeless data isn't wrong here, but because the
Index: clang/test/Sema/sizeless-1.c
===
--- clang/test/Sema/sizeless-1.c
+++ clang/test/Sema/sizeless-1.c
@@ -51,6 +51,10 @@
svint8_t local_int8;
svint16_t local_int16;
+ svint8_t __attribute__((aligned)) aligned_int8_1;// expected-error
{{'aligned' attribute cannot be applied to sizeless type 'svint8_t'}}
+ svint8_t __attribute__((aligned(4))) aligned_int8_2; // expected-error
{{'aligned' attribute cannot be applied to sizeless type 'svint8_t'}}
+ svint8_t _Alignas(int) aligned_int8_3; // expected-error
{{'_Alignas' attribute cannot be applied to sizeless type 'svint8_t'}}
+
int _Alignas(svint8_t) aligned_int; // expected-error {{invalid application
of 'alignof' to sizeless type 'svint8_t'}}
// Using pointers to sizeless data isn't wrong here, but because the
Index: clang/lib/Sema/SemaDeclAttr.cpp
===
--- clang/lib/Sema/SemaDeclAttr.cpp
+++ clang/lib/Sema/SemaDeclAttr.cpp
@@ -3868,6 +3868,7 @@
// not specify an alignment that is less strict than the alignment that
// would otherwise be required for the entity being declared.
AlignedAttr *AlignasAttr = nullptr;
+ AlignedAttr *LastAlignedAttr = nullptr;
unsigned Align = 0;
for (auto *I : D->specific_attrs()) {
if (I->isAlignmentDependent())
@@ -3875,9 +3876,13 @@
if (I->isAlignas())
AlignasAttr = I;
Align = std::max(Align, I->getAlignment(Context));
+LastAlignedAttr = I;
}
- if (AlignasAttr && Align) {
+ if (Align && DiagTy->isSizelessType()) {
+Diag(LastAlignedAttr->getLocation(), diag::err_attribute_sizeless_type)
+<< LastAlignedAttr << DiagTy;
+ } else if (AlignasAttr && Align) {
CharUnits RequestedAlign = Context.toCharUnitsFromBits(Align);
CharUnits NaturalAlign = Context.getTypeAlignInChars(UnderlyingTy);
if (NaturalAlign > RequestedAlign)
Index: clang/include/clang/Basic/DiagnosticSemaKinds.td
===
--- clang/include/clang/Basic/DiagnosticSemaKinds.td
+++ clang/include/clang/Basic/DiagnosticSemaKinds.td
@@ -2801,6 +2801,8 @@
"redeclaration has different alignment requirement (%1 vs %0)">;
def err_alignas_underaligned : Error<
"requested alignment is less than minimum alignment of %1 for type %0">;
+def err_attribute_sizeless_type : Error<
+ "%0 attribute cannot be applied to sizeless type %1">;
def err_attribute_argument_n_type : Error<
"%0 attribute requires parameter %1 to be %select{int or bool|an integer "
"constant|a string|an identifier}2">;
Index: clang/test/SemaCXX/sizeless-1.cpp
===
--- clang/test/SemaCXX/sizeless-1.cpp
+++ clang/test/SemaCXX/sizeless-1.cpp
@@ -61,6 +61,10 @@
svint8_t local_int8;
svint16_t local_int16;
+ svint8_t __attribute__((aligned)) aligned_int8_1;// expected-error {{'aligned' attribute cannot be applied to sizeless type 'svint8_t'}}
+ svint8_t __attribute__((aligned(4))) aligned_int8_2; // expected-error {{'aligned' attribute cannot be applied to sizeless type 'svint8_t'}}
+ svint8_t _Alignas(int) aligned_int8_3; // expected-error {{'_Alignas' attribute cannot be applied to sizeless type 'svint8_t'}}
+
int _Alignas(svint8_t) aligned_int; // expected-error {{invalid application of 'alignof' to sizeless type 'svint8_t'}}
// Using pointers to sizeless data isn't wrong here, but because the
Index: clang/test/Sema/sizeless-1.c
===
---
[PATCH] D75573: [Sema][SVE] Reject aligned/_Alignas for sizeless types
rsandifo-arm created this revision.
rsandifo-arm added reviewers: sdesmalen, efriedma, rovka, rjmccall.
Herald added subscribers: cfe-commits, psnobl, rkruppe, tschuett.
Herald added a project: clang.
A previous patch rejected alignof for sizeless types. This patch
extends that to cover the "aligned" attribute and _Alignas. Since
sizeless types are not meant to be used for long-term data, cannot
be used in aggregates, and cannot have static storage duration,
there shouldn't be any need to fiddle with their alignment.
Like with alignof, this is a conservative position that can be
relaxed in future if it turns out to be too restrictive.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D75573
Files:
clang/include/clang/Basic/DiagnosticSemaKinds.td
clang/lib/Sema/SemaDeclAttr.cpp
clang/test/Sema/sizeless-1.c
clang/test/SemaCXX/sizeless-1.cpp
Index: clang/test/SemaCXX/sizeless-1.cpp
===
--- clang/test/SemaCXX/sizeless-1.cpp
+++ clang/test/SemaCXX/sizeless-1.cpp
@@ -63,6 +63,9 @@
svint8_t local_int8;
svint16_t local_int16;
+ svint8_t __attribute__((aligned)) aligned_int8_1; // expected-error
{{'aligned' attribute cannot be applied to sizeless type 'svint8_t'}}
+ svint8_t __attribute__((aligned(4))) aligned_int8_2; // expected-error
{{'aligned' attribute cannot be applied to sizeless type 'svint8_t'}}
+ svint8_t _Alignas(int) aligned_int8_3; // expected-error {{'_Alignas'
attribute cannot be applied to sizeless type 'svint8_t'}}
int _Alignas(svint8_t) aligned_int; // expected-error {{invalid application
of 'alignof' to sizeless type 'svint8_t'}}
// Using pointers to sizeless data isn't wrong here, but because the
Index: clang/test/Sema/sizeless-1.c
===
--- clang/test/Sema/sizeless-1.c
+++ clang/test/Sema/sizeless-1.c
@@ -54,6 +54,9 @@
svint8_t local_int8;
svint16_t local_int16;
+ svint8_t __attribute__((aligned)) aligned_int8_1; // expected-error
{{'aligned' attribute cannot be applied to sizeless type 'svint8_t'}}
+ svint8_t __attribute__((aligned(4))) aligned_int8_2; // expected-error
{{'aligned' attribute cannot be applied to sizeless type 'svint8_t'}}
+ svint8_t _Alignas(int) aligned_int8_3; // expected-error {{'_Alignas'
attribute cannot be applied to sizeless type 'svint8_t'}}
int _Alignas(svint8_t) aligned_int; // expected-error {{invalid application
of 'alignof' to sizeless type 'svint8_t'}}
// Using pointers to sizeless data isn't wrong here, but because the
Index: clang/lib/Sema/SemaDeclAttr.cpp
===
--- clang/lib/Sema/SemaDeclAttr.cpp
+++ clang/lib/Sema/SemaDeclAttr.cpp
@@ -3868,6 +3868,7 @@
// not specify an alignment that is less strict than the alignment that
// would otherwise be required for the entity being declared.
AlignedAttr *AlignasAttr = nullptr;
+ AlignedAttr *LastAlignedAttr = nullptr;
unsigned Align = 0;
for (auto *I : D->specific_attrs()) {
if (I->isAlignmentDependent())
@@ -3875,9 +3876,13 @@
if (I->isAlignas())
AlignasAttr = I;
Align = std::max(Align, I->getAlignment(Context));
+LastAlignedAttr = I;
}
- if (AlignasAttr && Align) {
+ if (Align && DiagTy->isSizelessType()) {
+Diag(LastAlignedAttr->getLocation(), diag::err_attribute_sizeless_type)
+ << LastAlignedAttr << DiagTy;
+ } else if (AlignasAttr && Align) {
CharUnits RequestedAlign = Context.toCharUnitsFromBits(Align);
CharUnits NaturalAlign = Context.getTypeAlignInChars(UnderlyingTy);
if (NaturalAlign > RequestedAlign)
Index: clang/include/clang/Basic/DiagnosticSemaKinds.td
===
--- clang/include/clang/Basic/DiagnosticSemaKinds.td
+++ clang/include/clang/Basic/DiagnosticSemaKinds.td
@@ -2801,6 +2801,8 @@
"redeclaration has different alignment requirement (%1 vs %0)">;
def err_alignas_underaligned : Error<
"requested alignment is less than minimum alignment of %1 for type %0">;
+def err_attribute_sizeless_type : Error<
+ "%0 attribute cannot be applied to sizeless type %1">;
def err_attribute_argument_n_type : Error<
"%0 attribute requires parameter %1 to be %select{int or bool|an integer "
"constant|a string|an identifier}2">;
Index: clang/test/SemaCXX/sizeless-1.cpp
===
--- clang/test/SemaCXX/sizeless-1.cpp
+++ clang/test/SemaCXX/sizeless-1.cpp
@@ -63,6 +63,9 @@
svint8_t local_int8;
svint16_t local_int16;
+ svint8_t __attribute__((aligned)) aligned_int8_1; // expected-error {{'aligned' attribute cannot be applied to sizeless type 'svint8_t'}}
+ svint8_t __attribute__((aligned(4))) aligned_int8_2; // expected-error {{'aligned' attribute cannot be applied to sizeless type 'svint8_t'}}
+ svint8_t _Alignas(int) aligned_int8_3; //
