[PATCH] D80210: [analyzer] Turn off reports in system headers
bruntib added a comment. Hi, Thanks everyone for the investigation in this problem. I find these suggestions reasonable, and I think this commented example is a strong beating card in our hands to convince our users that paths going through system headers are meaningful and important. I'll start implementing this idea and we'll see how much it affects the results in real-world projects. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80210/new/ https://reviews.llvm.org/D80210 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D80210: [analyzer] Turn off reports in system headers
NoQ added a comment. (if we agree to do this, the next obvious experiment would be to cut out the beginning of the path from the report we *do* emit - i.e., everything until our first interesting stack frame) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80210/new/ https://reviews.llvm.org/D80210 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D80210: [analyzer] Turn off reports in system headers
Szelethus added a comment. Sounds nice. @bruntib, would this be sufficient for the user's request? Are we sure that the actual request makes sense in light of the analyzer's viewpoint? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80210/new/ https://reviews.llvm.org/D80210 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D80210: [analyzer] Turn off reports in system headers
NoQ added a comment.
Eg., suppress this report:
// system_header.h
int bar() {
int *x = NULL;
return *x;
}
// user_file.c
void foo() {
bar();
}
but don't suppress this report:
// system_header.h
int bar(int *x) {
return *x;
}
// user_file.c
void foo() {
int *y = NULL;
bar(y);
}
In the first example there are two interesting events: (1) `x = NULL`, (2)
`return *x` but both of them are in the system header. In the second example
the interesting event (1) `y = NULL` is not in the system header, so the report
remains.
> That all other interesting stack frames are nested in it
I think this is the best take. A more aggressive suppression would be "all
interesting things are in a system header", which would allow the suppressed
bug report to temporarily leave the system header between interesting events.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D80210/new/
https://reviews.llvm.org/D80210
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
