[PATCH] D81522: Fix variables used only in asserts.

[David Blaikie via Phabricator via cfe-commits]

dblaikie added a comment.

Thanks for the fix! Totally within the realm of post-commit review so far as I 
can see. The paired assertions could maybe be rewritten as: 
"assert(MRMgr.getVarRegion(P, SFC) ->getKind()== (SFC->inTopFrame() ? 
NonParamVarRegionKind : ParamVarRegionKind));" though it's not necessarily 
better (bit verbose, but avoids the textual duplication of the getVarRegion 
calls). Oh, and that first assert could potentially be an 
"assert(llvm::all_of... " to avoid D2  being an 
unused variable in non-asserts builds).

There's no need to send things for review that don't need pre-commit review. 
Post-commit review can be done in replies to the commit email on llvm-commits. 
(sending things like this can muddy the waters about post/pre-commit review - 
especially around code sent for pre-commit review but is then committed without 
that review concluding)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81522/new/

https://reviews.llvm.org/D81522



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D81522: Fix variables used only in asserts.

[Sterling Augustine via Phabricator via cfe-commits]

saugustine created this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
saugustine edited the summary of this revision.
saugustine added a reviewer: baloghadamsoftware.
Herald added a subscriber: rnkovacs.

Fix variables used only in asserts.

For post-commit review.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D81522

Files:
  clang/unittests/StaticAnalyzer/ParamRegionTest.cpp


Index: clang/unittests/StaticAnalyzer/ParamRegionTest.cpp
===
--- clang/unittests/StaticAnalyzer/ParamRegionTest.cpp
+++ clang/unittests/StaticAnalyzer/ParamRegionTest.cpp
@@ -20,8 +20,8 @@
 const StackFrameContext *SFC,
 const ParmVarDecl *PVD) {
 for (const auto *D2: PVD->redecls()) {
-  const auto *PVD2 = cast(D2);
-  assert(MRMgr.getVarRegion(PVD, SFC) == MRMgr.getVarRegion(PVD2, SFC));
+  assert(MRMgr.getVarRegion(PVD, SFC) ==
+ MRMgr.getVarRegion(cast(D2), SFC));
 }
   }
 
@@ -33,29 +33,26 @@
 
 if (const auto *FD = dyn_cast(D)) {
   for (const auto *P : FD->parameters()) {
-const TypedValueRegion *Reg = MRMgr.getVarRegion(P, SFC);
 if (SFC->inTopFrame())
-  assert(isa(Reg));
+  assert(isa(MRMgr.getVarRegion(P, SFC)));
 else
-  assert(isa(Reg));
+  assert(isa(MRMgr.getVarRegion(P, SFC)));
 checkForSameParamRegions(MRMgr, SFC, P);
   }
 } else if (const auto *CD = dyn_cast(D)) {
   for (const auto *P : CD->parameters()) {
-const TypedValueRegion *Reg = MRMgr.getVarRegion(P, SFC);
 if (SFC->inTopFrame())
-  assert(isa(Reg));
+  assert(isa(MRMgr.getVarRegion(P, SFC)));
 else
-  assert(isa(Reg));
+  assert(isa(MRMgr.getVarRegion(P, SFC)));
 checkForSameParamRegions(MRMgr, SFC, P);
   }
 } else if (const auto *MD = dyn_cast(D)) {
   for (const auto *P : MD->parameters()) {
-const TypedValueRegion *Reg = MRMgr.getVarRegion(P, SFC);
 if (SFC->inTopFrame())
-  assert(isa(Reg));
+  assert(isa(MRMgr.getVarRegion(P, SFC)));
 else
-  assert(isa(Reg));
+  assert(isa(MRMgr.getVarRegion(P, SFC)));
 checkForSameParamRegions(MRMgr, SFC, P);
   }
 }


Index: clang/unittests/StaticAnalyzer/ParamRegionTest.cpp
===
--- clang/unittests/StaticAnalyzer/ParamRegionTest.cpp
+++ clang/unittests/StaticAnalyzer/ParamRegionTest.cpp
@@ -20,8 +20,8 @@
 const StackFrameContext *SFC,
 const ParmVarDecl *PVD) {
 for (const auto *D2: PVD->redecls()) {
-  const auto *PVD2 = cast(D2);
-  assert(MRMgr.getVarRegion(PVD, SFC) == MRMgr.getVarRegion(PVD2, SFC));
+  assert(MRMgr.getVarRegion(PVD, SFC) ==
+ MRMgr.getVarRegion(cast(D2), SFC));
 }
   }
 
@@ -33,29 +33,26 @@
 
 if (const auto *FD = dyn_cast(D)) {
   for (const auto *P : FD->parameters()) {
-const TypedValueRegion *Reg = MRMgr.getVarRegion(P, SFC);
 if (SFC->inTopFrame())
-  assert(isa(Reg));
+  assert(isa(MRMgr.getVarRegion(P, SFC)));
 else
-  assert(isa(Reg));
+  assert(isa(MRMgr.getVarRegion(P, SFC)));
 checkForSameParamRegions(MRMgr, SFC, P);
   }
 } else if (const auto *CD = dyn_cast(D)) {
   for (const auto *P : CD->parameters()) {
-const TypedValueRegion *Reg = MRMgr.getVarRegion(P, SFC);
 if (SFC->inTopFrame())
-  assert(isa(Reg));
+  assert(isa(MRMgr.getVarRegion(P, SFC)));
 else
-  assert(isa(Reg));
+  assert(isa(MRMgr.getVarRegion(P, SFC)));
 checkForSameParamRegions(MRMgr, SFC, P);
   }
 } else if (const auto *MD = dyn_cast(D)) {
   for (const auto *P : MD->parameters()) {
-const TypedValueRegion *Reg = MRMgr.getVarRegion(P, SFC);
 if (SFC->inTopFrame())
-  assert(isa(Reg));
+  assert(isa(MRMgr.getVarRegion(P, SFC)));
 else
-  assert(isa(Reg));
+  assert(isa(MRMgr.getVarRegion(P, SFC)));
 checkForSameParamRegions(MRMgr, SFC, P);
   }
 }
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D81522: Fix variables used only in asserts.

[Sterling Augustine via Phabricator via cfe-commits]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rGccd192204da4: Fix variables used only in asserts. (authored 
by saugustine).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81522/new/

https://reviews.llvm.org/D81522

Files:
  clang/unittests/StaticAnalyzer/ParamRegionTest.cpp


Index: clang/unittests/StaticAnalyzer/ParamRegionTest.cpp
===
--- clang/unittests/StaticAnalyzer/ParamRegionTest.cpp
+++ clang/unittests/StaticAnalyzer/ParamRegionTest.cpp
@@ -20,8 +20,8 @@
 const StackFrameContext *SFC,
 const ParmVarDecl *PVD) {
 for (const auto *D2: PVD->redecls()) {
-  const auto *PVD2 = cast(D2);
-  assert(MRMgr.getVarRegion(PVD, SFC) == MRMgr.getVarRegion(PVD2, SFC));
+  assert(MRMgr.getVarRegion(PVD, SFC) ==
+ MRMgr.getVarRegion(cast(D2), SFC));
 }
   }
 
@@ -33,29 +33,26 @@
 
 if (const auto *FD = dyn_cast(D)) {
   for (const auto *P : FD->parameters()) {
-const TypedValueRegion *Reg = MRMgr.getVarRegion(P, SFC);
 if (SFC->inTopFrame())
-  assert(isa(Reg));
+  assert(isa(MRMgr.getVarRegion(P, SFC)));
 else
-  assert(isa(Reg));
+  assert(isa(MRMgr.getVarRegion(P, SFC)));
 checkForSameParamRegions(MRMgr, SFC, P);
   }
 } else if (const auto *CD = dyn_cast(D)) {
   for (const auto *P : CD->parameters()) {
-const TypedValueRegion *Reg = MRMgr.getVarRegion(P, SFC);
 if (SFC->inTopFrame())
-  assert(isa(Reg));
+  assert(isa(MRMgr.getVarRegion(P, SFC)));
 else
-  assert(isa(Reg));
+  assert(isa(MRMgr.getVarRegion(P, SFC)));
 checkForSameParamRegions(MRMgr, SFC, P);
   }
 } else if (const auto *MD = dyn_cast(D)) {
   for (const auto *P : MD->parameters()) {
-const TypedValueRegion *Reg = MRMgr.getVarRegion(P, SFC);
 if (SFC->inTopFrame())
-  assert(isa(Reg));
+  assert(isa(MRMgr.getVarRegion(P, SFC)));
 else
-  assert(isa(Reg));
+  assert(isa(MRMgr.getVarRegion(P, SFC)));
 checkForSameParamRegions(MRMgr, SFC, P);
   }
 }


Index: clang/unittests/StaticAnalyzer/ParamRegionTest.cpp
===
--- clang/unittests/StaticAnalyzer/ParamRegionTest.cpp
+++ clang/unittests/StaticAnalyzer/ParamRegionTest.cpp
@@ -20,8 +20,8 @@
 const StackFrameContext *SFC,
 const ParmVarDecl *PVD) {
 for (const auto *D2: PVD->redecls()) {
-  const auto *PVD2 = cast(D2);
-  assert(MRMgr.getVarRegion(PVD, SFC) == MRMgr.getVarRegion(PVD2, SFC));
+  assert(MRMgr.getVarRegion(PVD, SFC) ==
+ MRMgr.getVarRegion(cast(D2), SFC));
 }
   }
 
@@ -33,29 +33,26 @@
 
 if (const auto *FD = dyn_cast(D)) {
   for (const auto *P : FD->parameters()) {
-const TypedValueRegion *Reg = MRMgr.getVarRegion(P, SFC);
 if (SFC->inTopFrame())
-  assert(isa(Reg));
+  assert(isa(MRMgr.getVarRegion(P, SFC)));
 else
-  assert(isa(Reg));
+  assert(isa(MRMgr.getVarRegion(P, SFC)));
 checkForSameParamRegions(MRMgr, SFC, P);
   }
 } else if (const auto *CD = dyn_cast(D)) {
   for (const auto *P : CD->parameters()) {
-const TypedValueRegion *Reg = MRMgr.getVarRegion(P, SFC);
 if (SFC->inTopFrame())
-  assert(isa(Reg));
+  assert(isa(MRMgr.getVarRegion(P, SFC)));
 else
-  assert(isa(Reg));
+  assert(isa(MRMgr.getVarRegion(P, SFC)));
 checkForSameParamRegions(MRMgr, SFC, P);
   }
 } else if (const auto *MD = dyn_cast(D)) {
   for (const auto *P : MD->parameters()) {
-const TypedValueRegion *Reg = MRMgr.getVarRegion(P, SFC);
 if (SFC->inTopFrame())
-  assert(isa(Reg));
+  assert(isa(MRMgr.getVarRegion(P, SFC)));
 else
-  assert(isa(Reg));
+  assert(isa(MRMgr.getVarRegion(P, SFC)));
 checkForSameParamRegions(MRMgr, SFC, P);
   }
 }
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits