[PATCH] D85218: In clang-tidy base checks prevent anonymous functions from triggering assertions
This revision was automatically updated to reflect the committed changes. Closed by commit rG35bee3503f4c: [clang-tidy] prevent generated checks from triggering assertions on anonymous… (authored by bogser01, committed by DavidTruby). Changed prior to commit: https://reviews.llvm.org/D85218?vs=282940&id=285040#toc Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85218/new/ https://reviews.llvm.org/D85218 Files: clang-tools-extra/clang-tidy/add_new_check.py clang-tools-extra/docs/clang-tidy/Contributing.rst Index: clang-tools-extra/docs/clang-tidy/Contributing.rst === --- clang-tools-extra/docs/clang-tidy/Contributing.rst +++ clang-tools-extra/docs/clang-tidy/Contributing.rst @@ -202,7 +202,7 @@ void AwesomeFunctionNamesCheck::check(const MatchFinder::MatchResult &Result) { const auto *MatchedDecl = Result.Nodes.getNodeAs("x"); -if (MatchedDecl->getName().startswith("awesome_")) +if (!MatchedDecl->getIdentifier() || MatchedDecl->getName().startswith("awesome_")) return; diag(MatchedDecl->getLocation(), "function %0 is insufficiently awesome") << MatchedDecl Index: clang-tools-extra/clang-tidy/add_new_check.py === --- clang-tools-extra/clang-tidy/add_new_check.py +++ clang-tools-extra/clang-tidy/add_new_check.py @@ -136,7 +136,7 @@ void %(check_name)s::check(const MatchFinder::MatchResult &Result) { // FIXME: Add callback implementation. const auto *MatchedDecl = Result.Nodes.getNodeAs("x"); - if (MatchedDecl->getName().startswith("awesome_")) + if (!MatchedDecl->getIdentifier() || MatchedDecl->getName().startswith("awesome_")) return; diag(MatchedDecl->getLocation(), "function %%0 is insufficiently awesome") << MatchedDecl; Index: clang-tools-extra/docs/clang-tidy/Contributing.rst === --- clang-tools-extra/docs/clang-tidy/Contributing.rst +++ clang-tools-extra/docs/clang-tidy/Contributing.rst @@ -202,7 +202,7 @@ void AwesomeFunctionNamesCheck::check(const MatchFinder::MatchResult &Result) { const auto *MatchedDecl = Result.Nodes.getNodeAs("x"); -if (MatchedDecl->getName().startswith("awesome_")) +if (!MatchedDecl->getIdentifier() || MatchedDecl->getName().startswith("awesome_")) return; diag(MatchedDecl->getLocation(), "function %0 is insufficiently awesome") << MatchedDecl Index: clang-tools-extra/clang-tidy/add_new_check.py === --- clang-tools-extra/clang-tidy/add_new_check.py +++ clang-tools-extra/clang-tidy/add_new_check.py @@ -136,7 +136,7 @@ void %(check_name)s::check(const MatchFinder::MatchResult &Result) { // FIXME: Add callback implementation. const auto *MatchedDecl = Result.Nodes.getNodeAs("x"); - if (MatchedDecl->getName().startswith("awesome_")) + if (!MatchedDecl->getIdentifier() || MatchedDecl->getName().startswith("awesome_")) return; diag(MatchedDecl->getLocation(), "function %%0 is insufficiently awesome") << MatchedDecl; ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D85218: In clang-tidy base checks prevent anonymous functions from triggering assertions
alexfh accepted this revision. alexfh added a comment. LG with a couple of comments. Do you need someone to land the patch for you? Comment at: clang-tools-extra/clang-tidy/add_new_check.py:139 const auto *MatchedDecl = Result.Nodes.getNodeAs("x"); - if (MatchedDecl->getName().startswith("awesome_")) + if ((!MatchedDecl->getIdentifier()) || MatchedDecl->getName().startswith("awesome_")) return; No need for parentheses around this. Comment at: clang-tools-extra/docs/clang-tidy/Contributing.rst:205 +const auto *MatchedDecl = Result.Nodes.getNodeAs("x"); +if ((!MatchedDecl->getIdentifier()) || MatchedDecl->getName().startswith("awesome_")) return; ditto. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85218/new/ https://reviews.llvm.org/D85218 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D85218: In clang-tidy base checks prevent anonymous functions from triggering assertions
DavidTruby accepted this revision. DavidTruby added a comment. This revision is now accepted and ready to land. LGTM - please wait for someone more familiar with clang-tidy to review as well Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85218/new/ https://reviews.llvm.org/D85218 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D85218: In clang-tidy base checks prevent anonymous functions from triggering assertions
bogser01 created this revision. bogser01 added reviewers: djasper, alexfh. bogser01 added a project: clang-tools-extra. Herald added a project: clang. Herald added a subscriber: cfe-commits. bogser01 requested review of this revision. Skeleton checks generated by clang-tidy add_check.py cause assertions to fail when run over anonymous functions(lambda functions). This patch introduces an additional check to verify that the target function is not anonymous before calling getName(). The code snippet from the [[ https://clang.llvm.org/extra/clang-tidy/Contributing.html | clang-tidy tutorial ]]is also updated. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D85218 Files: clang-tools-extra/clang-tidy/add_new_check.py clang-tools-extra/docs/clang-tidy/Contributing.rst Index: clang-tools-extra/docs/clang-tidy/Contributing.rst === --- clang-tools-extra/docs/clang-tidy/Contributing.rst +++ clang-tools-extra/docs/clang-tidy/Contributing.rst @@ -201,8 +201,8 @@ } void AwesomeFunctionNamesCheck::check(const MatchFinder::MatchResult &Result) { -const auto *MatchedDecl = Result.Nodes.getNodeAs("x"); -if (MatchedDecl->getName().startswith("awesome_")) +const auto *MatchedDecl = Result.Nodes.getNodeAs("x"); +if ((!MatchedDecl->getIdentifier()) || MatchedDecl->getName().startswith("awesome_")) return; diag(MatchedDecl->getLocation(), "function %0 is insufficiently awesome") << MatchedDecl Index: clang-tools-extra/clang-tidy/add_new_check.py === --- clang-tools-extra/clang-tidy/add_new_check.py +++ clang-tools-extra/clang-tidy/add_new_check.py @@ -136,7 +136,7 @@ void %(check_name)s::check(const MatchFinder::MatchResult &Result) { // FIXME: Add callback implementation. const auto *MatchedDecl = Result.Nodes.getNodeAs("x"); - if (MatchedDecl->getName().startswith("awesome_")) + if ((!MatchedDecl->getIdentifier()) || MatchedDecl->getName().startswith("awesome_")) return; diag(MatchedDecl->getLocation(), "function %%0 is insufficiently awesome") << MatchedDecl; Index: clang-tools-extra/docs/clang-tidy/Contributing.rst === --- clang-tools-extra/docs/clang-tidy/Contributing.rst +++ clang-tools-extra/docs/clang-tidy/Contributing.rst @@ -201,8 +201,8 @@ } void AwesomeFunctionNamesCheck::check(const MatchFinder::MatchResult &Result) { -const auto *MatchedDecl = Result.Nodes.getNodeAs("x"); -if (MatchedDecl->getName().startswith("awesome_")) +const auto *MatchedDecl = Result.Nodes.getNodeAs("x"); +if ((!MatchedDecl->getIdentifier()) || MatchedDecl->getName().startswith("awesome_")) return; diag(MatchedDecl->getLocation(), "function %0 is insufficiently awesome") << MatchedDecl Index: clang-tools-extra/clang-tidy/add_new_check.py === --- clang-tools-extra/clang-tidy/add_new_check.py +++ clang-tools-extra/clang-tidy/add_new_check.py @@ -136,7 +136,7 @@ void %(check_name)s::check(const MatchFinder::MatchResult &Result) { // FIXME: Add callback implementation. const auto *MatchedDecl = Result.Nodes.getNodeAs("x"); - if (MatchedDecl->getName().startswith("awesome_")) + if ((!MatchedDecl->getIdentifier()) || MatchedDecl->getName().startswith("awesome_")) return; diag(MatchedDecl->getLocation(), "function %%0 is insufficiently awesome") << MatchedDecl; ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits