[PATCH] D85252: [Driver] Accept -fno-lto in clang-cl
This revision was automatically updated to reflect the committed changes. Closed by commit rG8dc43852e4a8: [Driver] Accept -fno-lto in clang-cl (authored by aeubanks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85252/new/ https://reviews.llvm.org/D85252 Files: clang/include/clang/Driver/Options.td clang/test/Driver/cl-options.c Index: clang/test/Driver/cl-options.c === --- clang/test/Driver/cl-options.c +++ clang/test/Driver/cl-options.c @@ -586,6 +586,9 @@ // RUN: %clang_cl -### /c -flto -- %s 2>&1 | FileCheck -check-prefix=LTO %s // LTO: -flto +// RUN: %clang_cl -### /c -flto -fno-lto -- %s 2>&1 | FileCheck -check-prefix=LTO-NO %s +// LTO-NO-NOT: "-flto" + // RUN: %clang_cl -### /c -flto=thin -- %s 2>&1 | FileCheck -check-prefix=LTO-THIN %s // LTO-THIN: -flto=thin Index: clang/include/clang/Driver/Options.td === --- clang/include/clang/Driver/Options.td +++ clang/include/clang/Driver/Options.td @@ -1351,7 +1351,7 @@ HelpText<"Set LTO mode to either 'full' or 'thin'">, Values<"thin,full">; def flto : Flag<["-"], "flto">, Flags<[CoreOption, CC1Option]>, Group, HelpText<"Enable LTO in 'full' mode">; -def fno_lto : Flag<["-"], "fno-lto">, Group, +def fno_lto : Flag<["-"], "fno-lto">, Flags<[CoreOption, CC1Option]>, Group, HelpText<"Disable LTO mode (default)">; def flto_jobs_EQ : Joined<["-"], "flto-jobs=">, Flags<[CC1Option]>, Group, Index: clang/test/Driver/cl-options.c === --- clang/test/Driver/cl-options.c +++ clang/test/Driver/cl-options.c @@ -586,6 +586,9 @@ // RUN: %clang_cl -### /c -flto -- %s 2>&1 | FileCheck -check-prefix=LTO %s // LTO: -flto +// RUN: %clang_cl -### /c -flto -fno-lto -- %s 2>&1 | FileCheck -check-prefix=LTO-NO %s +// LTO-NO-NOT: "-flto" + // RUN: %clang_cl -### /c -flto=thin -- %s 2>&1 | FileCheck -check-prefix=LTO-THIN %s // LTO-THIN: -flto=thin Index: clang/include/clang/Driver/Options.td === --- clang/include/clang/Driver/Options.td +++ clang/include/clang/Driver/Options.td @@ -1351,7 +1351,7 @@ HelpText<"Set LTO mode to either 'full' or 'thin'">, Values<"thin,full">; def flto : Flag<["-"], "flto">, Flags<[CoreOption, CC1Option]>, Group, HelpText<"Enable LTO in 'full' mode">; -def fno_lto : Flag<["-"], "fno-lto">, Group, +def fno_lto : Flag<["-"], "fno-lto">, Flags<[CoreOption, CC1Option]>, Group, HelpText<"Disable LTO mode (default)">; def flto_jobs_EQ : Joined<["-"], "flto-jobs=">, Flags<[CC1Option]>, Group, ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D85252: [Driver] Accept -fno-lto in clang-cl
hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. lgtm In general when -ffoo is supported by clang-cl, -fno-foo should be too, so this makes sense. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85252/new/ https://reviews.llvm.org/D85252 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D85252: [Driver] Accept -fno-lto in clang-cl
aeubanks created this revision. aeubanks added reviewers: hans, thakis. Herald added subscribers: cfe-commits, dang, dexonsmith, inglorion. Herald added a project: clang. aeubanks requested review of this revision. Some compiler-rt tests check for the presence of the compiler accepting -fno-lto to add that flag. Otherwise some tests don't link due to -flto mismatch between compiling and linking. $ cmake ... -DLLVM_ENABLE_LTO=Thin ... $ ninja projects/compiler-rt/lib/sanitizer_common/tests/Sanitizer-x86_64-Test.exe previously failed, now links. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D85252 Files: clang/include/clang/Driver/Options.td clang/test/Driver/cl-options.c Index: clang/test/Driver/cl-options.c === --- clang/test/Driver/cl-options.c +++ clang/test/Driver/cl-options.c @@ -586,6 +586,9 @@ // RUN: %clang_cl -### /c -flto -- %s 2>&1 | FileCheck -check-prefix=LTO %s // LTO: -flto +// RUN: %clang_cl -### /c -flto -fno-lto -- %s 2>&1 | FileCheck -check-prefix=LTO-NO %s +// LTO-NO-NOT: "-flto" + // RUN: %clang_cl -### /c -flto=thin -- %s 2>&1 | FileCheck -check-prefix=LTO-THIN %s // LTO-THIN: -flto=thin Index: clang/include/clang/Driver/Options.td === --- clang/include/clang/Driver/Options.td +++ clang/include/clang/Driver/Options.td @@ -1351,7 +1351,7 @@ HelpText<"Set LTO mode to either 'full' or 'thin'">, Values<"thin,full">; def flto : Flag<["-"], "flto">, Flags<[CoreOption, CC1Option]>, Group, HelpText<"Enable LTO in 'full' mode">; -def fno_lto : Flag<["-"], "fno-lto">, Group, +def fno_lto : Flag<["-"], "fno-lto">, Flags<[CoreOption, CC1Option]>, Group, HelpText<"Disable LTO mode (default)">; def flto_jobs_EQ : Joined<["-"], "flto-jobs=">, Flags<[CC1Option]>, Group, Index: clang/test/Driver/cl-options.c === --- clang/test/Driver/cl-options.c +++ clang/test/Driver/cl-options.c @@ -586,6 +586,9 @@ // RUN: %clang_cl -### /c -flto -- %s 2>&1 | FileCheck -check-prefix=LTO %s // LTO: -flto +// RUN: %clang_cl -### /c -flto -fno-lto -- %s 2>&1 | FileCheck -check-prefix=LTO-NO %s +// LTO-NO-NOT: "-flto" + // RUN: %clang_cl -### /c -flto=thin -- %s 2>&1 | FileCheck -check-prefix=LTO-THIN %s // LTO-THIN: -flto=thin Index: clang/include/clang/Driver/Options.td === --- clang/include/clang/Driver/Options.td +++ clang/include/clang/Driver/Options.td @@ -1351,7 +1351,7 @@ HelpText<"Set LTO mode to either 'full' or 'thin'">, Values<"thin,full">; def flto : Flag<["-"], "flto">, Flags<[CoreOption, CC1Option]>, Group, HelpText<"Enable LTO in 'full' mode">; -def fno_lto : Flag<["-"], "fno-lto">, Group, +def fno_lto : Flag<["-"], "fno-lto">, Flags<[CoreOption, CC1Option]>, Group, HelpText<"Disable LTO mode (default)">; def flto_jobs_EQ : Joined<["-"], "flto-jobs=">, Flags<[CC1Option]>, Group, ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
