[PATCH] D87717: [docs] Update ControlFlowIntegrity.rst.
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG66cf68ed4678: [docs] Update ControlFlowIntegrity.rst. (authored by eugenis). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87717/new/ https://reviews.llvm.org/D87717 Files: clang/docs/ControlFlowIntegrity.rst Index: clang/docs/ControlFlowIntegrity.rst === --- clang/docs/ControlFlowIntegrity.rst +++ clang/docs/ControlFlowIntegrity.rst @@ -76,8 +76,8 @@ to use all schemes except for non-virtual member function call and indirect call checking. -Remember that you have to provide ``-flto`` if at least one CFI scheme is -enabled. +Remember that you have to provide ``-flto`` or ``-flto=thin`` if at +least one CFI scheme is enabled. Trapping and Diagnostics @@ -217,7 +217,8 @@ shared library boundaries are handled as if the callee was not compiled with ``-fsanitize=cfi-icall``. -This scheme is currently only supported on the x86 and x86_64 architectures. +This scheme is currently supported on a limited set of targets: x86, +x86_64, arm, arch64 and wasm. ``-fsanitize-cfi-icall-generalize-pointers`` @@ -368,7 +369,7 @@ Use **-f[no-]sanitize-cfi-cross-dso** to enable the cross-DSO control flow integrity mode, which allows all CFI schemes listed above to apply across DSO boundaries. As in the regular CFI, each DSO must be -built with ``-flto``. +built with ``-flto`` or ``-flto=thin``. Normally, CFI checks will only be performed for classes that have hidden LTO visibility. With this flag enabled, the compiler will emit cross-DSO CFI Index: clang/docs/ControlFlowIntegrity.rst === --- clang/docs/ControlFlowIntegrity.rst +++ clang/docs/ControlFlowIntegrity.rst @@ -76,8 +76,8 @@ to use all schemes except for non-virtual member function call and indirect call checking. -Remember that you have to provide ``-flto`` if at least one CFI scheme is -enabled. +Remember that you have to provide ``-flto`` or ``-flto=thin`` if at +least one CFI scheme is enabled. Trapping and Diagnostics @@ -217,7 +217,8 @@ shared library boundaries are handled as if the callee was not compiled with ``-fsanitize=cfi-icall``. -This scheme is currently only supported on the x86 and x86_64 architectures. +This scheme is currently supported on a limited set of targets: x86, +x86_64, arm, arch64 and wasm. ``-fsanitize-cfi-icall-generalize-pointers`` @@ -368,7 +369,7 @@ Use **-f[no-]sanitize-cfi-cross-dso** to enable the cross-DSO control flow integrity mode, which allows all CFI schemes listed above to apply across DSO boundaries. As in the regular CFI, each DSO must be -built with ``-flto``. +built with ``-flto`` or ``-flto=thin``. Normally, CFI checks will only be performed for classes that have hidden LTO visibility. With this flag enabled, the compiler will emit cross-DSO CFI ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D87717: [docs] Update ControlFlowIntegrity.rst.
eugenis updated this revision to Diff 295888. eugenis added a comment. fix a typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87717/new/ https://reviews.llvm.org/D87717 Files: clang/docs/ControlFlowIntegrity.rst Index: clang/docs/ControlFlowIntegrity.rst === --- clang/docs/ControlFlowIntegrity.rst +++ clang/docs/ControlFlowIntegrity.rst @@ -76,8 +76,8 @@ to use all schemes except for non-virtual member function call and indirect call checking. -Remember that you have to provide ``-flto`` if at least one CFI scheme is -enabled. +Remember that you have to provide ``-flto`` or ``-flto=thin`` if at +least one CFI scheme is enabled. Trapping and Diagnostics @@ -217,7 +217,8 @@ shared library boundaries are handled as if the callee was not compiled with ``-fsanitize=cfi-icall``. -This scheme is currently only supported on the x86 and x86_64 architectures. +This scheme is currently supported on a limited set of targets: x86, +x86_64, arm, arch64 and wasm. ``-fsanitize-cfi-icall-generalize-pointers`` @@ -368,7 +369,7 @@ Use **-f[no-]sanitize-cfi-cross-dso** to enable the cross-DSO control flow integrity mode, which allows all CFI schemes listed above to apply across DSO boundaries. As in the regular CFI, each DSO must be -built with ``-flto``. +built with ``-flto`` or ``-flto=thin``. Normally, CFI checks will only be performed for classes that have hidden LTO visibility. With this flag enabled, the compiler will emit cross-DSO CFI Index: clang/docs/ControlFlowIntegrity.rst === --- clang/docs/ControlFlowIntegrity.rst +++ clang/docs/ControlFlowIntegrity.rst @@ -76,8 +76,8 @@ to use all schemes except for non-virtual member function call and indirect call checking. -Remember that you have to provide ``-flto`` if at least one CFI scheme is -enabled. +Remember that you have to provide ``-flto`` or ``-flto=thin`` if at +least one CFI scheme is enabled. Trapping and Diagnostics @@ -217,7 +217,8 @@ shared library boundaries are handled as if the callee was not compiled with ``-fsanitize=cfi-icall``. -This scheme is currently only supported on the x86 and x86_64 architectures. +This scheme is currently supported on a limited set of targets: x86, +x86_64, arm, arch64 and wasm. ``-fsanitize-cfi-icall-generalize-pointers`` @@ -368,7 +369,7 @@ Use **-f[no-]sanitize-cfi-cross-dso** to enable the cross-DSO control flow integrity mode, which allows all CFI schemes listed above to apply across DSO boundaries. As in the regular CFI, each DSO must be -built with ``-flto``. +built with ``-flto`` or ``-flto=thin``. Normally, CFI checks will only be performed for classes that have hidden LTO visibility. With this flag enabled, the compiler will emit cross-DSO CFI ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D87717: [docs] Update ControlFlowIntegrity.rst.
MaskRay added inline comments. Comment at: clang/docs/ControlFlowIntegrity.rst:372 apply across DSO boundaries. As in the regular CFI, each DSO must be -built with ``-flto``. +built with ``-flto`` or ``flto=thin``. typo: `-flto=thin` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87717/new/ https://reviews.llvm.org/D87717 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D87717: [docs] Update ControlFlowIntegrity.rst.
pcc accepted this revision. pcc added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87717/new/ https://reviews.llvm.org/D87717 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D87717: [docs] Update ControlFlowIntegrity.rst.
eugenis created this revision. eugenis added a reviewer: pcc. Herald added a subscriber: dexonsmith. Herald added a project: clang. eugenis requested review of this revision. Herald added a subscriber: aheejin. Expand the list of targets that support cfi-icall. Add ThinLTO everywhere LTO is mentioned. AFAIK all CFI features are supported with ThinLTO. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D87717 Files: clang/docs/ControlFlowIntegrity.rst Index: clang/docs/ControlFlowIntegrity.rst === --- clang/docs/ControlFlowIntegrity.rst +++ clang/docs/ControlFlowIntegrity.rst @@ -76,8 +76,8 @@ to use all schemes except for non-virtual member function call and indirect call checking. -Remember that you have to provide ``-flto`` if at least one CFI scheme is -enabled. +Remember that you have to provide ``-flto`` or ``-flto=thin`` if at +least one CFI scheme is enabled. Trapping and Diagnostics @@ -217,7 +217,8 @@ shared library boundaries are handled as if the callee was not compiled with ``-fsanitize=cfi-icall``. -This scheme is currently only supported on the x86 and x86_64 architectures. +This scheme is currently supported on a limited set of targets: x86, +x86_64, arm, arch64 and wasm. ``-fsanitize-cfi-icall-generalize-pointers`` @@ -368,7 +369,7 @@ Use **-f[no-]sanitize-cfi-cross-dso** to enable the cross-DSO control flow integrity mode, which allows all CFI schemes listed above to apply across DSO boundaries. As in the regular CFI, each DSO must be -built with ``-flto``. +built with ``-flto`` or ``flto=thin``. Normally, CFI checks will only be performed for classes that have hidden LTO visibility. With this flag enabled, the compiler will emit cross-DSO CFI Index: clang/docs/ControlFlowIntegrity.rst === --- clang/docs/ControlFlowIntegrity.rst +++ clang/docs/ControlFlowIntegrity.rst @@ -76,8 +76,8 @@ to use all schemes except for non-virtual member function call and indirect call checking. -Remember that you have to provide ``-flto`` if at least one CFI scheme is -enabled. +Remember that you have to provide ``-flto`` or ``-flto=thin`` if at +least one CFI scheme is enabled. Trapping and Diagnostics @@ -217,7 +217,8 @@ shared library boundaries are handled as if the callee was not compiled with ``-fsanitize=cfi-icall``. -This scheme is currently only supported on the x86 and x86_64 architectures. +This scheme is currently supported on a limited set of targets: x86, +x86_64, arm, arch64 and wasm. ``-fsanitize-cfi-icall-generalize-pointers`` @@ -368,7 +369,7 @@ Use **-f[no-]sanitize-cfi-cross-dso** to enable the cross-DSO control flow integrity mode, which allows all CFI schemes listed above to apply across DSO boundaries. As in the regular CFI, each DSO must be -built with ``-flto``. +built with ``-flto`` or ``flto=thin``. Normally, CFI checks will only be performed for classes that have hidden LTO visibility. With this flag enabled, the compiler will emit cross-DSO CFI ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
