[PATCH] D87904: [AIX][Clang][Driver] Add handling of nostartfiles option
This revision was automatically updated to reflect the committed changes. Closed by commit rG699089f2a970: [AIX][Clang][Driver] Add handling of nostartfiles option (authored by daltenty). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87904/new/ https://reviews.llvm.org/D87904 Files: clang/lib/Driver/ToolChains/AIX.cpp clang/test/Driver/aix-ld.c Index: clang/test/Driver/aix-ld.c === --- clang/test/Driver/aix-ld.c +++ clang/test/Driver/aix-ld.c @@ -331,6 +331,38 @@ // CHECK-LD64-NOSTDLIBXX-LCXX-NOT: "-lc++" // CHECK-LD64-NOSTDLIBXX-LCXX: "-lc" +// Check powerpc64-ibm-aix7.1.0.0, 32-bit. -nostartfiles. +// RUN: %clangxx -no-canonical-prefixes %s 2>&1 -### \ +// RUN:-nostartfiles \ +// RUN:-target powerpc-ibm-aix7.1.0.0 \ +// RUN:--sysroot %S/Inputs/aix_ppc_tree \ +// RUN: | FileCheck --check-prefix=CHECK-LD32-NOSTARTFILES-LCXX %s +// CHECK-LD32-NOSTARTFILES-LCXX: {{.*}}clang{{.*}}" "-cc1" "-triple" "powerpc-ibm-aix7.1.0.0" +// CHECK-LD32-NOSTARTFILES-LCXX: "-isysroot" "[[SYSROOT:[^"]+]]" +// CHECK-LD32-NOSTARTFILES-LCXX: "{{.*}}ld{{(.exe)?}}" +// CHECK-LD32-NOSTARTFILES-LCXX: "-b32" +// CHECK-LD32-NOSTARTFILES-LCXX: "-bpT:0x1000" "-bpD:0x2000" +// CHECK-LD32-NOSTARTFILES-LCXX-NOT: "[[SYSROOT]]/usr/lib{{/|}}crt0.o" +// CHECK-LD32-NOSTARTFILES-LCXX: "-L[[SYSROOT]]/usr/lib" +// CHECK-LD32-NOSTARTFILES-LCXX "-lc++" +// CHECK-LD32-NOSTARTFILES-LCXX: "-lc" + +// Check powerpc64-ibm-aix7.1.0.0, 64-bit. -nostartfiles. +// RUN: %clangxx -no-canonical-prefixes %s 2>&1 -### \ +// RUN:-nostartfiles \ +// RUN:-target powerpc-ibm-aix7.1.0.0 \ +// RUN:--sysroot %S/Inputs/aix_ppc_tree \ +// RUN: | FileCheck --check-prefix=CHECK-LD32-NOSTARTFILES-LCXX %s +// CHECK-LD64-NOSTARTFILES-LCXX: {{.*}}clang{{.*}}" "-cc1" "-triple" "powerpc64-ibm-aix7.1.0.0" +// CHECK-LD64-NOSTARTFILES-LCXX: "-isysroot" "[[SYSROOT:[^"]+]]" +// CHECK-LD64-NOSTARTFILES-LCXX: "{{.*}}ld{{(.exe)?}}" +// CHECK-LD64-NOSTARTFILES-LCXX: "-b64" +// CHECK-LD64-NOSTARTFILES-LCXX: "-bpT:0x1" "-bpD:0x11000" +// CHECK-LD64-NOSTARTFILES-LCXX-NOT: "[[SYSROOT]]/usr/lib{{/|}}crt0_64.o" +// CHECK-LD64-NOSTARTFILES-LCXX: "-L[[SYSROOT]]/usr/lib" +// CHECK-LD64-NOSTARTFILES-LCXX: "-lc++" +// CHECK-LD64-NOSTARTFILES-LCXX: "-lc" + // Check powerpc-ibm-aix7.1.0.0, 32-bit. -stdlib=libstdc++ invokes fatal error. // RUN: not --crash %clangxx -no-canonical-prefixes %s 2>&1 -### \ // RUN:-target powerpc-ibm-aix7.1.0.0 \ Index: clang/lib/Driver/ToolChains/AIX.cpp === --- clang/lib/Driver/ToolChains/AIX.cpp +++ clang/lib/Driver/ToolChains/AIX.cpp @@ -123,7 +123,7 @@ return IsArch32Bit ? "crt0.o" : "crt0_64.o"; }; - if (!Args.hasArg(options::OPT_nostdlib)) { + if (!Args.hasArg(options::OPT_nostdlib, options::OPT_nostartfiles)) { CmdArgs.push_back( Args.MakeArgString(ToolChain.GetFilePath(getCrt0Basename(; } Index: clang/test/Driver/aix-ld.c === --- clang/test/Driver/aix-ld.c +++ clang/test/Driver/aix-ld.c @@ -331,6 +331,38 @@ // CHECK-LD64-NOSTDLIBXX-LCXX-NOT: "-lc++" // CHECK-LD64-NOSTDLIBXX-LCXX: "-lc" +// Check powerpc64-ibm-aix7.1.0.0, 32-bit. -nostartfiles. +// RUN: %clangxx -no-canonical-prefixes %s 2>&1 -### \ +// RUN:-nostartfiles \ +// RUN:-target powerpc-ibm-aix7.1.0.0 \ +// RUN:--sysroot %S/Inputs/aix_ppc_tree \ +// RUN: | FileCheck --check-prefix=CHECK-LD32-NOSTARTFILES-LCXX %s +// CHECK-LD32-NOSTARTFILES-LCXX: {{.*}}clang{{.*}}" "-cc1" "-triple" "powerpc-ibm-aix7.1.0.0" +// CHECK-LD32-NOSTARTFILES-LCXX: "-isysroot" "[[SYSROOT:[^"]+]]" +// CHECK-LD32-NOSTARTFILES-LCXX: "{{.*}}ld{{(.exe)?}}" +// CHECK-LD32-NOSTARTFILES-LCXX: "-b32" +// CHECK-LD32-NOSTARTFILES-LCXX: "-bpT:0x1000" "-bpD:0x2000" +// CHECK-LD32-NOSTARTFILES-LCXX-NOT: "[[SYSROOT]]/usr/lib{{/|}}crt0.o" +// CHECK-LD32-NOSTARTFILES-LCXX: "-L[[SYSROOT]]/usr/lib" +// CHECK-LD32-NOSTARTFILES-LCXX "-lc++" +// CHECK-LD32-NOSTARTFILES-LCXX: "-lc" + +// Check powerpc64-ibm-aix7.1.0.0, 64-bit. -nostartfiles. +// RUN: %clangxx -no-canonical-prefixes %s 2>&1 -### \ +// RUN:-nostartfiles \ +// RUN:-target powerpc-ibm-aix7.1.0.0 \ +// RUN:--sysroot %S/Inputs/aix_ppc_tree \ +// RUN: | FileCheck --check-prefix=CHECK-LD32-NOSTARTFILES-LCXX %s +// CHECK-LD64-NOSTARTFILES-LCXX: {{.*}}clang{{.*}}" "-cc1" "-triple" "powerpc64-ibm-aix7.1.0.0" +// CHECK-LD64-NOSTARTFILES-LCXX: "-isysroot" "[[SYSROOT:[^"]+]]" +// CHECK-LD64-NOSTARTFILES-LCXX: "{{.*}}ld{{(.exe)?}}" +// CHECK-LD64-NOSTARTFILES-LCXX: "-b64" +// CHECK-LD64-NOSTARTFILES-LCXX: "-bpT:0x1" "-bpD:0x11
[PATCH] D87904: [AIX][Clang][Driver] Add handling of nostartfiles option
jasonliu accepted this revision. jasonliu added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87904/new/ https://reviews.llvm.org/D87904 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D87904: [AIX][Clang][Driver] Add handling of nostartfiles option
daltenty created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. daltenty requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D87904 Files: clang/lib/Driver/ToolChains/AIX.cpp clang/test/Driver/aix-ld.c Index: clang/test/Driver/aix-ld.c === --- clang/test/Driver/aix-ld.c +++ clang/test/Driver/aix-ld.c @@ -331,6 +331,38 @@ // CHECK-LD64-NOSTDLIBXX-LCXX-NOT: "-lc++" // CHECK-LD64-NOSTDLIBXX-LCXX: "-lc" +// Check powerpc64-ibm-aix7.1.0.0, 32-bit. -nostartfiles. +// RUN: %clangxx -no-canonical-prefixes %s 2>&1 -### \ +// RUN:-nostartfiles \ +// RUN:-target powerpc-ibm-aix7.1.0.0 \ +// RUN:--sysroot %S/Inputs/aix_ppc_tree \ +// RUN: | FileCheck --check-prefix=CHECK-LD32-NOSTARTFILES-LCXX %s +// CHECK-LD32-NOSTARTFILES-LCXX: {{.*}}clang{{.*}}" "-cc1" "-triple" "powerpc-ibm-aix7.1.0.0" +// CHECK-LD32-NOSTARTFILES-LCXX: "-isysroot" "[[SYSROOT:[^"]+]]" +// CHECK-LD32-NOSTARTFILES-LCXX: "{{.*}}ld{{(.exe)?}}" +// CHECK-LD32-NOSTARTFILES-LCXX: "-b32" +// CHECK-LD32-NOSTARTFILES-LCXX: "-bpT:0x1000" "-bpD:0x2000" +// CHECK-LD32-NOSTARTFILES-LCXX-NOT: "[[SYSROOT]]/usr/lib{{/|}}crt0.o" +// CHECK-LD32-NOSTARTFILES-LCXX: "-L[[SYSROOT]]/usr/lib" +// CHECK-LD32-NOSTARTFILES-LCXX "-lc++" +// CHECK-LD32-NOSTARTFILES-LCXX: "-lc" + +// Check powerpc64-ibm-aix7.1.0.0, 64-bit. -nostartfiles. +// RUN: %clangxx -no-canonical-prefixes %s 2>&1 -### \ +// RUN:-nostartfiles \ +// RUN:-target powerpc-ibm-aix7.1.0.0 \ +// RUN:--sysroot %S/Inputs/aix_ppc_tree \ +// RUN: | FileCheck --check-prefix=CHECK-LD32-NOSTARTFILES-LCXX %s +// CHECK-LD64-NOSTARTFILES-LCXX: {{.*}}clang{{.*}}" "-cc1" "-triple" "powerpc64-ibm-aix7.1.0.0" +// CHECK-LD64-NOSTARTFILES-LCXX: "-isysroot" "[[SYSROOT:[^"]+]]" +// CHECK-LD64-NOSTARTFILES-LCXX: "{{.*}}ld{{(.exe)?}}" +// CHECK-LD64-NOSTARTFILES-LCXX: "-b64" +// CHECK-LD64-NOSTARTFILES-LCXX: "-bpT:0x1" "-bpD:0x11000" +// CHECK-LD64-NOSTARTFILES-LCXX-NOT: "[[SYSROOT]]/usr/lib{{/|}}crt0_64.o" +// CHECK-LD64-NOSTARTFILES-LCXX: "-L[[SYSROOT]]/usr/lib" +// CHECK-LD64-NOSTARTFILES-LCXX: "-lc++" +// CHECK-LD64-NOSTARTFILES-LCXX: "-lc" + // Check powerpc-ibm-aix7.1.0.0, 32-bit. -stdlib=libstdc++ invokes fatal error. // RUN: not --crash %clangxx -no-canonical-prefixes %s 2>&1 -### \ // RUN:-target powerpc-ibm-aix7.1.0.0 \ Index: clang/lib/Driver/ToolChains/AIX.cpp === --- clang/lib/Driver/ToolChains/AIX.cpp +++ clang/lib/Driver/ToolChains/AIX.cpp @@ -123,7 +123,7 @@ return IsArch32Bit ? "crt0.o" : "crt0_64.o"; }; - if (!Args.hasArg(options::OPT_nostdlib)) { + if (!Args.hasArg(options::OPT_nostdlib, options::OPT_nostartfiles)) { CmdArgs.push_back( Args.MakeArgString(ToolChain.GetFilePath(getCrt0Basename(; } Index: clang/test/Driver/aix-ld.c === --- clang/test/Driver/aix-ld.c +++ clang/test/Driver/aix-ld.c @@ -331,6 +331,38 @@ // CHECK-LD64-NOSTDLIBXX-LCXX-NOT: "-lc++" // CHECK-LD64-NOSTDLIBXX-LCXX: "-lc" +// Check powerpc64-ibm-aix7.1.0.0, 32-bit. -nostartfiles. +// RUN: %clangxx -no-canonical-prefixes %s 2>&1 -### \ +// RUN:-nostartfiles \ +// RUN:-target powerpc-ibm-aix7.1.0.0 \ +// RUN:--sysroot %S/Inputs/aix_ppc_tree \ +// RUN: | FileCheck --check-prefix=CHECK-LD32-NOSTARTFILES-LCXX %s +// CHECK-LD32-NOSTARTFILES-LCXX: {{.*}}clang{{.*}}" "-cc1" "-triple" "powerpc-ibm-aix7.1.0.0" +// CHECK-LD32-NOSTARTFILES-LCXX: "-isysroot" "[[SYSROOT:[^"]+]]" +// CHECK-LD32-NOSTARTFILES-LCXX: "{{.*}}ld{{(.exe)?}}" +// CHECK-LD32-NOSTARTFILES-LCXX: "-b32" +// CHECK-LD32-NOSTARTFILES-LCXX: "-bpT:0x1000" "-bpD:0x2000" +// CHECK-LD32-NOSTARTFILES-LCXX-NOT: "[[SYSROOT]]/usr/lib{{/|}}crt0.o" +// CHECK-LD32-NOSTARTFILES-LCXX: "-L[[SYSROOT]]/usr/lib" +// CHECK-LD32-NOSTARTFILES-LCXX "-lc++" +// CHECK-LD32-NOSTARTFILES-LCXX: "-lc" + +// Check powerpc64-ibm-aix7.1.0.0, 64-bit. -nostartfiles. +// RUN: %clangxx -no-canonical-prefixes %s 2>&1 -### \ +// RUN:-nostartfiles \ +// RUN:-target powerpc-ibm-aix7.1.0.0 \ +// RUN:--sysroot %S/Inputs/aix_ppc_tree \ +// RUN: | FileCheck --check-prefix=CHECK-LD32-NOSTARTFILES-LCXX %s +// CHECK-LD64-NOSTARTFILES-LCXX: {{.*}}clang{{.*}}" "-cc1" "-triple" "powerpc64-ibm-aix7.1.0.0" +// CHECK-LD64-NOSTARTFILES-LCXX: "-isysroot" "[[SYSROOT:[^"]+]]" +// CHECK-LD64-NOSTARTFILES-LCXX: "{{.*}}ld{{(.exe)?}}" +// CHECK-LD64-NOSTARTFILES-LCXX: "-b64" +// CHECK-LD64-NOSTARTFILES-LCXX: "-bpT:0x1" "-bpD:0x11000" +// CHECK-LD64-NOSTARTFILES-LCXX-NOT: "[[SYSROOT]]/usr/lib{{/|}}crt0_64.o" +// CHECK-LD64-NOSTARTFI