[PATCH] D97496: [Clang][ASan] Correct AsanDtorKindToString to return non-void in default case

[Kostya Kortchinsky via Phabricator via cfe-commits]

This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG41751b637317: [Clang][ASan] Correct AsanDtorKindToString to 
return non-void in default case (authored by cryptoad).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97496/new/

https://reviews.llvm.org/D97496

Files:
  clang/lib/Basic/Sanitizers.cpp


Index: clang/lib/Basic/Sanitizers.cpp
===
--- clang/lib/Basic/Sanitizers.cpp
+++ clang/lib/Basic/Sanitizers.cpp
@@ -70,6 +70,7 @@
   case llvm::AsanDtorKind::Invalid:
 return "invalid";
   }
+  return "invalid";
 }
 
 llvm::AsanDtorKind AsanDtorKindFromString(StringRef kindStr) {


Index: clang/lib/Basic/Sanitizers.cpp
===
--- clang/lib/Basic/Sanitizers.cpp
+++ clang/lib/Basic/Sanitizers.cpp
@@ -70,6 +70,7 @@
   case llvm::AsanDtorKind::Invalid:
 return "invalid";
   }
+  return "invalid";
 }
 
 llvm::AsanDtorKind AsanDtorKindFromString(StringRef kindStr) {
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D97496: [Clang][ASan] Correct AsanDtorKindToString to return non-void in default case

[Dan Liew via Phabricator via cfe-commits]

delcypher added a comment.

@cryptoad Thanks.

LGTM

Originally this code had a `default` case in the switch but clang complained 
about it being unnecessary because it was exhaustive, so I removed it... It 
seems this is causing problems with your compiler :(


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97496/new/

https://reviews.llvm.org/D97496

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D97496: [Clang][ASan] Correct AsanDtorKindToString to return non-void in default case

[Kostya Kortchinsky via Phabricator via cfe-commits]

cryptoad updated this revision to Diff 326516.
cryptoad added a comment.

Opt for a version that satisfies `clang-diagnostic-covered-switch-default`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97496/new/

https://reviews.llvm.org/D97496

Files:
  clang/lib/Basic/Sanitizers.cpp


Index: clang/lib/Basic/Sanitizers.cpp
===
--- clang/lib/Basic/Sanitizers.cpp
+++ clang/lib/Basic/Sanitizers.cpp
@@ -70,6 +70,7 @@
   case llvm::AsanDtorKind::Invalid:
 return "invalid";
   }
+  return "invalid";
 }
 
 llvm::AsanDtorKind AsanDtorKindFromString(StringRef kindStr) {


Index: clang/lib/Basic/Sanitizers.cpp
===
--- clang/lib/Basic/Sanitizers.cpp
+++ clang/lib/Basic/Sanitizers.cpp
@@ -70,6 +70,7 @@
   case llvm::AsanDtorKind::Invalid:
 return "invalid";
   }
+  return "invalid";
 }
 
 llvm::AsanDtorKind AsanDtorKindFromString(StringRef kindStr) {
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D97496: [Clang][ASan] Correct AsanDtorKindToString to return non-void in default case

[Kostya Kortchinsky via Phabricator via cfe-commits]

cryptoad created this revision.
cryptoad added reviewers: delcypher, vitalybuka.
Herald added a subscriber: dexonsmith.
cryptoad requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.

Post D96572 , a warning started showing up for 
me:
`clang/lib/Basic/Sanitizers.cpp:73:1: warning: control reaches end of non-void 
function [-Wreturn-type]`

So this adds a default to the case to return invalid, which seems appropriate,
and appears to correct the issue.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D97496

Files:
  clang/lib/Basic/Sanitizers.cpp


Index: clang/lib/Basic/Sanitizers.cpp
===
--- clang/lib/Basic/Sanitizers.cpp
+++ clang/lib/Basic/Sanitizers.cpp
@@ -68,6 +68,8 @@
   case llvm::AsanDtorKind::Global:
 return "global";
   case llvm::AsanDtorKind::Invalid:
+LLVM_FALLTHROUGH;
+  default:
 return "invalid";
   }
 }


Index: clang/lib/Basic/Sanitizers.cpp
===
--- clang/lib/Basic/Sanitizers.cpp
+++ clang/lib/Basic/Sanitizers.cpp
@@ -68,6 +68,8 @@
   case llvm::AsanDtorKind::Global:
 return "global";
   case llvm::AsanDtorKind::Invalid:
+LLVM_FALLTHROUGH;
+  default:
 return "invalid";
   }
 }
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits