[clang] [Clang][LoongArch] Support builtin functions for LSX and LASX (PR #69313)

2023-10-22 Thread WÁNG Xuěruì via cfe-commits 

xen0n wrote:

According to [the *LLVM GitHub user 
guide*](https://llvm.org/docs/GitHub.html#creating-pull-requests):

> If you have multiple changes you want to introduce, it’s recommended to 
> create separate pull requests for each change.

Given you've already split your changes into several smaller commits, it's 
probably better to file them as separate PRs, so each one is smaller than the 
current 3+-line diff, and become more reviewable that way.

https://github.com/llvm/llvm-project/pull/69313
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][LoongArch] Support builtin functions for LSX and LASX (PR #69313)

2023-10-22 Thread Lu Weining via cfe-commits 

SixWeining wrote:

> Given you've already split your changes into several smaller commits, it's 
> probably better to file them as separate PRs, so each one is smaller than the 
> current 3+-line diff, and become more reviewable that way.

I'm not sure seperate PRs are appropriate since some of these 6 commits depend 
on the others. If creating 6 PRs, we will see:
PR1 consists of 1 commit
PR2 consists of 2 commits
...
PR6 consists of 6 commits

In fact, we can review each of these 6 commits in one PR by clicking the 
`Changes from all commits` button and `Select commit` in the `Files changed` 
tab.





https://github.com/llvm/llvm-project/pull/69313
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][LoongArch] Support builtin functions for LSX and LASX (PR #69313)

2023-10-22 Thread Lu Weining via cfe-commits 

https://github.com/SixWeining requested changes to this pull request.

- For the commits `[LoongArch][CodeGen][clang] Add builtin functions test cases 
for LASX` and `[LoongArch][CodeGen][clang] Add builtin functions test cases for 
LSX`, `Change-Id`s can be removed.
- Please fix the test failure.

https://github.com/llvm/llvm-project/pull/69313
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][LoongArch] Support builtin functions for LSX and LASX (PR #69313)

2023-10-25 Thread via cfe-commits 

github-actions[bot] wrote:




:warning: C/C++ code formatter, clang-format found issues in your code. 
:warning:



You can test this locally with the following command:


``bash
git-clang-format --diff 7df92fbe74e3c1b41c06f5fc784473f7f22aeed7 
0bd36f11c5d1da2447b1c123445a1472372a096b -- clang/lib/Headers/lasxintrin.h 
clang/lib/Headers/lsxintrin.h 
clang/test/CodeGen/LoongArch/lasx/builtin-alias-error.c 
clang/test/CodeGen/LoongArch/lasx/builtin-alias.c 
clang/test/CodeGen/LoongArch/lasx/builtin-error.c 
clang/test/CodeGen/LoongArch/lasx/builtin.c 
clang/test/CodeGen/LoongArch/lsx/builtin-alias-error.c 
clang/test/CodeGen/LoongArch/lsx/builtin-alias.c 
clang/test/CodeGen/LoongArch/lsx/builtin-error.c 
clang/test/CodeGen/LoongArch/lsx/builtin.c 
clang/test/Driver/loongarch-mlasx-error.c clang/test/Driver/loongarch-mlasx.c 
clang/test/Driver/loongarch-mlsx-error.c clang/test/Driver/loongarch-mlsx.c 
clang/lib/Basic/Targets/LoongArch.cpp clang/lib/Basic/Targets/LoongArch.h 
clang/lib/CodeGen/Targets/LoongArch.cpp 
clang/lib/Driver/ToolChains/Arch/LoongArch.cpp clang/lib/Sema/SemaChecking.cpp 
clang/test/Preprocessor/init-loongarch.c
``





View the diff from clang-format here.


``diff
diff --git a/clang/lib/Sema/SemaChecking.cpp b/clang/lib/Sema/SemaChecking.cpp
index b4b4571a4c4f..3518ed86751e 100644
--- a/clang/lib/Sema/SemaChecking.cpp
+++ b/clang/lib/Sema/SemaChecking.cpp
@@ -9201,8 +9201,7 @@ ExprResult Sema::SemaConvertVectorExpr(Expr *E, 
TypeSourceInfo *TInfo,
   diag::err_convertvector_non_vector)
  << E->getSourceRange());
   if (!DstTy->isVectorType() && !DstTy->isDependentType())
-return ExprError(Diag(BuiltinLoc,
-  diag::err_convertvector_non_vector_type));
+return ExprError(Diag(BuiltinLoc, 
diag::err_convertvector_non_vector_type));
 
   if (!SrcTy->isDependentType() && !DstTy->isDependentType()) {
 unsigned SrcElts = SrcTy->castAs()->getNumElements();

``




https://github.com/llvm/llvm-project/pull/69313
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[llvm] [clang-tools-extra] [clang] [Clang][LoongArch] Support builtin functions for LSX and LASX (PR #69313)

2023-10-30 Thread Lu Weining via cfe-commits 

https://github.com/SixWeining approved this pull request.

LGTM.

https://github.com/llvm/llvm-project/pull/69313
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits