[clang] [Clang] Added check for unexpanded pack in attribute [[assume]] (PR #91893)

2024-05-12 Thread Azmat Yusuf via cfe-commits 

https://github.com/azmat-y created 
https://github.com/llvm/llvm-project/pull/91893

Added a check for unexpanded parameter pack in attribute [[assume]]. Tested it 
with expected-error statements from clang fronted. This fixes #91232. @Sirraide 

>From cbb35bd010f2d46ae70367549a2838841a55aeb7 Mon Sep 17 00:00:00 2001
From: Azmat Yusuf 
Date: Sun, 12 May 2024 20:49:14 +0530
Subject: [PATCH] [Clang] Added check for unexpanded pack in attribute
 [[assume]]

---
 clang/lib/Sema/SemaStmtAttr.cpp | 5 +
 clang/test/SemaCXX/cxx23-assume.cpp | 5 +
 2 files changed, 10 insertions(+)

diff --git a/clang/lib/Sema/SemaStmtAttr.cpp b/clang/lib/Sema/SemaStmtAttr.cpp
index 1c84830b6ddd2..36f8ecadcfab7 100644
--- a/clang/lib/Sema/SemaStmtAttr.cpp
+++ b/clang/lib/Sema/SemaStmtAttr.cpp
@@ -670,6 +670,11 @@ ExprResult Sema::ActOnCXXAssumeAttr(Stmt *St, const 
ParsedAttr &A,
   }
 
   auto *Assumption = A.getArgAsExpr(0);
+
+  if (DiagnoseUnexpandedParameterPack(Assumption)) {
+return ExprError();
+  }
+
   if (Assumption->getDependence() == ExprDependence::None) {
 ExprResult Res = BuildCXXAssumeExpr(Assumption, A.getAttrName(), Range);
 if (Res.isInvalid())
diff --git a/clang/test/SemaCXX/cxx23-assume.cpp 
b/clang/test/SemaCXX/cxx23-assume.cpp
index 8676970de14f6..e67d72ae0a995 100644
--- a/clang/test/SemaCXX/cxx23-assume.cpp
+++ b/clang/test/SemaCXX/cxx23-assume.cpp
@@ -138,3 +138,8 @@ constexpr int foo() {
 }
 
 static_assert(foo() == 0);
+
+template 
+void f() {
+[[assume(val)]]; // expected-error {{expression contains unexpanded 
parameter pack}}
+}

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Added check for unexpanded pack in attribute [[assume]] (PR #91893)

2024-05-12 Thread via cfe-commits 

github-actions[bot] wrote:



Thank you for submitting a Pull Request (PR) to the LLVM Project!

This PR will be automatically labeled and the relevant teams will be
notified.

If you wish to, you can add reviewers by using the "Reviewers" section on this 
page.

If this is not working for you, it is probably because you do not have write
permissions for the repository. In which case you can instead tag reviewers by
name in a comment by using `@` followed by their GitHub username.

If you have received no comments on your PR for a week, you can request a review
by "ping"ing the PR by adding a comment “Ping”. The common courtesy "ping" rate
is once a week. Please remember that you are asking for valuable time from 
other developers.

If you have further questions, they may be answered by the [LLVM GitHub User 
Guide](https://llvm.org/docs/GitHub.html).

You can also ask questions in a comment on this PR, on the [LLVM 
Discord](https://discord.com/invite/xS7Z362) or on the 
[forums](https://discourse.llvm.org/).

https://github.com/llvm/llvm-project/pull/91893
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Added check for unexpanded pack in attribute [[assume]] (PR #91893)

2024-05-12 Thread via cfe-commits 

llvmbot wrote:




@llvm/pr-subscribers-clang

Author: Azmat Yusuf (azmat-y)


Changes

Added a check for unexpanded parameter pack in attribute [[assume]]. Tested it 
with expected-error statements from clang fronted. This fixes #91232. 
@Sirraide 

---
Full diff: https://github.com/llvm/llvm-project/pull/91893.diff


2 Files Affected:

- (modified) clang/lib/Sema/SemaStmtAttr.cpp (+5) 
- (modified) clang/test/SemaCXX/cxx23-assume.cpp (+5) 


``diff
diff --git a/clang/lib/Sema/SemaStmtAttr.cpp b/clang/lib/Sema/SemaStmtAttr.cpp
index 1c84830b6ddd2..36f8ecadcfab7 100644
--- a/clang/lib/Sema/SemaStmtAttr.cpp
+++ b/clang/lib/Sema/SemaStmtAttr.cpp
@@ -670,6 +670,11 @@ ExprResult Sema::ActOnCXXAssumeAttr(Stmt *St, const 
ParsedAttr &A,
   }
 
   auto *Assumption = A.getArgAsExpr(0);
+
+  if (DiagnoseUnexpandedParameterPack(Assumption)) {
+return ExprError();
+  }
+
   if (Assumption->getDependence() == ExprDependence::None) {
 ExprResult Res = BuildCXXAssumeExpr(Assumption, A.getAttrName(), Range);
 if (Res.isInvalid())
diff --git a/clang/test/SemaCXX/cxx23-assume.cpp 
b/clang/test/SemaCXX/cxx23-assume.cpp
index 8676970de14f6..e67d72ae0a995 100644
--- a/clang/test/SemaCXX/cxx23-assume.cpp
+++ b/clang/test/SemaCXX/cxx23-assume.cpp
@@ -138,3 +138,8 @@ constexpr int foo() {
 }
 
 static_assert(foo() == 0);
+
+template 
+void f() {
+[[assume(val)]]; // expected-error {{expression contains unexpanded 
parameter pack}}
+}

``




https://github.com/llvm/llvm-project/pull/91893
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Added check for unexpanded pack in attribute [[assume]] (PR #91893)

2024-05-13 Thread via cfe-commits 

https://github.com/cor3ntin approved this pull request.

LGTM!
Thanks for working on this

https://github.com/llvm/llvm-project/pull/91893
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Added check for unexpanded pack in attribute [[assume]] (PR #91893)

2024-05-13 Thread via cfe-commits 

https://github.com/cor3ntin closed 
https://github.com/llvm/llvm-project/pull/91893
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Added check for unexpanded pack in attribute [[assume]] (PR #91893)

2024-05-13 Thread via cfe-commits 

github-actions[bot] wrote:



@azmat-y Congratulations on having your first Pull Request (PR) merged into the 
LLVM Project!

Your changes will be combined with recent changes from other authors, then 
tested
by our [build bots](https://lab.llvm.org/buildbot/). If there is a problem with 
a build, you may receive a report in an email or a comment on this PR.

Please check whether problems have been caused by your change specifically, as
the builds can include changes from many authors. It is not uncommon for your
change to be included in a build that fails due to someone else's changes, or
infrastructure issues.

How to do this, and the rest of the post-merge process, is covered in detail 
[here](https://llvm.org/docs/MyFirstTypoFix.html#myfirsttypofix-issues-after-landing-your-pr).

If your change does cause a problem, it may be reverted, or you can revert it 
yourself.
This is a normal part of [LLVM 
development](https://llvm.org/docs/DeveloperPolicy.html#patch-reversion-policy).
 You can fix your changes and open a new PR to merge them again.

If you don't get any reports, no action is required from you. Your changes are 
working as expected, well done!


https://github.com/llvm/llvm-project/pull/91893
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Added check for unexpanded pack in attribute [[assume]] (PR #91893)

2024-05-13 Thread Azmat Yusuf via cfe-commits 

azmat-y wrote:

It was a pleasure working on this. 

I have received two emails from llvm build bot regarding failed builds, though 
the commit shows  8 build fails. How to go about investigating the cause of 
failures? Can you give me some pointers regarding this. And do the failures 
means this patch will need to be reverted?

https://github.com/llvm/llvm-project/pull/91893
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Added check for unexpanded pack in attribute [[assume]] (PR #91893)

2024-05-13 Thread via cfe-commits 

Sirraide wrote:

> I have received two emails from llvm build bot regarding failed builds, 
> though the commit shows 8 build fails.

That need not be because of this pr specifically; it may just be that someone 
else did something that caused the build to fail, and the commit for this pr 
just happened to be among the commits that was tested. Can you put the buildbot 
link here so we can take a look at it?

https://github.com/llvm/llvm-project/pull/91893
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Added check for unexpanded pack in attribute [[assume]] (PR #91893)

2024-05-13 Thread Azmat Yusuf via cfe-commits 

azmat-y wrote:

Here are the builds

Mentioned in emails
[clang-aarch64-sve-vls](https://lab.llvm.org/buildbot/#/builders/184/builds/12514)
[clang-aarch64-sve-vla-2stage](https://lab.llvm.org/buildbot/#/builders/198/builds/9849)

Others
[arc-builder](https://lab.llvm.org/buildbot/#/builders/164/builds/52197)
[bolt-x86_64-ubuntu-clang](https://lab.llvm.org/buildbot/#/builders/252/builds/9890)
[clang-with-lto-ubuntu](https://lab.llvm.org/buildbot/#/builders/124/builds/10736)
[clang-with-thin-lto-ubuntu](https://lab.llvm.org/buildbot/#/builders/67/builds/15879)
[clang-x64-windows-msvc](https://lab.llvm.org/buildbot/#/builders/123/builds/26469)
[lldb-aarch64-windows](https://lab.llvm.org/buildbot/#/builders/219/builds/11350)



https://github.com/llvm/llvm-project/pull/91893
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Added check for unexpanded pack in attribute [[assume]] (PR #91893)

2024-05-13 Thread via cfe-commits 

Sirraide wrote:

> Here are the builds
> 
> Mentioned in emails 
> [clang-aarch64-sve-vls](https://lab.llvm.org/buildbot/#/builders/184/builds/12514)
>  
> [clang-aarch64-sve-vla-2stage](https://lab.llvm.org/buildbot/#/builders/198/builds/9849)
> 
> Others 
> [arc-builder](https://lab.llvm.org/buildbot/#/builders/164/builds/52197) 
> [bolt-x86_64-ubuntu-clang](https://lab.llvm.org/buildbot/#/builders/252/builds/9890)
>  
> [clang-with-lto-ubuntu](https://lab.llvm.org/buildbot/#/builders/124/builds/10736)
>  
> [clang-with-thin-lto-ubuntu](https://lab.llvm.org/buildbot/#/builders/67/builds/15879)
>  
> [clang-x64-windows-msvc](https://lab.llvm.org/buildbot/#/builders/123/builds/26469)
>  
> [lldb-aarch64-windows](https://lab.llvm.org/buildbot/#/builders/219/builds/11350)

That’s an MLIR test which is entirely unrelated to any of this here, so you 
should be able to ignore that.

https://github.com/llvm/llvm-project/pull/91893
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Added check for unexpanded pack in attribute [[assume]] (PR #91893)

2024-05-13 Thread Azmat Yusuf via cfe-commits 

azmat-y wrote:

Thanks for confirming and also thanks for your help.

https://github.com/llvm/llvm-project/pull/91893
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits