[clang] [Clang] Remove parameter that shouldn't be there (PR #93086)

[Eli Friedman via cfe-commits]

efriedma-quic wrote:

Looks fine.

https://github.com/llvm/llvm-project/pull/93086
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Remove parameter that shouldn't be there (PR #93086)

[via cfe-commits]

llvmbot wrote:




@llvm/pr-subscribers-clang

Author: None (Sirraide)


Changes

The parameter of `getAddress()` was not being used, as I recall, and seems to 
have been removed in the meantime. Merging this w/o review since this is 
breaking builds.

---
Full diff: https://github.com/llvm/llvm-project/pull/93086.diff


1 Files Affected:

- (modified) clang/lib/CodeGen/CGExpr.cpp (+1-1) 


``diff
diff --git a/clang/lib/CodeGen/CGExpr.cpp b/clang/lib/CodeGen/CGExpr.cpp
index 4c4a42134dd4a..4072025376768 100644
--- a/clang/lib/CodeGen/CGExpr.cpp
+++ b/clang/lib/CodeGen/CGExpr.cpp
@@ -4701,7 +4701,7 @@ LValue CodeGenFunction::EmitLValueForLambdaField(const 
FieldDecl *Field,
 if (ThisTy != LambdaTy) {
   const CXXCastPath &BasePathArray = getContext().LambdaCastPaths.at(MD);
   Address Base = GetAddressOfBaseClass(
-  LambdaLV.getAddress(*this), ThisTy, BasePathArray.begin(),
+  LambdaLV.getAddress(), ThisTy, BasePathArray.begin(),
   BasePathArray.end(), /*NullCheckValue=*/false, SourceLocation());
   LambdaLV = MakeAddrLValue(Base, QualType{LambdaTy->getTypeForDecl(), 0});
 }

``




https://github.com/llvm/llvm-project/pull/93086
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Remove parameter that shouldn't be there (PR #93086)

[via cfe-commits]

https://github.com/Sirraide closed 
https://github.com/llvm/llvm-project/pull/93086
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Remove parameter that shouldn't be there (PR #93086)

[via cfe-commits]

https://github.com/Sirraide created 
https://github.com/llvm/llvm-project/pull/93086

The parameter of `getAddress()` was not being used, as I recall, and seems to 
have been removed in the meantime. Merging this w/o review since this is 
breaking builds.

>From c3d4bf3cf0e741d40d0d471a84bfaf53c15c7ad2 Mon Sep 17 00:00:00 2001
From: Sirraide 
Date: Wed, 22 May 2024 20:24:41 +0200
Subject: [PATCH] [Clang] Remove parameter that shouldn't be there

---
 clang/lib/CodeGen/CGExpr.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/clang/lib/CodeGen/CGExpr.cpp b/clang/lib/CodeGen/CGExpr.cpp
index 4c4a42134dd4a..4072025376768 100644
--- a/clang/lib/CodeGen/CGExpr.cpp
+++ b/clang/lib/CodeGen/CGExpr.cpp
@@ -4701,7 +4701,7 @@ LValue CodeGenFunction::EmitLValueForLambdaField(const 
FieldDecl *Field,
 if (ThisTy != LambdaTy) {
   const CXXCastPath &BasePathArray = getContext().LambdaCastPaths.at(MD);
   Address Base = GetAddressOfBaseClass(
-  LambdaLV.getAddress(*this), ThisTy, BasePathArray.begin(),
+  LambdaLV.getAddress(), ThisTy, BasePathArray.begin(),
   BasePathArray.end(), /*NullCheckValue=*/false, SourceLocation());
   LambdaLV = MakeAddrLValue(Base, QualType{LambdaTy->getTypeForDecl(), 0});
 }

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits