[clang] [Cygwin] Reduced number of inline elements of CallArgList. (PR #74977)

[徐持恒 Xu Chiheng via cfe-commits]

https://github.com/xu-chiheng edited 
https://github.com/llvm/llvm-project/pull/74977
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Cygwin] Reduced number of inline elements of CallArgList. (PR #74977)

[徐持恒 Xu Chiheng via cfe-commits]

https://github.com/xu-chiheng updated 
https://github.com/llvm/llvm-project/pull/74977

From 36031b0f4940d31edf026882ec47cd4bee90e324 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=E5=BE=90=E6=8C=81=E6=81=92=20Xu=20Chiheng?=
 
Date: Sun, 10 Dec 2023 14:52:29 +0800
Subject: [PATCH] 1

---
 clang/lib/CodeGen/CGCall.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/clang/lib/CodeGen/CGCall.h b/clang/lib/CodeGen/CGCall.h
index 1c0d15dc932ad8..e96a7edd2a511c 100644
--- a/clang/lib/CodeGen/CGCall.h
+++ b/clang/lib/CodeGen/CGCall.h
@@ -255,7 +255,7 @@ struct CallArg {
 
 /// CallArgList - Type for representing both the value and type of
 /// arguments in a call.
-class CallArgList : public SmallVector {
+class CallArgList : public SmallVector {
 public:
   CallArgList() = default;
 

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Cygwin] Reduced number of inline elements of CallArgList. (PR #74977)

[徐持恒 Xu Chiheng via cfe-commits]

https://github.com/xu-chiheng reopened 
https://github.com/llvm/llvm-project/pull/74977
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Cygwin] Reduced number of inline elements of CallArgList. (PR #74977)

[徐持恒 Xu Chiheng via cfe-commits]

https://github.com/xu-chiheng closed 
https://github.com/llvm/llvm-project/pull/74977
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Cygwin] Reduced number of inline elements of CallArgList. (PR #74977)

[徐持恒 Xu Chiheng via cfe-commits]

xu-chiheng wrote:

As commit 49b27b150b97c190dedf8b45bf991c4b811ed953 2023-12-09, this patch is 
not needed.


https://github.com/llvm/llvm-project/pull/74977
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Cygwin] Reduced number of inline elements of CallArgList. (PR #74977)

[徐持恒 Xu Chiheng via cfe-commits]

xu-chiheng wrote:

> Adding workarounds to LLVM for host compiler bugs is something we do from 
> time to time, but any such workarounds need to be clearly documented in the 
> source code, and as narrowly targeted as possible (for example, under an 
> `#ifdef __CYGWIN__`).
> 
> Since this is an issue with the latest version of gcc, please also report it 
> to the gcc bugtracker.

As commit 49b27b150b97c190dedf8b45bf991c4b811ed953 2023-12-09, this patch is 
not needed.


https://github.com/llvm/llvm-project/pull/74977
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Cygwin] Reduced number of inline elements of CallArgList. (PR #74977)

[徐持恒 Xu Chiheng via cfe-commits]

https://github.com/xu-chiheng edited 
https://github.com/llvm/llvm-project/pull/74977
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Cygwin] Reduced number of inline elements of CallArgList. (PR #74977)

[Eli Friedman via cfe-commits]

efriedma-quic wrote:

Adding workarounds to LLVM for host compiler bugs is something we do from time 
to time, but any such workarounds need to be clearly documented in the source 
code, and as narrowly targeted as possible (for example, under an `#ifdef 
__CYGWIN__`).

Since this is an issue with the latest version of gcc, please also report it to 
the gcc bugtracker.

https://github.com/llvm/llvm-project/pull/74977
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Cygwin] Reduced number of inline elements of CallArgList. (PR #74977)

[徐持恒 Xu Chiheng via cfe-commits]

xu-chiheng wrote:

> > I have build scripts and patches at: https://github.com/xu-chiheng/Note
> > […](#)
> > On Mon, Dec 11, 2023 at 11:25 PM Yingchi Long _**@**_._**> wrote: When 
> > bootstrapping Clang on Cygwin, there are various weird problems. What are 
> > those "weired problems" Reducing the size of CallArgList solve them all. 
> > And why reduce the size of CallArgList solve them all? Could you kindly 
> > elaborate? — Reply to this email directly, view it on GitHub <[#74977 
> > (comment)](https://github.com/llvm/llvm-project/pull/74977#issuecomment-1850302699)>,
> >  or unsubscribe 
> > https://github.com/notifications/unsubscribe-auth/AA5RCUGAE5BNGG5HBCLW66DYI4QXJAVCNFSM6ABAOLH3Y6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNJQGMYDENRZHE
> >  . You are receiving this because you authored the thread.Message ID: 
> > _**@**_.**_>
> 
> I see, can you just paste logs(e.g. compiler warnings) here or provide a 
> small reproducer? (e.g step-by-step instructions to reproduce the issue).
> 
> I think it will be nice if the patch really improves llvm portability, but it 
> is hard to reproduce bugs via a set of undocumented scripts & unknown build 
> environments.

No, currently. It was several months ago.  I don't remember the details. 
Basically speaking,  it seems that some fields of CallArgList or other types 
are overwritten, because CallArgList size exceed an unknown limit, leading to 
various weird errors and failed bootstrap.  This need to be invesgated, but I'm 
not very familiar with the code. 

This was discovered by bisect. Clang 16 can bootstrap without this patch.


https://github.com/llvm/llvm-project/pull/74977
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Cygwin] Reduced number of inline elements of CallArgList. (PR #74977)

[Yingchi Long via cfe-commits]

inclyc wrote:

> I have build scripts and patches at: https://github.com/xu-chiheng/Note
> […](#)
> On Mon, Dec 11, 2023 at 11:25 PM Yingchi Long ***@***.***> wrote: When 
> bootstrapping Clang on Cygwin, there are various weird problems. What are 
> those "weired problems" Reducing the size of CallArgList solve them all. And 
> why reduce the size of CallArgList solve them all? Could you kindly 
> elaborate? — Reply to this email directly, view it on GitHub <[#74977 
> (comment)](https://github.com/llvm/llvm-project/pull/74977#issuecomment-1850302699)>,
>  or unsubscribe 
> 
>  . You are receiving this because you authored the thread.Message ID: 
> ***@***.***>

I see, can you just paste logs(e.g. compiler warnings) here or provide a small 
reproducer? (e.g step-by-step instructions to reproduce the issue).

I think it will be nice if the patch really improves llvm portability, but it 
is hard to reproduce bugs via a set of undocumented scripts & unknown build 
environments.

https://github.com/llvm/llvm-project/pull/74977
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Cygwin] Reduced number of inline elements of CallArgList. (PR #74977)

[徐持恒 Xu Chiheng via cfe-commits]

xu-chiheng wrote:

I have build scripts and patches at:
https://github.com/xu-chiheng/Note

On Mon, Dec 11, 2023 at 11:25 PM Yingchi Long ***@***.***>
wrote:

> When bootstrapping Clang on Cygwin, there are various weird problems.
>
> What are those "weired problems"
>
> Reducing the size of CallArgList solve them all.
>
> And why reduce the size of CallArgList solve them all? Could you kindly
> elaborate?
>
> —
> Reply to this email directly, view it on GitHub
> ,
> or unsubscribe
> 
> .
> You are receiving this because you authored the thread.Message ID:
> ***@***.***>
>


https://github.com/llvm/llvm-project/pull/74977
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Cygwin] Reduced number of inline elements of CallArgList. (PR #74977)

[Yingchi Long via cfe-commits]

inclyc wrote:

> When bootstrapping Clang on Cygwin, there are various weird problems.

What are those "weired problems"

> Reducing the size of CallArgList solve them all.

And why reduce the size of `CallArgList` solve them all? Could you kindly 
elaborate?

https://github.com/llvm/llvm-project/pull/74977
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Cygwin] Reduced number of inline elements of CallArgList. (PR #74977)

[徐持恒 Xu Chiheng via cfe-commits]

xu-chiheng wrote:

> NFC, and

I have build scripts at https://github.com/xu-chiheng/Note
When bootstrapping Clang on Cygwin, there are various weird problems. 
Reducing the size of CallArgList solve them all.



https://github.com/llvm/llvm-project/pull/74977
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Cygwin] Reduced number of inline elements of CallArgList. (PR #74977)

[Yingchi Long via cfe-commits]

https://github.com/inclyc commented:

> This fix bootstraping on Cygwin, using GCC 13.2.0 as stage 0 compiler.
It seems that the size of CallArgList can't exceed an unknown limit.

How about paste some logs here? This change seems to be completely NFC, and I 
suppose it shall work for GCC 13?

https://github.com/llvm/llvm-project/pull/74977
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Cygwin] Reduced number of inline elements of CallArgList. (PR #74977)

[徐持恒 Xu Chiheng via cfe-commits]

xu-chiheng wrote:

> Just FYI submitting lots of PRs with all of them having commits with a commit 
> message of 1 is not going to go anywhere. They need to be revised with proper 
> meaningful commit messages.

This fix bootstraping on Cygwin, using GCC 13.2.0 as stage 0 compiler.
It seems that the size of CallArgList can't exceed an unknown limit.


https://github.com/llvm/llvm-project/pull/74977
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Cygwin] Reduced number of inline elements of CallArgList. (PR #74977)

[Brad Smith via cfe-commits]

brad0 wrote:

Just FYI submitting lots of PRs with all of them having commits with a commit 
message of 1 is not going to go anywhere. They need to be revised with proper 
meaningful commit messages.

https://github.com/llvm/llvm-project/pull/74977
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Cygwin] Reduced number of inline elements of CallArgList. (PR #74977)

[via cfe-commits]

llvmbot wrote:




@llvm/pr-subscribers-clang-codegen

Author: 徐持恒 Xu Chiheng (xu-chiheng)


Changes

This fix bootstraping on Cygwin, using GCC 13.2.0 as stage 0 compiler.
It seems that the size of CallArgList can't exceed an unknown limit.  


---
Full diff: https://github.com/llvm/llvm-project/pull/74977.diff


1 Files Affected:

- (modified) clang/lib/CodeGen/CGCall.h (+1-1) 


``diff
diff --git a/clang/lib/CodeGen/CGCall.h b/clang/lib/CodeGen/CGCall.h
index aee86a3242fd3f..5c181b8c00867f 100644
--- a/clang/lib/CodeGen/CGCall.h
+++ b/clang/lib/CodeGen/CGCall.h
@@ -254,7 +254,7 @@ struct CallArg {
 
 /// CallArgList - Type for representing both the value and type of
 /// arguments in a call.
-class CallArgList : public SmallVector {
+class CallArgList : public SmallVector {
 public:
   CallArgList() = default;
 

``




https://github.com/llvm/llvm-project/pull/74977
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Cygwin] Reduced number of inline elements of CallArgList. (PR #74977)

[via cfe-commits]

llvmbot wrote:




@llvm/pr-subscribers-clang

Author: 徐持恒 Xu Chiheng (xu-chiheng)


Changes

This fix bootstraping on Cygwin, using GCC 13.2.0 as stage 0 compiler.
It seems that the size of CallArgList can't exceed an unknown limit.  


---
Full diff: https://github.com/llvm/llvm-project/pull/74977.diff


1 Files Affected:

- (modified) clang/lib/CodeGen/CGCall.h (+1-1) 


``diff
diff --git a/clang/lib/CodeGen/CGCall.h b/clang/lib/CodeGen/CGCall.h
index aee86a3242fd3f..5c181b8c00867f 100644
--- a/clang/lib/CodeGen/CGCall.h
+++ b/clang/lib/CodeGen/CGCall.h
@@ -254,7 +254,7 @@ struct CallArg {
 
 /// CallArgList - Type for representing both the value and type of
 /// arguments in a call.
-class CallArgList : public SmallVector {
+class CallArgList : public SmallVector {
 public:
   CallArgList() = default;
 

``




https://github.com/llvm/llvm-project/pull/74977
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Cygwin] Reduced number of inline elements of CallArgList. (PR #74977)

[徐持恒 Xu Chiheng via cfe-commits]

https://github.com/xu-chiheng created 
https://github.com/llvm/llvm-project/pull/74977

This fix bootstraping on Cygwin, using GCC 13.2.0 as stage 0 compiler.
It seems that the size of CallArgList can't exceed an unknown limit.  


From 68400fd63fd90703bb092d8f08f6c8cb7289fbe1 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=E5=BE=90=E6=8C=81=E6=81=92=20Xu=20Chiheng?=
 
Date: Sun, 10 Dec 2023 14:52:29 +0800
Subject: [PATCH] 1

---
 clang/lib/CodeGen/CGCall.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/clang/lib/CodeGen/CGCall.h b/clang/lib/CodeGen/CGCall.h
index aee86a3242fd3..5c181b8c00867 100644
--- a/clang/lib/CodeGen/CGCall.h
+++ b/clang/lib/CodeGen/CGCall.h
@@ -254,7 +254,7 @@ struct CallArg {
 
 /// CallArgList - Type for representing both the value and type of
 /// arguments in a call.
-class CallArgList : public SmallVector {
+class CallArgList : public SmallVector {
 public:
   CallArgList() = default;
 

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits