[clang] [Flang] responds to Clang Tidy feedback (PR #87847)

2024-04-10 Thread Christopher Di Bella via cfe-commits 

https://github.com/cjdb closed https://github.com/llvm/llvm-project/pull/87847
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Flang] responds to Clang Tidy feedback (PR #87847)

2024-04-10 Thread Jordan Rupprecht via cfe-commits 

https://github.com/rupprecht approved this pull request.


https://github.com/llvm/llvm-project/pull/87847
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Flang] responds to Clang Tidy feedback (PR #87847)

2024-04-10 Thread Jordan Rupprecht via cfe-commits 

https://github.com/rupprecht edited 
https://github.com/llvm/llvm-project/pull/87847
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Flang] responds to Clang Tidy feedback (PR #87847)

2024-04-10 Thread Christopher Di Bella via cfe-commits 

https://github.com/cjdb updated https://github.com/llvm/llvm-project/pull/87847

>From b8e67dfae63ee64753724dba8735799b39f4fcc0 Mon Sep 17 00:00:00 2001
From: Christopher Di Bella 
Date: Sat, 6 Apr 2024 00:13:29 +
Subject: [PATCH 1/2] [Flang] responds to Clang Tidy feedback

Line 267: performance-unnecessary-copy-initialization
Line 592: readability-container-size-empty
---
 clang/lib/Driver/ToolChains/Flang.cpp | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/clang/lib/Driver/ToolChains/Flang.cpp 
b/clang/lib/Driver/ToolChains/Flang.cpp
index 2c83f70eb7887e..45d86c2f9b0ad4 100644
--- a/clang/lib/Driver/ToolChains/Flang.cpp
+++ b/clang/lib/Driver/ToolChains/Flang.cpp
@@ -264,7 +264,7 @@ static void addVSDefines(const ToolChain , const ArgList 
,
   CmdArgs.push_back(Args.MakeArgString("-D_MSC_FULL_VER=" + Twine(ver)));
   CmdArgs.push_back(Args.MakeArgString("-D_WIN32"));
 
-  llvm::Triple triple = TC.getTriple();
+  const llvm::Triple& triple = TC.getTriple();
   if (triple.isAArch64()) {
 CmdArgs.push_back("-D_M_ARM64=1");
   } else if (triple.isX86() && triple.isArch32Bit()) {
@@ -589,7 +589,7 @@ static void addFloatingPointOptions(const Driver , const 
ArgList ,
 
   if (!HonorINFs && !HonorNaNs && AssociativeMath && ReciprocalMath &&
   ApproxFunc && !SignedZeros &&
-  (FPContract == "fast" || FPContract == "")) {
+  (FPContract == "fast" || FPContract.empty())) {
 CmdArgs.push_back("-ffast-math");
 return;
   }

>From 49c075bc42b69218a297221db251f35d123fd170 Mon Sep 17 00:00:00 2001
From: Christopher Di Bella 
Date: Sat, 6 Apr 2024 00:18:28 +
Subject: [PATCH 2/2] formatting fix

---
 clang/lib/Driver/ToolChains/Flang.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/clang/lib/Driver/ToolChains/Flang.cpp 
b/clang/lib/Driver/ToolChains/Flang.cpp
index 45d86c2f9b0ad4..98611667180798 100644
--- a/clang/lib/Driver/ToolChains/Flang.cpp
+++ b/clang/lib/Driver/ToolChains/Flang.cpp
@@ -264,7 +264,7 @@ static void addVSDefines(const ToolChain , const ArgList 
,
   CmdArgs.push_back(Args.MakeArgString("-D_MSC_FULL_VER=" + Twine(ver)));
   CmdArgs.push_back(Args.MakeArgString("-D_WIN32"));
 
-  const llvm::Triple& triple = TC.getTriple();
+  const llvm::Triple  = TC.getTriple();
   if (triple.isAArch64()) {
 CmdArgs.push_back("-D_M_ARM64=1");
   } else if (triple.isX86() && triple.isArch32Bit()) {

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Flang] responds to Clang Tidy feedback (PR #87847)

2024-04-05 Thread Christopher Di Bella via cfe-commits 

https://github.com/cjdb updated https://github.com/llvm/llvm-project/pull/87847

>From b8e67dfae63ee64753724dba8735799b39f4fcc0 Mon Sep 17 00:00:00 2001
From: Christopher Di Bella 
Date: Sat, 6 Apr 2024 00:13:29 +
Subject: [PATCH 1/2] [Flang] responds to Clang Tidy feedback

Line 267: performance-unnecessary-copy-initialization
Line 592: readability-container-size-empty
---
 clang/lib/Driver/ToolChains/Flang.cpp | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/clang/lib/Driver/ToolChains/Flang.cpp 
b/clang/lib/Driver/ToolChains/Flang.cpp
index 2c83f70eb7887e..45d86c2f9b0ad4 100644
--- a/clang/lib/Driver/ToolChains/Flang.cpp
+++ b/clang/lib/Driver/ToolChains/Flang.cpp
@@ -264,7 +264,7 @@ static void addVSDefines(const ToolChain , const ArgList 
,
   CmdArgs.push_back(Args.MakeArgString("-D_MSC_FULL_VER=" + Twine(ver)));
   CmdArgs.push_back(Args.MakeArgString("-D_WIN32"));
 
-  llvm::Triple triple = TC.getTriple();
+  const llvm::Triple& triple = TC.getTriple();
   if (triple.isAArch64()) {
 CmdArgs.push_back("-D_M_ARM64=1");
   } else if (triple.isX86() && triple.isArch32Bit()) {
@@ -589,7 +589,7 @@ static void addFloatingPointOptions(const Driver , const 
ArgList ,
 
   if (!HonorINFs && !HonorNaNs && AssociativeMath && ReciprocalMath &&
   ApproxFunc && !SignedZeros &&
-  (FPContract == "fast" || FPContract == "")) {
+  (FPContract == "fast" || FPContract.empty())) {
 CmdArgs.push_back("-ffast-math");
 return;
   }

>From 49c075bc42b69218a297221db251f35d123fd170 Mon Sep 17 00:00:00 2001
From: Christopher Di Bella 
Date: Sat, 6 Apr 2024 00:18:28 +
Subject: [PATCH 2/2] formatting fix

---
 clang/lib/Driver/ToolChains/Flang.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/clang/lib/Driver/ToolChains/Flang.cpp 
b/clang/lib/Driver/ToolChains/Flang.cpp
index 45d86c2f9b0ad4..98611667180798 100644
--- a/clang/lib/Driver/ToolChains/Flang.cpp
+++ b/clang/lib/Driver/ToolChains/Flang.cpp
@@ -264,7 +264,7 @@ static void addVSDefines(const ToolChain , const ArgList 
,
   CmdArgs.push_back(Args.MakeArgString("-D_MSC_FULL_VER=" + Twine(ver)));
   CmdArgs.push_back(Args.MakeArgString("-D_WIN32"));
 
-  const llvm::Triple& triple = TC.getTriple();
+  const llvm::Triple  = TC.getTriple();
   if (triple.isAArch64()) {
 CmdArgs.push_back("-D_M_ARM64=1");
   } else if (triple.isX86() && triple.isArch32Bit()) {

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Flang] responds to Clang Tidy feedback (PR #87847)

2024-04-05 Thread via cfe-commits 

github-actions[bot] wrote:




:warning: C/C++ code formatter, clang-format found issues in your code. 
:warning:



You can test this locally with the following command:


``bash
git-clang-format --diff 8bd391457fbd5108610557efdb26c2397aa0bd24 
b8e67dfae63ee64753724dba8735799b39f4fcc0 -- 
clang/lib/Driver/ToolChains/Flang.cpp
``





View the diff from clang-format here.


``diff
diff --git a/clang/lib/Driver/ToolChains/Flang.cpp 
b/clang/lib/Driver/ToolChains/Flang.cpp
index 45d86c2f9b..9861166718 100644
--- a/clang/lib/Driver/ToolChains/Flang.cpp
+++ b/clang/lib/Driver/ToolChains/Flang.cpp
@@ -264,7 +264,7 @@ static void addVSDefines(const ToolChain , const ArgList 
,
   CmdArgs.push_back(Args.MakeArgString("-D_MSC_FULL_VER=" + Twine(ver)));
   CmdArgs.push_back(Args.MakeArgString("-D_WIN32"));
 
-  const llvm::Triple& triple = TC.getTriple();
+  const llvm::Triple  = TC.getTriple();
   if (triple.isAArch64()) {
 CmdArgs.push_back("-D_M_ARM64=1");
   } else if (triple.isX86() && triple.isArch32Bit()) {

``




https://github.com/llvm/llvm-project/pull/87847
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Flang] responds to Clang Tidy feedback (PR #87847)

2024-04-05 Thread via cfe-commits 

llvmbot wrote:




@llvm/pr-subscribers-clang

Author: Christopher Di Bella (cjdb)


Changes

Line 267: performance-unnecessary-copy-initialization
Line 592: readability-container-size-empty

---
Full diff: https://github.com/llvm/llvm-project/pull/87847.diff


1 Files Affected:

- (modified) clang/lib/Driver/ToolChains/Flang.cpp (+2-2) 


``diff
diff --git a/clang/lib/Driver/ToolChains/Flang.cpp 
b/clang/lib/Driver/ToolChains/Flang.cpp
index 2c83f70eb7887e..45d86c2f9b0ad4 100644
--- a/clang/lib/Driver/ToolChains/Flang.cpp
+++ b/clang/lib/Driver/ToolChains/Flang.cpp
@@ -264,7 +264,7 @@ static void addVSDefines(const ToolChain , const ArgList 
,
   CmdArgs.push_back(Args.MakeArgString("-D_MSC_FULL_VER=" + Twine(ver)));
   CmdArgs.push_back(Args.MakeArgString("-D_WIN32"));
 
-  llvm::Triple triple = TC.getTriple();
+  const llvm::Triple& triple = TC.getTriple();
   if (triple.isAArch64()) {
 CmdArgs.push_back("-D_M_ARM64=1");
   } else if (triple.isX86() && triple.isArch32Bit()) {
@@ -589,7 +589,7 @@ static void addFloatingPointOptions(const Driver , const 
ArgList ,
 
   if (!HonorINFs && !HonorNaNs && AssociativeMath && ReciprocalMath &&
   ApproxFunc && !SignedZeros &&
-  (FPContract == "fast" || FPContract == "")) {
+  (FPContract == "fast" || FPContract.empty())) {
 CmdArgs.push_back("-ffast-math");
 return;
   }

``




https://github.com/llvm/llvm-project/pull/87847
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Flang] responds to Clang Tidy feedback (PR #87847)

2024-04-05 Thread Christopher Di Bella via cfe-commits 

https://github.com/cjdb created https://github.com/llvm/llvm-project/pull/87847

Line 267: performance-unnecessary-copy-initialization
Line 592: readability-container-size-empty

>From b8e67dfae63ee64753724dba8735799b39f4fcc0 Mon Sep 17 00:00:00 2001
From: Christopher Di Bella 
Date: Sat, 6 Apr 2024 00:13:29 +
Subject: [PATCH] [Flang] responds to Clang Tidy feedback

Line 267: performance-unnecessary-copy-initialization
Line 592: readability-container-size-empty
---
 clang/lib/Driver/ToolChains/Flang.cpp | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/clang/lib/Driver/ToolChains/Flang.cpp 
b/clang/lib/Driver/ToolChains/Flang.cpp
index 2c83f70eb7887e..45d86c2f9b0ad4 100644
--- a/clang/lib/Driver/ToolChains/Flang.cpp
+++ b/clang/lib/Driver/ToolChains/Flang.cpp
@@ -264,7 +264,7 @@ static void addVSDefines(const ToolChain , const ArgList 
,
   CmdArgs.push_back(Args.MakeArgString("-D_MSC_FULL_VER=" + Twine(ver)));
   CmdArgs.push_back(Args.MakeArgString("-D_WIN32"));
 
-  llvm::Triple triple = TC.getTriple();
+  const llvm::Triple& triple = TC.getTriple();
   if (triple.isAArch64()) {
 CmdArgs.push_back("-D_M_ARM64=1");
   } else if (triple.isX86() && triple.isArch32Bit()) {
@@ -589,7 +589,7 @@ static void addFloatingPointOptions(const Driver , const 
ArgList ,
 
   if (!HonorINFs && !HonorNaNs && AssociativeMath && ReciprocalMath &&
   ApproxFunc && !SignedZeros &&
-  (FPContract == "fast" || FPContract == "")) {
+  (FPContract == "fast" || FPContract.empty())) {
 CmdArgs.push_back("-ffast-math");
 return;
   }

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits