[clang] [Fuchsia] Disable libcxx timezone database (PR #65870)

2023-09-10 Thread Alex Brachet via cfe-commits 

https://github.com/abrachet closed 
https://github.com/llvm/llvm-project/pull/65870
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Fuchsia] Disable libcxx timezone database (PR #65870)

2023-09-09 Thread Petr Hosek via cfe-commits 

https://github.com/petrhosek approved this pull request.


https://github.com/llvm/llvm-project/pull/65870
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Fuchsia] Disable libcxx timezone database (PR #65870)

2023-09-09 Thread via cfe-commits 

llvmbot wrote:

@llvm/pr-subscribers-clang


Changes

tzdb is currently broken when cross compiling from non Linux to Linux. Lets 
just disable it totally in our toolchain for now. We should remove this when 
#65859 lands.
--
Full diff: https://github.com/llvm/llvm-project/pull/65870.diff

1 Files Affected:

- (modified) clang/cmake/caches/Fuchsia-stage2.cmake (+3) 



diff --git a/clang/cmake/caches/Fuchsia-stage2.cmake 
b/clang/cmake/caches/Fuchsia-stage2.cmake
index 4890040b1b6a2b4..10e5cacf51c4b7b 100644
--- a/clang/cmake/caches/Fuchsia-stage2.cmake
+++ b/clang/cmake/caches/Fuchsia-stage2.cmake
@@ -181,6 +181,9 @@ foreach(target 
aarch64-unknown-linux-gnu;armv7-unknown-linux-gnueabihf;i386-unkn
 set(RUNTIMES_${target}_LLVM_TOOLS_DIR "${CMAKE_BINARY_DIR}/bin" CACHE BOOL 
"")
 set(RUNTIMES_${target}_LLVM_ENABLE_RUNTIMES 
"compiler-rt;libcxx;libcxxabi;libunwind" CACHE STRING "")
 
+# TODO: Remove this once #65859 lands.
+set(RUNTIMES_${target}_LIBCXX_ENABLE_TIME_ZONE_DATABASE OFF CACHE STRING 
"")
+
 # Use .build-id link.
 list(APPEND RUNTIME_BUILD_ID_LINK "${target}")
   endif()




https://github.com/llvm/llvm-project/pull/65870
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Fuchsia] Disable libcxx timezone database (PR #65870)

2023-09-09 Thread via cfe-commits 

https://github.com/llvmbot labeled 
https://github.com/llvm/llvm-project/pull/65870
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Fuchsia] Disable libcxx timezone database (PR #65870)

2023-09-09 Thread Alex Brachet via cfe-commits 

https://github.com/abrachet review_requested 
https://github.com/llvm/llvm-project/pull/65870
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Fuchsia] Disable libcxx timezone database (PR #65870)

2023-09-09 Thread Alex Brachet via cfe-commits 

https://github.com/abrachet review_requested 
https://github.com/llvm/llvm-project/pull/65870
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Fuchsia] Disable libcxx timezone database (PR #65870)

2023-09-09 Thread Alex Brachet via cfe-commits 

https://github.com/abrachet created 
https://github.com/llvm/llvm-project/pull/65870:

tzdb is currently broken when cross compiling from non Linux to Linux. Lets 
just disable it totally in our toolchain for now. We should remove this when 
#65859 lands.

>From b75d844d09076f2a7f170454782662cfebd7d16e Mon Sep 17 00:00:00 2001
From: Alex Brachet 
Date: Sat, 9 Sep 2023 23:16:21 -0400
Subject: [PATCH] [Fuchsia] Disable libcxx timezone database

tzdb is currently broken when cross compiling from non Linux
to Linux. Lets just disable it totally in our toolchain for now.
We should remove this when #65859 lands.
---
 clang/cmake/caches/Fuchsia-stage2.cmake | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/clang/cmake/caches/Fuchsia-stage2.cmake 
b/clang/cmake/caches/Fuchsia-stage2.cmake
index 4890040b1b6a2b4..10e5cacf51c4b7b 100644
--- a/clang/cmake/caches/Fuchsia-stage2.cmake
+++ b/clang/cmake/caches/Fuchsia-stage2.cmake
@@ -181,6 +181,9 @@ foreach(target 
aarch64-unknown-linux-gnu;armv7-unknown-linux-gnueabihf;i386-unkn
 set(RUNTIMES_${target}_LLVM_TOOLS_DIR "${CMAKE_BINARY_DIR}/bin" CACHE BOOL 
"")
 set(RUNTIMES_${target}_LLVM_ENABLE_RUNTIMES 
"compiler-rt;libcxx;libcxxabi;libunwind" CACHE STRING "")
 
+# TODO: Remove this once #65859 lands.
+set(RUNTIMES_${target}_LIBCXX_ENABLE_TIME_ZONE_DATABASE OFF CACHE STRING 
"")
+
 # Use .build-id link.
 list(APPEND RUNTIME_BUILD_ID_LINK "${target}")
   endif()

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits