[clang] [MinGW] MinGW Value.h (PR #74982)

[Anton Korobeynikov via cfe-commits]

asl wrote:

Will you please provide meaningful description in the PRs from now on? Since 
this is not the first time you've been asked to do this and you are ignoring 
these requests I'm closing this PR. Please do not use PRs to debug your own 
issues, this is wasting both time of reviewers as well as CI time.

Feel free to reopen when / if you will be able to fix these issues.

For more information about proper way to contribute to LLVM consider 
familiarizing yourself with:

 * https://llvm.org/docs/Contributing.html#how-to-submit-a-patch
 * https://llvm.org/docs/CodeReview.html
Thanks.

https://github.com/llvm/llvm-project/pull/74982
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [MinGW] MinGW Value.h (PR #74982)

[Anton Korobeynikov via cfe-commits]

https://github.com/asl closed https://github.com/llvm/llvm-project/pull/74982
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [MinGW] MinGW Value.h (PR #74982)

[徐持恒 Xu Chiheng via cfe-commits]

https://github.com/xu-chiheng updated 
https://github.com/llvm/llvm-project/pull/74982

From 79391542d94910efe25f09374ef241456609dbde Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=E5=BE=90=E6=8C=81=E6=81=92=20Xu=20Chiheng?=
 
Date: Sun, 10 Dec 2023 15:16:38 +0800
Subject: [PATCH] 1

---
 clang/include/clang/Interpreter/Value.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/clang/include/clang/Interpreter/Value.h 
b/clang/include/clang/Interpreter/Value.h
index c380cd91550def..46e827f3ec283d 100644
--- a/clang/include/clang/Interpreter/Value.h
+++ b/clang/include/clang/Interpreter/Value.h
@@ -52,7 +52,8 @@ class ASTContext;
 class Interpreter;
 class QualType;
 
-#if defined(_WIN32)
+#if defined(LLVM_BUILD_LLVM_DYLIB) || defined(LLVM_BUILD_SHARED_LIBS)
+#if defined(_WIN32) && !(defined(__CYGWIN__) || defined(__MINGW32__))
 // REPL_EXTERNAL_VISIBILITY are symbols that we need to be able to locate
 // at runtime. On Windows, this requires them to be exported from any of the
 // modules loaded at runtime. Marking them as dllexport achieves this; both
@@ -63,7 +64,6 @@ class QualType;
 // statically linked into an EXE, it makes sure that they're exported.
 #define REPL_EXTERNAL_VISIBILITY __declspec(dllexport)
 #elif __has_attribute(visibility)
-#if defined(LLVM_BUILD_LLVM_DYLIB) || defined(LLVM_BUILD_SHARED_LIBS)
 #define REPL_EXTERNAL_VISIBILITY __attribute__((visibility("default")))
 #else
 #define REPL_EXTERNAL_VISIBILITY

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [MinGW] MinGW Value.h (PR #74982)

[徐持恒 Xu Chiheng via cfe-commits]

https://github.com/xu-chiheng edited 
https://github.com/llvm/llvm-project/pull/74982
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits