[clang] [NFC] Fix hasQualifier comment (PR #90485)
https://github.com/cor3ntin closed https://github.com/llvm/llvm-project/pull/90485 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang] [NFC] Fix hasQualifier comment (PR #90485)
https://github.com/shafik approved this pull request. LGTM, thank you for the documentation fix. https://github.com/llvm/llvm-project/pull/90485 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang] [NFC] Fix hasQualifier comment (PR #90485)
https://github.com/sousajo-cc edited https://github.com/llvm/llvm-project/pull/90485 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang] [NFC] Fix hasQualifier comment (PR #90485)
sousajo-cc wrote: fixes https://github.com/llvm/llvm-project/issues/90472 https://github.com/llvm/llvm-project/pull/90485 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang] [NFC] Fix hasQualifier comment (PR #90485)
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Jorge Pinto Sousa (sousajo-cc)
Changes
operator bool from NestedNameSpecifierLoc and
member function hasQualifier both do the same thing, returning true iff the
private data member Qualifier is not nullptr, so clearly one of the comments is
wrong, and in this case it is the second one.
---
Full diff: https://github.com/llvm/llvm-project/pull/90485.diff
1 Files Affected:
- (modified) clang/include/clang/AST/NestedNameSpecifier.h (+1-1)
``diff
diff --git a/clang/include/clang/AST/NestedNameSpecifier.h
b/clang/include/clang/AST/NestedNameSpecifier.h
index 3b6cf972118509..b4ccfa710e5166 100644
--- a/clang/include/clang/AST/NestedNameSpecifier.h
+++ b/clang/include/clang/AST/NestedNameSpecifier.h
@@ -266,7 +266,7 @@ class NestedNameSpecifierLoc {
explicit operator bool() const { return Qualifier; }
/// Evaluates true when this nested-name-specifier location is
- /// empty.
+ /// non-empty.
bool hasQualifier() const { return Qualifier; }
/// Retrieve the nested-name-specifier to which this instance
``
https://github.com/llvm/llvm-project/pull/90485
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang] [NFC] Fix hasQualifier comment (PR #90485)
https://github.com/sousajo-cc created
https://github.com/llvm/llvm-project/pull/90485
operator bool from NestedNameSpecifierLoc and
member function hasQualifier both do the same thing, returning true iff the
private data member Qualifier is not nullptr, so clearly one of the comments is
wrong, and in this case it is the second one.
>From 07f6f79bd7364a59a5024f700ead6da5aca505da Mon Sep 17 00:00:00 2001
From: sousajo-cc
Date: Mon, 29 Apr 2024 17:25:05 +0200
Subject: [PATCH] [NFC] Fix hasQualifier comment
operator bool from NestedNameSpecifierLoc and
member function hasQualifier both do the same thing,
returning true iff the private data member Qualifier
is not nullptr, so clearly one of the comments is wrong,
and in this case it is the second one.
---
clang/include/clang/AST/NestedNameSpecifier.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/clang/include/clang/AST/NestedNameSpecifier.h
b/clang/include/clang/AST/NestedNameSpecifier.h
index 3b6cf972118509..b4ccfa710e5166 100644
--- a/clang/include/clang/AST/NestedNameSpecifier.h
+++ b/clang/include/clang/AST/NestedNameSpecifier.h
@@ -266,7 +266,7 @@ class NestedNameSpecifierLoc {
explicit operator bool() const { return Qualifier; }
/// Evaluates true when this nested-name-specifier location is
- /// empty.
+ /// non-empty.
bool hasQualifier() const { return Qualifier; }
/// Retrieve the nested-name-specifier to which this instance
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
