[clang] [X86][Driver] Move mno-gather/mno-scatter from m_x86_Features_Group to m_Group. NFCI (PR #65457)
https://github.com/phoebewang closed https://github.com/llvm/llvm-project/pull/65457 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang] [X86][Driver] Move mno-gather/mno-scatter from m_x86_Features_Group to m_Group. NFCI (PR #65457)
https://github.com/phoebewang edited https://github.com/llvm/llvm-project/pull/65457 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang] [X86][Driver] Move mno-gather/mno-scatter from m_x86_Features_Group yo m_Group. NFCI (PR #65457)
https://github.com/XinWang10 approved this pull request. LGTM, could work on my side. https://github.com/llvm/llvm-project/pull/65457 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang] [X86][Driver] Move mno-gather/mno-scatter from m_x86_Features_Group yo m_Group. NFCI (PR #65457)
https://github.com/phoebewang review_requested https://github.com/llvm/llvm-project/pull/65457 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang] [X86][Driver] Move mno-gather/mno-scatter from m_x86_Features_Group yo m_Group. NFCI (PR #65457)
https://github.com/phoebewang edited https://github.com/llvm/llvm-project/pull/65457 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang] [X86][Driver] Move mno-gather/mno-scatter from m_x86_Features_Group yo m_Group. NFCI (PR #65457)
https://github.com/phoebewang edited https://github.com/llvm/llvm-project/pull/65457 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang] [X86][Driver] Move mno-gather/mno-scatter from m_x86_Features_Group yo m_Group. NFCI (PR #65457)
https://github.com/github-actions[bot] labeled https://github.com/llvm/llvm-project/pull/65457 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang] [X86][Driver] Move mno-gather/mno-scatter from m_x86_Features_Group yo m_Group. NFCI (PR #65457)
https://github.com/phoebewang review_requested https://github.com/llvm/llvm-project/pull/65457 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang] [X86][Driver] Move mno-gather/mno-scatter from m_x86_Features_Group yo m_Group. NFCI (PR #65457)
https://github.com/phoebewang created https://github.com/llvm/llvm-project/pull/65457: m_x86_Features_Group always turn `mno-` into `-target-feature-`. In this case, we don't have `-gather/-scatter` but `+prefer-no-gather/scatter`. >From be58af68f221bb65788e74f8cfe4952c1038ae70 Mon Sep 17 00:00:00 2001 From: Phoebe Wang Date: Wed, 6 Sep 2023 17:10:01 +0800 Subject: [PATCH] [X86][Driver] Move mno-gather/mno-scatter from m_x86_Features_Group to m_Group. NFCI m_x86_Features_Group always turn `mno-` into `-target-feature-`. In this case, we don't have `-gather/-scatter` but `+prefer-no-gather/scatter`. --- clang/include/clang/Driver/Options.td | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/clang/include/clang/Driver/Options.td b/clang/include/clang/Driver/Options.td index e6d8aed6aefc8d9..9a6e7e9929f5f2f 100644 --- a/clang/include/clang/Driver/Options.td +++ b/clang/include/clang/Driver/Options.td @@ -5846,9 +5846,9 @@ def mretpoline_external_thunk : Flag<["-"], "mretpoline-external-thunk">, Group< def mno_retpoline_external_thunk : Flag<["-"], "mno-retpoline-external-thunk">, Group; def mvzeroupper : Flag<["-"], "mvzeroupper">, Group; def mno_vzeroupper : Flag<["-"], "mno-vzeroupper">, Group; -def mno_gather : Flag<["-"], "mno-gather">, Group, +def mno_gather : Flag<["-"], "mno-gather">, Group, HelpText<"Disable generation of gather instructions in auto-vectorization(x86 only)">; -def mno_scatter : Flag<["-"], "mno-scatter">, Group, +def mno_scatter : Flag<["-"], "mno-scatter">, Group, HelpText<"Disable generation of scatter instructions in auto-vectorization(x86 only)">; } // let Flags = [TargetSpecific] ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
