[clang] [clang][NFC] Fix FieldDecl::isUnnamedBitfield() capitalization (PR #89048)
https://github.com/Sirraide approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/89048 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang] [clang][NFC] Fix FieldDecl::isUnnamedBitfield() capitalization (PR #89048)
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Timm Baeder (tbaederr)
Changes
We always capitalize bitfield as "BitField".
---
Patch is 31.15 KiB, truncated to 20.00 KiB below, full version:
https://github.com/llvm/llvm-project/pull/89048.diff
25 Files Affected:
- (modified) clang/include/clang/AST/Decl.h (+1-1)
- (modified) clang/lib/AST/APValue.cpp (+2-1)
- (modified) clang/lib/AST/ASTContext.cpp (+1-1)
- (modified) clang/lib/AST/Decl.cpp (+1-1)
- (modified) clang/lib/AST/DeclCXX.cpp (+4-3)
- (modified) clang/lib/AST/Expr.cpp (+2-2)
- (modified) clang/lib/AST/ExprConstant.cpp (+9-9)
- (modified) clang/lib/AST/Interp/EvaluationResult.cpp (+1-1)
- (modified) clang/lib/AST/ItaniumMangle.cpp (+4-4)
- (modified) clang/lib/AST/MicrosoftMangle.cpp (+1-1)
- (modified) clang/lib/Analysis/FlowSensitive/DataflowEnvironment.cpp (+1-1)
- (modified) clang/lib/Analysis/UninitializedValues.cpp (+1-1)
- (modified) clang/lib/CodeGen/ABIInfoImpl.cpp (+1-1)
- (modified) clang/lib/CodeGen/CGCall.cpp (+1-1)
- (modified) clang/lib/CodeGen/CGExprAgg.cpp (+5-3)
- (modified) clang/lib/CodeGen/CGExprCXX.cpp (+1-1)
- (modified) clang/lib/CodeGen/CGExprConstant.cpp (+2-2)
- (modified) clang/lib/CodeGen/CodeGenTBAA.cpp (+1-1)
- (modified) clang/lib/CodeGen/Targets/X86.cpp (+2-2)
- (modified) clang/lib/Sema/SemaChecking.cpp (+1-1)
- (modified) clang/lib/Sema/SemaDecl.cpp (+1-1)
- (modified) clang/lib/Sema/SemaDeclCXX.cpp (+12-12)
- (modified) clang/lib/Sema/SemaInit.cpp (+12-12)
- (modified) clang/lib/StaticAnalyzer/Checkers/ObjCUnusedIVarsChecker.cpp
(+1-2)
- (modified) clang/lib/StaticAnalyzer/Core/RegionStore.cpp (+2-2)
``diff
diff --git a/clang/include/clang/AST/Decl.h b/clang/include/clang/AST/Decl.h
index 01af50ca694fdd..fe8fe5574a5ea0 100644
--- a/clang/include/clang/AST/Decl.h
+++ b/clang/include/clang/AST/Decl.h
@@ -3149,7 +3149,7 @@ class FieldDecl : public DeclaratorDecl, public
Mergeable {
bool isBitField() const { return BitField; }
/// Determines whether this is an unnamed bitfield.
- bool isUnnamedBitfield() const { return isBitField() && !getDeclName(); }
+ bool isUnnamedBitField() const { return isBitField() && !getDeclName(); }
/// Determines whether this field is a
/// representative for an anonymous struct or union. Such fields are
diff --git a/clang/lib/AST/APValue.cpp b/clang/lib/AST/APValue.cpp
index d8042321319a67..8c77b563657d90 100644
--- a/clang/lib/AST/APValue.cpp
+++ b/clang/lib/AST/APValue.cpp
@@ -908,7 +908,8 @@ void APValue::printPretty(raw_ostream , const
PrintingPolicy ,
for (const auto *FI : RD->fields()) {
if (!First)
Out << ", ";
- if (FI->isUnnamedBitfield()) continue;
+ if (FI->isUnnamedBitField())
+continue;
getStructField(FI->getFieldIndex()).
printPretty(Out, Policy, FI->getType(), Ctx);
First = false;
diff --git a/clang/lib/AST/ASTContext.cpp b/clang/lib/AST/ASTContext.cpp
index 6ce233704a5885..68a86de2f46466 100644
--- a/clang/lib/AST/ASTContext.cpp
+++ b/clang/lib/AST/ASTContext.cpp
@@ -2684,7 +2684,7 @@ getSubobjectSizeInBits(const FieldDecl *Field, const
ASTContext ,
if (Field->isBitField()) {
// If we have explicit padding bits, they don't contribute bits
// to the actual object representation, so return 0.
-if (Field->isUnnamedBitfield())
+if (Field->isUnnamedBitField())
return 0;
int64_t BitfieldSize = Field->getBitWidthValue(Context);
diff --git a/clang/lib/AST/Decl.cpp b/clang/lib/AST/Decl.cpp
index 33b6f8611f2162..169a6333c14f6e 100644
--- a/clang/lib/AST/Decl.cpp
+++ b/clang/lib/AST/Decl.cpp
@@ -4597,7 +4597,7 @@ unsigned FieldDecl::getBitWidthValue(const ASTContext
) const {
}
bool FieldDecl::isZeroLengthBitField(const ASTContext ) const {
- return isUnnamedBitfield() && !getBitWidth()->isValueDependent() &&
+ return isUnnamedBitField() && !getBitWidth()->isValueDependent() &&
getBitWidthValue(Ctx) == 0;
}
diff --git a/clang/lib/AST/DeclCXX.cpp b/clang/lib/AST/DeclCXX.cpp
index 645ec2f7563bca..00cc857f5e7379 100644
--- a/clang/lib/AST/DeclCXX.cpp
+++ b/clang/lib/AST/DeclCXX.cpp
@@ -668,7 +668,7 @@ bool CXXRecordDecl::hasSubobjectAtOffsetZeroOfEmptyBaseType(
for (auto *FD : X->fields()) {
// FIXME: Should we really care about the type of the first non-static
// data member of a non-union if there are preceding unnamed bit-fields?
- if (FD->isUnnamedBitfield())
+ if (FD->isUnnamedBitField())
continue;
if (!IsFirstField && !FD->isZeroSize(Ctx))
@@ -947,7 +947,7 @@ void CXXRecordDecl::addedMember(Decl *D) {
// A declaration for a bit-field that omits the identifier declares an
// unnamed bit-field. Unnamed bit-fields are not members and cannot be
// initialized.
-if (Field->isUnnamedBitfield()) {
+if (Field->isUnnamedBitField()) {
// C++ [meta.unary.prop]p4: [LWG2358]
// T is a class type [...] with [...]
[clang] [clang][NFC] Fix FieldDecl::isUnnamedBitfield() capitalization (PR #89048)
https://github.com/tbaederr created
https://github.com/llvm/llvm-project/pull/89048
We always capitalize bitfield as "BitField".
>From 071305b588337841fbd2dbb929487c105a289d4b Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Timm=20B=C3=A4der?=
Date: Wed, 17 Apr 2024 12:53:49 +0200
Subject: [PATCH] [clang][NFC] Fix FieldDecl::isUnnamedBitfield()
capitalization
We always capitalize bitfield as "BitField".
---
clang/include/clang/AST/Decl.h| 2 +-
clang/lib/AST/APValue.cpp | 3 ++-
clang/lib/AST/ASTContext.cpp | 2 +-
clang/lib/AST/Decl.cpp| 2 +-
clang/lib/AST/DeclCXX.cpp | 7 +++---
clang/lib/AST/Expr.cpp| 4 ++--
clang/lib/AST/ExprConstant.cpp| 18 +++---
clang/lib/AST/Interp/EvaluationResult.cpp | 2 +-
clang/lib/AST/ItaniumMangle.cpp | 8 +++
clang/lib/AST/MicrosoftMangle.cpp | 2 +-
.../FlowSensitive/DataflowEnvironment.cpp | 2 +-
clang/lib/Analysis/UninitializedValues.cpp| 2 +-
clang/lib/CodeGen/ABIInfoImpl.cpp | 2 +-
clang/lib/CodeGen/CGCall.cpp | 2 +-
clang/lib/CodeGen/CGExprAgg.cpp | 8 ---
clang/lib/CodeGen/CGExprCXX.cpp | 2 +-
clang/lib/CodeGen/CGExprConstant.cpp | 4 ++--
clang/lib/CodeGen/CodeGenTBAA.cpp | 2 +-
clang/lib/CodeGen/Targets/X86.cpp | 4 ++--
clang/lib/Sema/SemaChecking.cpp | 2 +-
clang/lib/Sema/SemaDecl.cpp | 2 +-
clang/lib/Sema/SemaDeclCXX.cpp| 24 +--
clang/lib/Sema/SemaInit.cpp | 24 +--
.../Checkers/ObjCUnusedIVarsChecker.cpp | 3 +--
clang/lib/StaticAnalyzer/Core/RegionStore.cpp | 4 ++--
25 files changed, 70 insertions(+), 67 deletions(-)
diff --git a/clang/include/clang/AST/Decl.h b/clang/include/clang/AST/Decl.h
index 01af50ca694fdd..fe8fe5574a5ea0 100644
--- a/clang/include/clang/AST/Decl.h
+++ b/clang/include/clang/AST/Decl.h
@@ -3149,7 +3149,7 @@ class FieldDecl : public DeclaratorDecl, public
Mergeable {
bool isBitField() const { return BitField; }
/// Determines whether this is an unnamed bitfield.
- bool isUnnamedBitfield() const { return isBitField() && !getDeclName(); }
+ bool isUnnamedBitField() const { return isBitField() && !getDeclName(); }
/// Determines whether this field is a
/// representative for an anonymous struct or union. Such fields are
diff --git a/clang/lib/AST/APValue.cpp b/clang/lib/AST/APValue.cpp
index d8042321319a67..8c77b563657d90 100644
--- a/clang/lib/AST/APValue.cpp
+++ b/clang/lib/AST/APValue.cpp
@@ -908,7 +908,8 @@ void APValue::printPretty(raw_ostream , const
PrintingPolicy ,
for (const auto *FI : RD->fields()) {
if (!First)
Out << ", ";
- if (FI->isUnnamedBitfield()) continue;
+ if (FI->isUnnamedBitField())
+continue;
getStructField(FI->getFieldIndex()).
printPretty(Out, Policy, FI->getType(), Ctx);
First = false;
diff --git a/clang/lib/AST/ASTContext.cpp b/clang/lib/AST/ASTContext.cpp
index 6ce233704a5885..68a86de2f46466 100644
--- a/clang/lib/AST/ASTContext.cpp
+++ b/clang/lib/AST/ASTContext.cpp
@@ -2684,7 +2684,7 @@ getSubobjectSizeInBits(const FieldDecl *Field, const
ASTContext ,
if (Field->isBitField()) {
// If we have explicit padding bits, they don't contribute bits
// to the actual object representation, so return 0.
-if (Field->isUnnamedBitfield())
+if (Field->isUnnamedBitField())
return 0;
int64_t BitfieldSize = Field->getBitWidthValue(Context);
diff --git a/clang/lib/AST/Decl.cpp b/clang/lib/AST/Decl.cpp
index 33b6f8611f2162..169a6333c14f6e 100644
--- a/clang/lib/AST/Decl.cpp
+++ b/clang/lib/AST/Decl.cpp
@@ -4597,7 +4597,7 @@ unsigned FieldDecl::getBitWidthValue(const ASTContext
) const {
}
bool FieldDecl::isZeroLengthBitField(const ASTContext ) const {
- return isUnnamedBitfield() && !getBitWidth()->isValueDependent() &&
+ return isUnnamedBitField() && !getBitWidth()->isValueDependent() &&
getBitWidthValue(Ctx) == 0;
}
diff --git a/clang/lib/AST/DeclCXX.cpp b/clang/lib/AST/DeclCXX.cpp
index 645ec2f7563bca..00cc857f5e7379 100644
--- a/clang/lib/AST/DeclCXX.cpp
+++ b/clang/lib/AST/DeclCXX.cpp
@@ -668,7 +668,7 @@ bool CXXRecordDecl::hasSubobjectAtOffsetZeroOfEmptyBaseType(
for (auto *FD : X->fields()) {
// FIXME: Should we really care about the type of the first non-static
// data member of a non-union if there are preceding unnamed bit-fields?
- if (FD->isUnnamedBitfield())
+ if (FD->isUnnamedBitField())
continue;
if (!IsFirstField && !FD->isZeroSize(Ctx))
@@ -947,7 +947,7 @@ void CXXRecordDecl::addedMember(Decl *D) {
// A declaration for a bit-field that omits the identifier declares an
// unnamed bit-field. Unnamed
