[clang] [clang] Add test for CWG1606 (PR #87274)

2024-04-02 Thread via cfe-commits 

github-actions[bot] wrote:



@NekoCdr Congratulations on having your first Pull Request (PR) merged into the 
LLVM Project!

Your changes will be combined with recent changes from other authors, then 
tested
by our [build bots](https://lab.llvm.org/buildbot/). If there is a problem with 
a build, you may receive a report in an email or a comment on this PR.

Please check whether problems have been caused by your change specifically, as
the builds can include changes from many authors. It is not uncommon for your
change to be included in a build that fails due to someone else's changes, or
infrastructure issues.

How to do this, and the rest of the post-merge process, is covered in detail 
[here](https://llvm.org/docs/MyFirstTypoFix.html#myfirsttypofix-issues-after-landing-your-pr).

If your change does cause a problem, it may be reverted, or you can revert it 
yourself.
This is a normal part of [LLVM 
development](https://llvm.org/docs/DeveloperPolicy.html#patch-reversion-policy).
 You can fix your changes and open a new PR to merge them again.

If you don't get any reports, no action is required from you. Your changes are 
working as expected, well done!


https://github.com/llvm/llvm-project/pull/87274
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Add test for CWG1606 (PR #87274)

2024-04-02 Thread Vlad Serebrennikov via cfe-commits 

https://github.com/Endilll closed 
https://github.com/llvm/llvm-project/pull/87274
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Add test for CWG1606 (PR #87274)

2024-04-02 Thread Yuri Istomin via cfe-commits 

https://github.com/NekoCdr updated 
https://github.com/llvm/llvm-project/pull/87274

>From 1dfb9414a28f99024a8abe36b0b10a4d91eae573 Mon Sep 17 00:00:00 2001
From: Yuri Istomin 
Date: Mon, 1 Apr 2024 22:02:42 +0300
Subject: [PATCH 1/3] [clang] Add test for CWG1606

---
 clang/test/CXX/drs/dr16xx.cpp | 11 +++
 1 file changed, 11 insertions(+)

diff --git a/clang/test/CXX/drs/dr16xx.cpp b/clang/test/CXX/drs/dr16xx.cpp
index 766c90d3bc7bda..cf05cc2291e6ff 100644
--- a/clang/test/CXX/drs/dr16xx.cpp
+++ b/clang/test/CXX/drs/dr16xx.cpp
@@ -35,6 +35,17 @@ void g() {
 }
 } // namespace dr1601
 
+namespace dr1606 { // dr1606: 3.1
+#if __cplusplus >= 201103L
+  std::size_t test() {
+int i = 1;
+int j = 1;
+auto f = [=]{ return i + j;};
+return sizeof(f);
+  }
+#endif
+} // namespace dr1606
+
 namespace dr1611 { // dr1611: dup 1658
   struct A { A(int); };
   struct B : virtual A { virtual void f() = 0; };

>From fdffb31e1f960d51b840398950e3758f7c5a284f Mon Sep 17 00:00:00 2001
From: Yuri Istomin 
Date: Mon, 1 Apr 2024 22:03:12 +0300
Subject: [PATCH 2/3] Update DR status page

---
 clang/www/cxx_dr_status.html | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/clang/www/cxx_dr_status.html b/clang/www/cxx_dr_status.html
index c20a5d021e9d95..5e1e03dec1d484 100755
--- a/clang/www/cxx_dr_status.html
+++ b/clang/www/cxx_dr_status.html
@@ -9444,7 +9444,7 @@ C++ defect report implementation 
status
 https://cplusplus.github.io/CWG/issues/1606.html;>1606
 NAD
 sizeof closure class
-Unknown
+Clang 3.1
   
   
 https://cplusplus.github.io/CWG/issues/1607.html;>1607

>From 48a042bf084f92e8da935326f8cf22b5c6e72a1c Mon Sep 17 00:00:00 2001
From: Yuri Istomin 
Date: Tue, 2 Apr 2024 14:58:57 +0300
Subject: [PATCH 3/3] Fix codestyle

---
 clang/test/CXX/drs/dr16xx.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/clang/test/CXX/drs/dr16xx.cpp b/clang/test/CXX/drs/dr16xx.cpp
index cf05cc2291e6ff..f4d6c04fb8e073 100644
--- a/clang/test/CXX/drs/dr16xx.cpp
+++ b/clang/test/CXX/drs/dr16xx.cpp
@@ -40,7 +40,7 @@ namespace dr1606 { // dr1606: 3.1
   std::size_t test() {
 int i = 1;
 int j = 1;
-auto f = [=]{ return i + j;};
+auto f = [=]{ return i + j; };
 return sizeof(f);
   }
 #endif

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Add test for CWG1606 (PR #87274)

2024-04-01 Thread Shafik Yaghmour via cfe-commits 

shafik wrote:

It looks like we do have a test and it looks like the restriction was lifted in 
C++20.

https://github.com/llvm/llvm-project/pull/87274
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Add test for CWG1606 (PR #87274)

2024-04-01 Thread Shafik Yaghmour via cfe-commits 

https://github.com/shafik approved this pull request.

Thank you for the test! LGTM.

Do we also have a test that `sizeof([=]{ return i + j;})` should fail as well? 
Tangentially related to this DR but if we don't we should cover that in our 
tests someplace.

https://github.com/llvm/llvm-project/pull/87274
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Add test for CWG1606 (PR #87274)

2024-04-01 Thread Vlad Serebrennikov via cfe-commits 

https://github.com/Endilll approved this pull request.

LGTM!

Disclosure: me and author extensively reviewed this offline before publishing.

https://github.com/llvm/llvm-project/pull/87274
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Add test for CWG1606 (PR #87274)

2024-04-01 Thread via cfe-commits 

llvmbot wrote:




@llvm/pr-subscribers-clang

Author: Yuri Istomin (NekoCdr)


Changes

https://cplusplus.github.io/CWG/issues/1606.html

---
Full diff: https://github.com/llvm/llvm-project/pull/87274.diff


2 Files Affected:

- (modified) clang/test/CXX/drs/dr16xx.cpp (+11) 
- (modified) clang/www/cxx_dr_status.html (+1-1) 


``diff
diff --git a/clang/test/CXX/drs/dr16xx.cpp b/clang/test/CXX/drs/dr16xx.cpp
index 766c90d3bc7bda..cf05cc2291e6ff 100644
--- a/clang/test/CXX/drs/dr16xx.cpp
+++ b/clang/test/CXX/drs/dr16xx.cpp
@@ -35,6 +35,17 @@ void g() {
 }
 } // namespace dr1601
 
+namespace dr1606 { // dr1606: 3.1
+#if __cplusplus >= 201103L
+  std::size_t test() {
+int i = 1;
+int j = 1;
+auto f = [=]{ return i + j;};
+return sizeof(f);
+  }
+#endif
+} // namespace dr1606
+
 namespace dr1611 { // dr1611: dup 1658
   struct A { A(int); };
   struct B : virtual A { virtual void f() = 0; };
diff --git a/clang/www/cxx_dr_status.html b/clang/www/cxx_dr_status.html
index c20a5d021e9d95..5e1e03dec1d484 100755
--- a/clang/www/cxx_dr_status.html
+++ b/clang/www/cxx_dr_status.html
@@ -9444,7 +9444,7 @@ C++ defect report implementation 
status
 https://cplusplus.github.io/CWG/issues/1606.html;>1606
 NAD
 sizeof closure class
-Unknown
+Clang 3.1
   
   
 https://cplusplus.github.io/CWG/issues/1607.html;>1607

``




https://github.com/llvm/llvm-project/pull/87274
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Add test for CWG1606 (PR #87274)

2024-04-01 Thread via cfe-commits 

github-actions[bot] wrote:



Thank you for submitting a Pull Request (PR) to the LLVM Project!

This PR will be automatically labeled and the relevant teams will be
notified.

If you wish to, you can add reviewers by using the "Reviewers" section on this 
page.

If this is not working for you, it is probably because you do not have write
permissions for the repository. In which case you can instead tag reviewers by
name in a comment by using `@` followed by their GitHub username.

If you have received no comments on your PR for a week, you can request a review
by "ping"ing the PR by adding a comment “Ping”. The common courtesy "ping" rate
is once a week. Please remember that you are asking for valuable time from 
other developers.

If you have further questions, they may be answered by the [LLVM GitHub User 
Guide](https://llvm.org/docs/GitHub.html).

You can also ask questions in a comment on this PR, on the [LLVM 
Discord](https://discord.com/invite/xS7Z362) or on the 
[forums](https://discourse.llvm.org/).

https://github.com/llvm/llvm-project/pull/87274
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Add test for CWG1606 (PR #87274)

2024-04-01 Thread Yuri Istomin via cfe-commits 

https://github.com/NekoCdr created 
https://github.com/llvm/llvm-project/pull/87274

https://cplusplus.github.io/CWG/issues/1606.html

>From 1dfb9414a28f99024a8abe36b0b10a4d91eae573 Mon Sep 17 00:00:00 2001
From: Yuri Istomin 
Date: Mon, 1 Apr 2024 22:02:42 +0300
Subject: [PATCH 1/2] [clang] Add test for CWG1606

---
 clang/test/CXX/drs/dr16xx.cpp | 11 +++
 1 file changed, 11 insertions(+)

diff --git a/clang/test/CXX/drs/dr16xx.cpp b/clang/test/CXX/drs/dr16xx.cpp
index 766c90d3bc7bda..cf05cc2291e6ff 100644
--- a/clang/test/CXX/drs/dr16xx.cpp
+++ b/clang/test/CXX/drs/dr16xx.cpp
@@ -35,6 +35,17 @@ void g() {
 }
 } // namespace dr1601
 
+namespace dr1606 { // dr1606: 3.1
+#if __cplusplus >= 201103L
+  std::size_t test() {
+int i = 1;
+int j = 1;
+auto f = [=]{ return i + j;};
+return sizeof(f);
+  }
+#endif
+} // namespace dr1606
+
 namespace dr1611 { // dr1611: dup 1658
   struct A { A(int); };
   struct B : virtual A { virtual void f() = 0; };

>From fdffb31e1f960d51b840398950e3758f7c5a284f Mon Sep 17 00:00:00 2001
From: Yuri Istomin 
Date: Mon, 1 Apr 2024 22:03:12 +0300
Subject: [PATCH 2/2] Update DR status page

---
 clang/www/cxx_dr_status.html | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/clang/www/cxx_dr_status.html b/clang/www/cxx_dr_status.html
index c20a5d021e9d95..5e1e03dec1d484 100755
--- a/clang/www/cxx_dr_status.html
+++ b/clang/www/cxx_dr_status.html
@@ -9444,7 +9444,7 @@ C++ defect report implementation 
status
 https://cplusplus.github.io/CWG/issues/1606.html;>1606
 NAD
 sizeof closure class
-Unknown
+Clang 3.1
   
   
 https://cplusplus.github.io/CWG/issues/1607.html;>1607

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits