[clang] [clang] Change style of superseded issues on C++ DR status page (PR #96051)

2024-06-21 Thread via cfe-commits

h-vetinari wrote:

I was wondering for a while along similar lines, if NAD ("not a defect") 
shouldn't get a downgraded colour as well. A "No" to  NAD is certainly less 
relevant than an actual defect report, isn't it?

https://github.com/llvm/llvm-project/pull/96051
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits


[clang] [clang] Change style of superseded issues on C++ DR status page (PR #96051)

2024-06-20 Thread Vlad Serebrennikov via cfe-commits

Endilll wrote:

That clearly is an unrelated failure.

https://github.com/llvm/llvm-project/pull/96051
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits


[clang] [clang] Change style of superseded issues on C++ DR status page (PR #96051)

2024-06-20 Thread LLVM Continuous Integration via cfe-commits

llvm-ci wrote:

LLVM Buildbot has detected a new failure on builder `clang-hip-vega20` running 
on `hip-vega20-0` while building `clang` at step 3 "annotate".

Full details are available at: 
https://lab.llvm.org/buildbot/#/builders/123/builds/296

Here is the relevant piece of the build log for the reference:
```
Step 3 (annotate) failure: 
'../llvm-zorg/zorg/buildbot/builders/annotated/hip-build.sh --jobs=' (failure)
../llvm-zorg/zorg/buildbot/builders/annotated/hip-build.sh --jobs=
 in dir /work/hip-vega20-0/clang-hip-vega20/build (timeout 1200 secs)
 watching logfiles {}
 argv: [b'../llvm-zorg/zorg/buildbot/builders/annotated/hip-build.sh', 
b'--jobs=']
 environment:
  BUILDBOT_BLAMELIST=[]
  BUILDBOT_BRANCH=main
  BUILDBOT_BUILDERNAME=clang-hip-vega20
  BUILDBOT_BUILDNUMBER=296
  BUILDBOT_CLOBBER=
  BUILDBOT_GOT_REVISION=7272881f30d1df4b1ff45de2abb8efad7f5b9cdf
  BUILDBOT_REVISION=993c12b3177554d7915cde501fe5bddaa95dadae
  BUILDBOT_SCHEDULER=main:clang,compiler-rt,libcxx,libcxxabi,libunwind,lld,llvm
  HIP_BLENDER_TEST_CCC_OVERRIDE_OPTIONS=x-ffast-math +-mcode-object-version=4 
+-v
  HIP_BLENDER_TEST_PERF_THRESH=15
  HOME=/home/hip-vega20-0
  LANG=C.UTF-8
  LOGNAME=hip-vega20-0
  MAIL=/var/mail/hip-vega20-0
  NINJAOPT=-v
  OLDPWD=/home/hip-vega20-0/res.bad/test
  
PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/snap/bin
  PWD=/work/hip-vega20-0/clang-hip-vega20/build
  SHELL=/bin/bash
  SHLVL=2
  SSH_CLIENT=10.1.34.141 39210 22
  SSH_CONNECTION=10.1.34.141 39210 10.216.90.123 22
  SSH_TTY=/dev/pts/0
  TERM=dumb
  USER=hip-vega20-0
  XDG_DATA_DIRS=/usr/local/share:/usr/share:/var/lib/snapd/desktop
  _=/usr/bin/buildbot-worker
 using PTY: False
++ dirname ../llvm-zorg/zorg/buildbot/builders/annotated/hip-build.sh
+ HERE=../llvm-zorg/zorg/buildbot/builders/annotated
+ . ../llvm-zorg/zorg/buildbot/builders/annotated/buildbot-helper.sh
+ set -eu
+ halt_on_failure
+ echo @@@HALT_ON_FAILURE@@@
+ setup_env
+ build_step 'Setting up the buildbot'
+ echo '@@@BUILD_STEP Setting up the buildbot@@@'
+ BUILDBOT_ROOT=/buildbot
Step 12 (Testing HIP test-suite) failure: Testing HIP test-suite (failure)
@@@BUILD_STEP Testing HIP test-suite@@@
[0/1] cd /buildbot/hip-vega20-0/clang-hip-vega20/test-suite-build/External/HIP 
&& /buildbot/hip-vega20-0/clang-hip-vega20/llvm/bin/llvm-lit -sv 
empty-hip-6.0.2.test with-fopenmp-hip-6.0.2.test saxpy-hip-6.0.2.test 
InOneWeekend-hip-6.0.2.test TheNextWeek-hip-6.0.2.test blender.test
-- Testing: 6 tests, 6 workers --
/usr/bin/strip: /bin/bash.stripped: Bad file descriptor
Testing:  0.. 10.. 20.. 30.. 40.. 50.. 60.
FAIL: test-suite :: External/HIP/InOneWeekend-hip-6.0.2.test (5 of 6)
 TEST 'test-suite :: 
External/HIP/InOneWeekend-hip-6.0.2.test' FAILED 

/buildbot/hip-vega20-0/clang-hip-vega20/test-suite-build/tools/timeit-target 
--timeout 7200 --limit-core 0 --limit-cpu 7200 --limit-file-size 209715200 
--limit-rss-size 838860800 --append-exitstatus --redirect-output 
/buildbot/hip-vega20-0/clang-hip-vega20/test-suite-build/External/HIP/Output/InOneWeekend-hip-6.0.2.test.out
 --redirect-input /dev/null --summary 
/buildbot/hip-vega20-0/clang-hip-vega20/test-suite-build/External/HIP/Output/InOneWeekend-hip-6.0.2.test.time
 
/buildbot/hip-vega20-0/clang-hip-vega20/test-suite-build/External/HIP/InOneWeekend-hip-6.0.2
cd /buildbot/hip-vega20-0/clang-hip-vega20/test-suite-build/External/HIP ; 
/buildbot/hip-vega20-0/clang-hip-vega20/test-suite-build/tools/fpcmp-target 
/buildbot/hip-vega20-0/clang-hip-vega20/test-suite-build/External/HIP/Output/InOneWeekend-hip-6.0.2.test.out
 InOneWeekend.reference_output-hip-6.0.2

+ cd /buildbot/hip-vega20-0/clang-hip-vega20/test-suite-build/External/HIP
+ /buildbot/hip-vega20-0/clang-hip-vega20/test-suite-build/tools/fpcmp-target 
/buildbot/hip-vega20-0/clang-hip-vega20/test-suite-build/External/HIP/Output/InOneWeekend-hip-6.0.2.test.out
 InOneWeekend.reference_output-hip-6.0.2
/buildbot/hip-vega20-0/clang-hip-vega20/test-suite-build/tools/fpcmp-target: 
Comparison failed, textual difference between 'M' and 'i'


Testing:  0.. 10.. 20.. 30.. 40.. 50.. 60.. 70.. 80.. 90.. 

Failed Tests (1):
  test-suite :: External/HIP/InOneWeekend-hip-6.0.2.test


Testing Time: 50.70s

Total Discovered Tests: 6
  Passed: 5 (83.33%)
  Failed: 1 (16.67%)
FAILED: External/HIP/CMakeFiles/check-hip-simple-hip-6.0.2 
cd /buildbot/hip-vega20-0/clang-hip-vega20/test-suite-build/External/HIP && 
/buildbot/hip-vega20-0/clang-hip-vega20/llvm/bin/llvm-lit -sv 
empty-hip-6.0.2.test with-fopenmp-hip-6.0.2.test saxpy-hip-6.0.2.test 
InOneWeekend-hip-6.0.2.test TheNextWeek-hip-6.0.2.test blender.test
ninja: build stopped: subcommand failed.
program finished with exit code 1
elapsedTime=157.598724

```

https://github.com/llvm/llvm-project/pull/96051
___
cfe-commits mailing list
cfe-commits@lists.llvm.org

[clang] [clang] Change style of superseded issues on C++ DR status page (PR #96051)

2024-06-20 Thread Vlad Serebrennikov via cfe-commits

https://github.com/Endilll closed 
https://github.com/llvm/llvm-project/pull/96051
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits


[clang] [clang] Change style of superseded issues on C++ DR status page (PR #96051)

2024-06-20 Thread Aaron Ballman via cfe-commits

https://github.com/AaronBallman approved this pull request.

LGTM, thank you, I love it!

https://github.com/llvm/llvm-project/pull/96051
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits


[clang] [clang] Change style of superseded issues on C++ DR status page (PR #96051)

2024-06-19 Thread Matheus Izvekov via cfe-commits

https://github.com/mizvekov approved this pull request.


https://github.com/llvm/llvm-project/pull/96051
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits


[clang] [clang] Change style of superseded issues on C++ DR status page (PR #96051)

2024-06-19 Thread via cfe-commits

https://github.com/cor3ntin approved this pull request.


https://github.com/llvm/llvm-project/pull/96051
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits


[clang] [clang] Change style of superseded issues on C++ DR status page (PR #96051)

2024-06-19 Thread via cfe-commits

llvmbot wrote:




@llvm/pr-subscribers-clang

Author: Vlad Serebrennikov (Endilll)


Changes

This patch changes how superseded issues inherit the color of the issues that 
superseded them. Now they reduce the opacity of the color from 1.0 to 0.65, to 
make them distinguishable. This was requested during the review of #94876.

That's how it's going to look:
![a1rYVHQ](https://github.com/llvm/llvm-project/assets/12883766/00e624c0-accb-4440-9f9b-4089a157aab2)


---

Patch is 21.94 KiB, truncated to 20.00 KiB below, full version: 
https://github.com/llvm/llvm-project/pull/96051.diff


2 Files Affected:

- (modified) clang/www/cxx_dr_status.html (+36-29) 
- (modified) clang/www/make_cxx_dr_status (+34-22) 


``diff
diff --git a/clang/www/cxx_dr_status.html b/clang/www/cxx_dr_status.html
index dac38cedfcb75..7b61f47d834da 100755
--- a/clang/www/cxx_dr_status.html
+++ b/clang/www/cxx_dr_status.html
@@ -8,12 +8,19 @@
   
   

[clang] [clang] Change style of superseded issues on C++ DR status page (PR #96051)

2024-06-19 Thread Vlad Serebrennikov via cfe-commits

https://github.com/Endilll created 
https://github.com/llvm/llvm-project/pull/96051

This patch changes how superseded issues inherit the color of the issues that 
superseded them. Now they reduce the opacity of the color from 1.0 to 0.65, to 
make them distinguishable. This was requested during the review of #94876.

That's how it's going to look:
![a1rYVHQ](https://github.com/llvm/llvm-project/assets/12883766/00e624c0-accb-4440-9f9b-4089a157aab2)


>From 30179e044b3266eb85a2841691db6235ea0bed18 Mon Sep 17 00:00:00 2001
From: Vlad Serebrennikov 
Date: Wed, 19 Jun 2024 13:42:33 +0300
Subject: [PATCH] [clang] Change style of superseded issues on C++ DR status
 page

---
 clang/www/cxx_dr_status.html | 65 
 clang/www/make_cxx_dr_status | 56 +++
 2 files changed, 70 insertions(+), 51 deletions(-)

diff --git a/clang/www/cxx_dr_status.html b/clang/www/cxx_dr_status.html
index dac38cedfcb75..7b61f47d834da 100755
--- a/clang/www/cxx_dr_status.html
+++ b/clang/www/cxx_dr_status.html
@@ -8,12 +8,19 @@