[clang] [clang-format][NFC] Extend isProto() to also cover LK_TextProto (PR #73582)
https://github.com/owenca closed https://github.com/llvm/llvm-project/pull/73582 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang] [clang-format][NFC] Extend isProto() to also cover LK_TextProto (PR #73582)
https://github.com/HazardyKnusperkeks approved this pull request. I must've read some of the diff backwards. I thought you replaced `Language == LK_Proto` with `isProto()`. https://github.com/llvm/llvm-project/pull/73582 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang] [clang-format][NFC] Extend isProto() to also cover LK_TextProto (PR #73582)
owenca wrote: This patch makes `isProto()` a convenience function like `isCpp()`, which doesn't prevent us from handling C++ and Objective-C separately when needed. Although `LK_TextProto` is not always formatted like `LK_Proto`, it's frequent enough (about 16 times in the codebase) that we should make a function for it. https://github.com/llvm/llvm-project/pull/73582 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang] [clang-format][NFC] Extend isProto() to also cover LK_TextProto (PR #73582)
https://github.com/HazardyKnusperkeks commented: I can not say if TextProto should be handled equally to Proto. https://github.com/llvm/llvm-project/pull/73582 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang] [clang-format][NFC] Extend isProto() to also cover LK_TextProto (PR #73582)
https://github.com/owenca edited https://github.com/llvm/llvm-project/pull/73582 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
