[clang] [clang-format][NFC] Use `prog` in clang-format-diff.py (PR #74399)
serge-sans-paille wrote: thanks :bow: https://github.com/llvm/llvm-project/pull/74399 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang] [clang-format][NFC] Use `prog` in clang-format-diff.py (PR #74399)
https://github.com/serge-sans-paille closed https://github.com/llvm/llvm-project/pull/74399 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang] [clang-format][NFC] Use `prog` in clang-format-diff.py (PR #74399)
owenca wrote: > You can remove the useless `import os` then :-) Good catch! https://github.com/llvm/llvm-project/pull/74399 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang] [clang-format][NFC] Use `prog` in clang-format-diff.py (PR #74399)
https://github.com/owenca updated https://github.com/llvm/llvm-project/pull/74399 >From ee039e7c50751fabdbaadae73a0a09bc905620f2 Mon Sep 17 00:00:00 2001 From: Owen Pan Date: Mon, 4 Dec 2023 17:33:47 -0800 Subject: [PATCH 1/3] [clang-format][NFC] Use `prog` in clang-format-diff.py This is a minor improvement to #73491. --- clang/tools/clang-format/clang-format-diff.py | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/clang/tools/clang-format/clang-format-diff.py b/clang/tools/clang-format/clang-format-diff.py index b25ee8f433751..946e28163420d 100755 --- a/clang/tools/clang-format/clang-format-diff.py +++ b/clang/tools/clang-format/clang-format-diff.py @@ -37,9 +37,8 @@ def main(): -basename = os.path.basename(sys.argv[0]) parser = argparse.ArgumentParser( -description=__doc__.format(clang_format_diff=basename), +description=__doc__.format(clang_format_diff='%(prog)s'), formatter_class=argparse.RawDescriptionHelpFormatter, ) parser.add_argument( >From d8b2dab602b41deda70abd0f219ca88d5fd69c36 Mon Sep 17 00:00:00 2001 From: Owen Pan Date: Mon, 4 Dec 2023 17:41:58 -0800 Subject: [PATCH 2/3] Use double quotes instead. --- clang/tools/clang-format/clang-format-diff.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/clang/tools/clang-format/clang-format-diff.py b/clang/tools/clang-format/clang-format-diff.py index 946e28163420d..9f3538608aaba 100755 --- a/clang/tools/clang-format/clang-format-diff.py +++ b/clang/tools/clang-format/clang-format-diff.py @@ -38,7 +38,7 @@ def main(): parser = argparse.ArgumentParser( -description=__doc__.format(clang_format_diff='%(prog)s'), +description=__doc__.format(clang_format_diff="%(prog)s"), formatter_class=argparse.RawDescriptionHelpFormatter, ) parser.add_argument( >From 6ff8c2870bfb093cc5a02d0f6caa5c869cf5ec29 Mon Sep 17 00:00:00 2001 From: Owen Pan Date: Tue, 5 Dec 2023 00:51:16 -0800 Subject: [PATCH 3/3] Remove now unneeded `import os`. --- clang/tools/clang-format/clang-format-diff.py | 1 - 1 file changed, 1 deletion(-) diff --git a/clang/tools/clang-format/clang-format-diff.py b/clang/tools/clang-format/clang-format-diff.py index 9f3538608aaba..0a2c24743678d 100755 --- a/clang/tools/clang-format/clang-format-diff.py +++ b/clang/tools/clang-format/clang-format-diff.py @@ -25,7 +25,6 @@ import argparse import difflib -import os import re import subprocess import sys ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang] [clang-format][NFC] Use `prog` in clang-format-diff.py (PR #74399)
serge-sans-paille wrote: Much better! You can remove the useless `import os` then :-) https://github.com/llvm/llvm-project/pull/74399 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang] [clang-format][NFC] Use `prog` in clang-format-diff.py (PR #74399)
https://github.com/owenca updated https://github.com/llvm/llvm-project/pull/74399 >From ee039e7c50751fabdbaadae73a0a09bc905620f2 Mon Sep 17 00:00:00 2001 From: Owen Pan Date: Mon, 4 Dec 2023 17:33:47 -0800 Subject: [PATCH 1/2] [clang-format][NFC] Use `prog` in clang-format-diff.py This is a minor improvement to #73491. --- clang/tools/clang-format/clang-format-diff.py | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/clang/tools/clang-format/clang-format-diff.py b/clang/tools/clang-format/clang-format-diff.py index b25ee8f433751..946e28163420d 100755 --- a/clang/tools/clang-format/clang-format-diff.py +++ b/clang/tools/clang-format/clang-format-diff.py @@ -37,9 +37,8 @@ def main(): -basename = os.path.basename(sys.argv[0]) parser = argparse.ArgumentParser( -description=__doc__.format(clang_format_diff=basename), +description=__doc__.format(clang_format_diff='%(prog)s'), formatter_class=argparse.RawDescriptionHelpFormatter, ) parser.add_argument( >From d8b2dab602b41deda70abd0f219ca88d5fd69c36 Mon Sep 17 00:00:00 2001 From: Owen Pan Date: Mon, 4 Dec 2023 17:41:58 -0800 Subject: [PATCH 2/2] Use double quotes instead. --- clang/tools/clang-format/clang-format-diff.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/clang/tools/clang-format/clang-format-diff.py b/clang/tools/clang-format/clang-format-diff.py index 946e28163420d..9f3538608aaba 100755 --- a/clang/tools/clang-format/clang-format-diff.py +++ b/clang/tools/clang-format/clang-format-diff.py @@ -38,7 +38,7 @@ def main(): parser = argparse.ArgumentParser( -description=__doc__.format(clang_format_diff='%(prog)s'), +description=__doc__.format(clang_format_diff="%(prog)s"), formatter_class=argparse.RawDescriptionHelpFormatter, ) parser.add_argument( ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang] [clang-format][NFC] Use `prog` in clang-format-diff.py (PR #74399)
github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r 192439db6e3fcccf98c850bda1b970a11c590bbb..ee039e7c50751fabdbaadae73a0a09bc905620f2 clang/tools/clang-format/clang-format-diff.py `` View the diff from darker here. ``diff --- clang-format-diff.py2023-12-05 01:33:47.00 + +++ clang-format-diff.py2023-12-05 01:40:08.802548 + @@ -36,11 +36,11 @@ from io import BytesIO as StringIO def main(): parser = argparse.ArgumentParser( -description=__doc__.format(clang_format_diff='%(prog)s'), +description=__doc__.format(clang_format_diff="%(prog)s"), formatter_class=argparse.RawDescriptionHelpFormatter, ) parser.add_argument( "-i", action="store_true", `` https://github.com/llvm/llvm-project/pull/74399 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang] [clang-format][NFC] Use `prog` in clang-format-diff.py (PR #74399)
llvmbot wrote: @llvm/pr-subscribers-clang-format Author: Owen Pan (owenca) Changes This is a minor improvement to #73491. --- Full diff: https://github.com/llvm/llvm-project/pull/74399.diff 1 Files Affected: - (modified) clang/tools/clang-format/clang-format-diff.py (+1-2) ``diff diff --git a/clang/tools/clang-format/clang-format-diff.py b/clang/tools/clang-format/clang-format-diff.py index b25ee8f433751..946e28163420d 100755 --- a/clang/tools/clang-format/clang-format-diff.py +++ b/clang/tools/clang-format/clang-format-diff.py @@ -37,9 +37,8 @@ def main(): -basename = os.path.basename(sys.argv[0]) parser = argparse.ArgumentParser( -description=__doc__.format(clang_format_diff=basename), +description=__doc__.format(clang_format_diff='%(prog)s'), formatter_class=argparse.RawDescriptionHelpFormatter, ) parser.add_argument( `` https://github.com/llvm/llvm-project/pull/74399 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang] [clang-format][NFC] Use `prog` in clang-format-diff.py (PR #74399)
https://github.com/owenca created https://github.com/llvm/llvm-project/pull/74399 This is a minor improvement to #73491. >From ee039e7c50751fabdbaadae73a0a09bc905620f2 Mon Sep 17 00:00:00 2001 From: Owen Pan Date: Mon, 4 Dec 2023 17:33:47 -0800 Subject: [PATCH] [clang-format][NFC] Use `prog` in clang-format-diff.py This is a minor improvement to #73491. --- clang/tools/clang-format/clang-format-diff.py | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/clang/tools/clang-format/clang-format-diff.py b/clang/tools/clang-format/clang-format-diff.py index b25ee8f433751..946e28163420d 100755 --- a/clang/tools/clang-format/clang-format-diff.py +++ b/clang/tools/clang-format/clang-format-diff.py @@ -37,9 +37,8 @@ def main(): -basename = os.path.basename(sys.argv[0]) parser = argparse.ArgumentParser( -description=__doc__.format(clang_format_diff=basename), +description=__doc__.format(clang_format_diff='%(prog)s'), formatter_class=argparse.RawDescriptionHelpFormatter, ) parser.add_argument( ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
