[clang] [clang-tools-extra] [clang][modules] Deprecate module.map in favor of module.modulemap (PR #75142)

2023-12-14 Thread Michael Spencer via cfe-commits

https://github.com/Bigcheese closed 
https://github.com/llvm/llvm-project/pull/75142
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits


[clang] [clang-tools-extra] [clang][modules] Deprecate module.map in favor of module.modulemap (PR #75142)

2023-12-12 Thread David Blaikie via cfe-commits

https://github.com/dwblaikie approved this pull request.

SGTM

https://github.com/llvm/llvm-project/pull/75142
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits


[clang] [clang-tools-extra] [clang][modules] Deprecate module.map in favor of module.modulemap (PR #75142)

2023-12-11 Thread via cfe-commits

llvmbot wrote:



@llvm/pr-subscribers-clang-modules

@llvm/pr-subscribers-clangd

Author: Michael Spencer (Bigcheese)


Changes

This patch deprecates `module.map` in favor of `module.modulemap`, which has 
been the preferred form since 2014. The eventual goal is to remove support for 
`module.map` to reduce the number of stats Clang needs to do while searching 
for module map files.

This patch touches a lot of files, but the majority of them are just renaming 
tests or references to the file in comments or documentation.

The relevant files are:
* lib/Lex/HeaderSearch.cpp
* include/clang/Basic/DiagnosticGroups.td
* include/clang/Basic/DiagnosticLexKinds.td

---

Patch is 108.34 KiB, truncated to 20.00 KiB below, full version: 
https://github.com/llvm/llvm-project/pull/75142.diff


142 Files Affected:

- (modified) clang-tools-extra/clangd/unittests/SymbolCollectorTests.cpp (+2-2) 
- (modified) clang-tools-extra/docs/modularize.rst (+1-1) 
- (renamed) 
clang-tools-extra/include-cleaner/test/Inputs/modules/module.modulemap () 
- (modified) clang-tools-extra/modularize/Modularize.cpp (+6-6) 
- (modified) clang-tools-extra/modularize/ModularizeUtilities.cpp (+2-2) 
- (modified) clang-tools-extra/modularize/ModularizeUtilities.h (+2-2) 
- (modified) 
clang-tools-extra/test/modularize/Inputs/CompileError/module.modulemap (+1-1) 
- (modified) 
clang-tools-extra/test/modularize/Inputs/CoverageNoProblems/module.modulemap 
(+1-1) 
- (modified) 
clang-tools-extra/test/modularize/Inputs/CoverageProblems/module.modulemap 
(+1-1) 
- (modified) 
clang-tools-extra/test/modularize/Inputs/MissingHeader/module.modulemap (+1-1) 
- (renamed) clang-tools-extra/test/pp-trace/Inputs/module.modulemap (+1-1) 
- (modified) clang/include/clang-c/BuildSystem.h (+3-3) 
- (modified) clang/include/clang/Basic/DiagnosticGroups.td (+1) 
- (modified) clang/include/clang/Basic/DiagnosticLexKinds.td (+3) 
- (modified) clang/lib/Lex/HeaderSearch.cpp (+17-5) 
- (renamed) clang/test/ARCMT/Inputs/module.modulemap () 
- (renamed) clang/test/Index/Inputs/Frameworks/module.modulemap () 
- (renamed) clang/test/Index/Inputs/Headers/module.modulemap () 
- (renamed) clang/test/Index/Inputs/Headers/nested/module.modulemap () 
- (renamed) clang/test/Index/Inputs/module.modulemap () 
- (modified) clang/test/Index/Inputs/vfsoverlay.yaml (+2-2) 
- (renamed) clang/test/Modules/Inputs/Conflicts/module.modulemap () 
- (renamed) 
clang/test/Modules/Inputs/DependsOnModule.framework/Modules/module.modulemap () 
- (renamed) 
clang/test/Modules/Inputs/DependsOnModule.framework/Modules/module.private.modulemap
 () 
- (renamed) 
clang/test/Modules/Inputs/GNUAsm/NeedsGNUInlineAsm.framework/Modules/module.modulemap
 () 
- (renamed) clang/test/Modules/Inputs/Modified/module.modulemap () 
- (renamed) clang/test/Modules/Inputs/ModuleDiags/module.modulemap () 
- (added) clang/test/Modules/Inputs/ModuleMapLocations/Module_Map/a.h (+1) 
- (added) clang/test/Modules/Inputs/ModuleMapLocations/Module_Map/module.map 
(+3) 
- (added) 
clang/test/Modules/Inputs/ModuleMapLocations/Module_Map/module_private.map (+3) 
- (added) clang/test/Modules/Inputs/ModuleMapLocations/Module_Map/private.h () 
- (added) 
clang/test/Modules/Inputs/ModuleMapLocations/Module_Map_F.framework/Headers/a.h 
() 
- (added) 
clang/test/Modules/Inputs/ModuleMapLocations/Module_Map_F.framework/PrivateHeaders/private.h
 () 
- (added) 
clang/test/Modules/Inputs/ModuleMapLocations/Module_Map_F.framework/module.map 
(+3) 
- (added) 
clang/test/Modules/Inputs/ModuleMapLocations/Module_Map_F.framework/module_private.map
 (+3) 
- (renamed) 
clang/test/Modules/Inputs/NoUmbrella.framework/Modules/module.modulemap () 
- (renamed) 
clang/test/Modules/Inputs/NoUmbrella.framework/Modules/module.private.modulemap 
() 
- (renamed) clang/test/Modules/Inputs/StdDef/module.modulemap () 
- (renamed) clang/test/Modules/Inputs/System/usr/include/module.modulemap () 
- (renamed) clang/test/Modules/Inputs/UseAfterFree/module.modulemap () 
- (renamed) clang/test/Modules/Inputs/UseAfterFree/module.private.modulemap () 
- (renamed) 
clang/test/Modules/Inputs/crash-recovery/usr/include/module.modulemap () 
- (renamed) clang/test/Modules/Inputs/declare-use/module.modulemap () 
- (renamed) clang/test/Modules/Inputs/elsewhere/module.modulemap () 
- (renamed) clang/test/Modules/Inputs/exclude-header/module.modulemap () 
- (renamed) 
clang/test/Modules/Inputs/implicit-private-without-public/DeprecatedModuleMapLocation.framework/module.private.modulemap
 () 
- (renamed) clang/test/Modules/Inputs/include-relative/module.modulemap () 
- (renamed) clang/test/Modules/Inputs/lookup-assert-protocol/module.modulemap 
() 
- (renamed) clang/test/Modules/Inputs/lookup-assert/module.modulemap () 
- (renamed) clang/test/Modules/Inputs/macro-undef-through-pch/module.modulemap 
() 
- (renamed) clang/test/Modules/Inputs/malformed/module.modulemap () 
- (renamed) clang/test/Modules/Inputs/module.modulemap () 
- (renamed)