[clang] [llvm] Reland "[X86] Remove knl/knm specific ISAs supports (#92883)" (PR #93136)

2024-05-23 Thread Freddy Ye via cfe-commits 

https://github.com/FreddyLeaf closed 
https://github.com/llvm/llvm-project/pull/93136
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] Reland "[X86] Remove knl/knm specific ISAs supports (#92883)" (PR #93136)

2024-05-23 Thread Phoebe Wang via cfe-commits 

https://github.com/phoebewang approved this pull request.

LGTM.

https://github.com/llvm/llvm-project/pull/93136
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] Reland "[X86] Remove knl/knm specific ISAs supports (#92883)" (PR #93136)

2024-05-23 Thread Freddy Ye via cfe-commits 

FreddyLeaf wrote:

> Not sure - CI checks aren't running either

Woops, I was thinking that is CI checks. I was just wondering for CI checks. 
Now it's recovered. Thanks anyway!

https://github.com/llvm/llvm-project/pull/93136
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] Reland "[X86] Remove knl/knm specific ISAs supports (#92883)" (PR #93136)

2024-05-23 Thread Simon Pilgrim via cfe-commits 

RKSimon wrote:

Not sure - CI checks aren't running either

https://github.com/llvm/llvm-project/pull/93136
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] Reland "[X86] Remove knl/knm specific ISAs supports (#92883)" (PR #93136)

2024-05-23 Thread Freddy Ye via cfe-commits 

FreddyLeaf wrote:

any idea on why `Labelling new pull requests / greeter (pull_request_target)` 
is **skipped**? @phoebewang @RKSimon 

https://github.com/llvm/llvm-project/pull/93136
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] Reland "[X86] Remove knl/knm specific ISAs supports (#92883)" (PR #93136)

2024-05-22 Thread via cfe-commits 

llvmbot wrote:



@llvm/pr-subscribers-llvm-ir

@llvm/pr-subscribers-clang

Author: Freddy Ye (FreddyLeaf)


Changes

This reverts commit aa4069ea96e5eb62bc8c7895b9d920f129611b3a.


---

Patch is 141.63 KiB, truncated to 20.00 KiB below, full version: 
https://github.com/llvm/llvm-project/pull/93136.diff


53 Files Affected:

- (modified) clang/docs/ReleaseNotes.rst (+2) 
- (modified) clang/include/clang/Basic/BuiltinsX86.def (-21) 
- (modified) clang/include/clang/Basic/DiagnosticCommonKinds.td (-3) 
- (modified) clang/include/clang/Driver/Options.td (-6) 
- (modified) clang/lib/Basic/Targets/X86.cpp (-21) 
- (modified) clang/lib/Basic/Targets/X86.h (-3) 
- (modified) clang/lib/Headers/CMakeLists.txt (-2) 
- (removed) clang/lib/Headers/avx512erintrin.h (-271) 
- (removed) clang/lib/Headers/avx512pfintrin.h (-92) 
- (modified) clang/lib/Headers/immintrin.h (-8) 
- (modified) clang/lib/Headers/module.modulemap (-1) 
- (modified) clang/lib/Sema/SemaChecking.cpp (-30) 
- (removed) clang/test/CodeGen/X86/avx512er-builtins.c (-347) 
- (removed) clang/test/CodeGen/X86/avx512pf-builtins.c (-100) 
- (modified) clang/test/CodeGen/attr-cpuspecific.c (+5-5) 
- (modified) clang/test/CodeGen/attr-target-x86.c (+2-2) 
- (modified) clang/test/CodeGen/function-target-features.c (+2-2) 
- (modified) clang/test/CodeGen/target-builtin-noerror.c (-2) 
- (modified) clang/test/Driver/cl-x86-flags.c (+2-8) 
- (modified) clang/test/Driver/x86-target-features.c (+4-9) 
- (modified) clang/test/Frontend/x86-target-cpu.c (+2-8) 
- (modified) clang/test/Preprocessor/predefined-arch-macros.c (-12) 
- (modified) clang/test/Preprocessor/x86_target_features.c (-50) 
- (modified) clang/test/Sema/builtins-x86.c (-8) 
- (modified) llvm/docs/ReleaseNotes.rst (+3) 
- (modified) llvm/include/llvm/IR/IntrinsicsX86.td (-84) 
- (modified) llvm/include/llvm/TargetParser/X86TargetParser.def (+3-6) 
- (modified) llvm/lib/Target/X86/X86.td (-12) 
- (modified) llvm/lib/Target/X86/X86ISelLowering.cpp (-10) 
- (modified) llvm/lib/Target/X86/X86ISelLowering.h (-12) 
- (modified) llvm/lib/Target/X86/X86Instr3DNow.td (+1-2) 
- (modified) llvm/lib/Target/X86/X86InstrAVX512.td (+75-16) 
- (modified) llvm/lib/Target/X86/X86InstrFragments.td (+1-7) 
- (modified) llvm/lib/Target/X86/X86InstrFragmentsSIMD.td (-11) 
- (modified) llvm/lib/Target/X86/X86InstrPredicates.td (-3) 
- (modified) llvm/lib/Target/X86/X86IntrinsicsInfo.h (-27) 
- (modified) llvm/lib/Target/X86/X86Subtarget.h (+3-5) 
- (modified) llvm/lib/TargetParser/Host.cpp (-9) 
- (modified) llvm/lib/TargetParser/X86TargetParser.cpp (+3-3) 
- (modified) llvm/test/CodeGen/X86/avx512-cmp-kor-sequence.ll (+1-1) 
- (modified) llvm/test/CodeGen/X86/avx512-gather-scatter-intrin-deprecated.ll 
(-24) 
- (modified) llvm/test/CodeGen/X86/avx512-gather-scatter-intrin.ll (-24) 
- (removed) llvm/test/CodeGen/X86/avx512er-intrinsics.ll (-306) 
- (modified) llvm/test/CodeGen/X86/crc32-target-feature.ll (+2-2) 
- (modified) llvm/test/CodeGen/X86/insert-prefetch-invalid-instr.ll (+1-6) 
- (modified) llvm/test/CodeGen/X86/prefetch.ll (-17) 
- (modified) llvm/test/CodeGen/X86/speculative-load-hardening-gather.ll (-22) 
- (modified) llvm/test/CodeGen/X86/unfoldMemoryOperand.mir (+1-1) 
- (modified) llvm/test/Transforms/LoopStrengthReduce/X86/pr40514.ll (+1-1) 
- (modified) llvm/test/Transforms/LoopVectorize/X86/pr23997.ll (+1-1) 
- (modified) llvm/test/Transforms/LoopVectorize/X86/pr54634.ll (+1-1) 
- (modified) llvm/test/Transforms/LoopVectorize/X86/scatter_crash.ll (+1-1) 
- (modified) llvm/test/Transforms/SLPVectorizer/X86/vector_gep.ll (+1-1) 


``diff
diff --git a/clang/docs/ReleaseNotes.rst b/clang/docs/ReleaseNotes.rst
index 0c4a343b70009..d410d8acd135b 100644
--- a/clang/docs/ReleaseNotes.rst
+++ b/clang/docs/ReleaseNotes.rst
@@ -801,6 +801,8 @@ AMDGPU Support
 X86 Support
 ^^^
 
+- Remove knl/knm specific ISA supports: AVX512PF, AVX512ER, PREFETCHWT1
+
 Arm and AArch64 Support
 ^^^
 
diff --git a/clang/include/clang/Basic/BuiltinsX86.def 
b/clang/include/clang/Basic/BuiltinsX86.def
index eafcc219c1096..7074479786b97 100644
--- a/clang/include/clang/Basic/BuiltinsX86.def
+++ b/clang/include/clang/Basic/BuiltinsX86.def
@@ -832,23 +832,11 @@ TARGET_BUILTIN(__builtin_ia32_rsqrt14ss_mask, 
"V4fV4fV4fV4fUc", "ncV:128:", "avx
 TARGET_BUILTIN(__builtin_ia32_rsqrt14pd512_mask, "V8dV8dV8dUc", "ncV:512:", 
"avx512f,evex512")
 TARGET_BUILTIN(__builtin_ia32_rsqrt14ps512_mask, "V16fV16fV16fUs", "ncV:512:", 
"avx512f,evex512")
 
-TARGET_BUILTIN(__builtin_ia32_rsqrt28sd_round_mask, "V2dV2dV2dV2dUcIi", 
"ncV:128:", "avx512er")
-TARGET_BUILTIN(__builtin_ia32_rsqrt28ss_round_mask, "V4fV4fV4fV4fUcIi", 
"ncV:128:", "avx512er")
-TARGET_BUILTIN(__builtin_ia32_rsqrt28pd_mask, "V8dV8dV8dUcIi", "ncV:512:", 
"avx512er,evex512")
-TARGET_BUILTIN(__builtin_ia32_rsqrt28ps_mask, "V16fV16fV16fUsIi", "ncV:512:", 
"avx512er,evex512")
-
 TARGET_BUILTIN(__builtin_ia32_rcp14sd_mask, "V2dV2dV2dV2dUc", "ncV:128:",