[clang] [llvm] Remove experimental from Vector Crypto extensions (PR #69000)

[Eric Biggers via cfe-commits]

ebiggers wrote:

At 
https://github.com/ebiggers/llvm-project/tree/remove_experimental_from_vector_crypto
 I've rebased this pull request, squashed the commits, resolved conflicts, 
fixed the Zvkn duplication, and run `git clang-format`.  Note, it was necessary 
to change the type of `enum RVVRequire` from `uint16_t` to `unsigned int` 
because the next flag is now `1 << 16`, and to remove `experimental-` from some 
new files in `llvm/test/Transforms/` where references to the crypto extensions 
had been added.  @4vtomat can you update your pull request accordingly?  Feel 
free to reuse what I have.  Thanks!

https://github.com/llvm/llvm-project/pull/69000
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] Remove experimental from Vector Crypto extensions (PR #69000)

[Brandon Wu via cfe-commits]

4vtomat wrote:

This update add "experimental" to `RISCVFeatures.td`, also add a member 
variable `HasExperimental` to record whether the target has this feature.

https://github.com/llvm/llvm-project/pull/69000
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] Remove experimental from Vector Crypto extensions (PR #69000)

[Brandon Wu via cfe-commits]

4vtomat wrote:

> Do we need to add the "experimental" feature to RISCVFeatures.td? If the 
> feature string shows up in the function attributes, won't the backend print 
> that it doesn't recognize the feature name when it parses the string?

Yes, we do, I forgot it lol~

https://github.com/llvm/llvm-project/pull/69000
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] Remove experimental from Vector Crypto extensions (PR #69000)

[Kito Cheng via cfe-commits]

@@ -106,6 +106,8 @@ static const RISCVSupportedExtension SupportedExtensions[] 
= {
 
 {"zdinx", RISCVExtensionVersion{1, 0}},
 
+{"zexperimental", RISCVExtensionVersion{1, 0}},
+

kito-cheng wrote:

I guess we don't really need this dummy extension in RISCVISAInfo?

https://github.com/llvm/llvm-project/pull/69000
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] Remove experimental from Vector Crypto extensions (PR #69000)

[Brandon Wu via cfe-commits]

4vtomat wrote:

Since it's possible that **ISA spec** and **intrinsics spec** are not 
synchronized, so the updates add an dummy extension called **zexperimental**, 
once `-menable-experimental-extensions` is specified, the feature 
`zexperimental` is automatically added.
If specifying `let RequiredFeatures = ["Zexperimental"] ` is added in `.td` 
file, it will check if `zexperimental` exists, if not, the corresponding 
intrinsics would not be added, hence causing an **intrinsics undeclared** error.

https://github.com/llvm/llvm-project/pull/69000
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits