llvmbot wrote:
@llvm/pr-subscribers-coroutines
@llvm/pr-subscribers-backend-systemz
Author: Akira Hatanaka (ahatanak)
Changes
This reverts commit 8bd1f9116aab879183f34707e6d21c7051d083b6.
It appears that the commit broke msan bots.
---
Patch is 350.82 KiB, truncated to 20.00 KiB below, full version:
https://github.com/llvm/llvm-project/pull/86674.diff
50 Files Affected:
- (modified) clang/lib/CodeGen/ABIInfoImpl.cpp (+5-5)
- (modified) clang/lib/CodeGen/Address.h (+28-167)
- (modified) clang/lib/CodeGen/CGAtomic.cpp (+25-28)
- (modified) clang/lib/CodeGen/CGBlocks.cpp (+15-19)
- (modified) clang/lib/CodeGen/CGBlocks.h (+1-2)
- (modified) clang/lib/CodeGen/CGBuilder.h (+74-160)
- (modified) clang/lib/CodeGen/CGBuiltin.cpp (+83-90)
- (modified) clang/lib/CodeGen/CGCUDANV.cpp (+9-10)
- (modified) clang/lib/CodeGen/CGCXXABI.cpp (+6-15)
- (modified) clang/lib/CodeGen/CGCXXABI.h (+12-2)
- (modified) clang/lib/CodeGen/CGCall.cpp (+74-97)
- (modified) clang/lib/CodeGen/CGCall.h (-1)
- (modified) clang/lib/CodeGen/CGClass.cpp (+31-45)
- (modified) clang/lib/CodeGen/CGCleanup.cpp (+69-41)
- (modified) clang/lib/CodeGen/CGCleanup.h (+1-1)
- (modified) clang/lib/CodeGen/CGCoroutine.cpp (+2-2)
- (modified) clang/lib/CodeGen/CGDecl.cpp (+12-16)
- (modified) clang/lib/CodeGen/CGException.cpp (+8-11)
- (modified) clang/lib/CodeGen/CGExpr.cpp (+108-119)
- (modified) clang/lib/CodeGen/CGExprAgg.cpp (+13-16)
- (modified) clang/lib/CodeGen/CGExprCXX.cpp (+60-51)
- (modified) clang/lib/CodeGen/CGExprConstant.cpp (+2-2)
- (modified) clang/lib/CodeGen/CGExprScalar.cpp (+4-19)
- (modified) clang/lib/CodeGen/CGNonTrivialStruct.cpp (+4-4)
- (modified) clang/lib/CodeGen/CGObjC.cpp (+24-19)
- (modified) clang/lib/CodeGen/CGObjCGNU.cpp (+20-22)
- (modified) clang/lib/CodeGen/CGObjCMac.cpp (+47-48)
- (modified) clang/lib/CodeGen/CGObjCRuntime.cpp (+3-3)
- (modified) clang/lib/CodeGen/CGOpenMPRuntime.cpp (+92-102)
- (modified) clang/lib/CodeGen/CGOpenMPRuntime.h (+3-2)
- (modified) clang/lib/CodeGen/CGOpenMPRuntimeGPU.cpp (+37-39)
- (modified) clang/lib/CodeGen/CGStmt.cpp (+4-4)
- (modified) clang/lib/CodeGen/CGStmtOpenMP.cpp (+42-45)
- (modified) clang/lib/CodeGen/CGVTables.cpp (+5-4)
- (modified) clang/lib/CodeGen/CGValue.h (+125-124)
- (modified) clang/lib/CodeGen/CodeGenFunction.cpp (+29-42)
- (modified) clang/lib/CodeGen/CodeGenFunction.h (+71-186)
- (modified) clang/lib/CodeGen/CodeGenModule.cpp (+1-1)
- (modified) clang/lib/CodeGen/CodeGenPGO.cpp (+4-6)
- (modified) clang/lib/CodeGen/CodeGenPGO.h (+2-4)
- (modified) clang/lib/CodeGen/ItaniumCXXABI.cpp (+30-22)
- (modified) clang/lib/CodeGen/MicrosoftCXXABI.cpp (+35-23)
- (modified) clang/lib/CodeGen/TargetInfo.h (-5)
- (modified) clang/lib/CodeGen/Targets/NVPTX.cpp (+1-1)
- (modified) clang/lib/CodeGen/Targets/PPC.cpp (+5-6)
- (modified) clang/lib/CodeGen/Targets/Sparc.cpp (+1-1)
- (modified) clang/lib/CodeGen/Targets/SystemZ.cpp (+5-4)
- (modified) clang/lib/CodeGen/Targets/XCore.cpp (+1-1)
- (modified) clang/utils/TableGen/MveEmitter.cpp (+1-1)
- (modified) llvm/include/llvm/IR/IRBuilder.h (-1)
``diff
diff --git a/clang/lib/CodeGen/ABIInfoImpl.cpp
b/clang/lib/CodeGen/ABIInfoImpl.cpp
index 1dc76065a35572..2b20d5a13346d3 100644
--- a/clang/lib/CodeGen/ABIInfoImpl.cpp
+++ b/clang/lib/CodeGen/ABIInfoImpl.cpp
@@ -187,7 +187,7 @@ CodeGen::emitVoidPtrDirectVAArg(CodeGenFunction ,
Address VAListAddr,
CharUnits FullDirectSize = DirectSize.alignTo(SlotSize);
Address NextPtr =
CGF.Builder.CreateConstInBoundsByteGEP(Addr, FullDirectSize,
"argp.next");
- CGF.Builder.CreateStore(NextPtr.emitRawPointer(CGF), VAListAddr);
+ CGF.Builder.CreateStore(NextPtr.getPointer(), VAListAddr);
// If the argument is smaller than a slot, and this is a big-endian
// target, the argument will be right-adjusted in its slot.
@@ -239,8 +239,8 @@ Address CodeGen::emitMergePHI(CodeGenFunction , Address
Addr1,
const llvm::Twine ) {
assert(Addr1.getType() == Addr2.getType());
llvm::PHINode *PHI = CGF.Builder.CreatePHI(Addr1.getType(), 2, Name);
- PHI->addIncoming(Addr1.emitRawPointer(CGF), Block1);
- PHI->addIncoming(Addr2.emitRawPointer(CGF), Block2);
+ PHI->addIncoming(Addr1.getPointer(), Block1);
+ PHI->addIncoming(Addr2.getPointer(), Block2);
CharUnits Align = std::min(Addr1.getAlignment(), Addr2.getAlignment());
return Address(PHI, Addr1.getElementType(), Align);
}
@@ -400,7 +400,7 @@ Address CodeGen::EmitVAArgInstr(CodeGenFunction ,
Address VAListAddr,
llvm::Type *ElementTy = CGF.ConvertTypeForMem(Ty);
llvm::Type *BaseTy = llvm::PointerType::getUnqual(ElementTy);
llvm::Value *Addr =
-CGF.Builder.CreateVAArg(VAListAddr.emitRawPointer(CGF), BaseTy);
+CGF.Builder.CreateVAArg(VAListAddr.getPointer(), BaseTy);
return Address(Addr, ElementTy, TyAlignForABI);
} else {
assert((AI.isDirect() || AI.isExtend()) &&
@@ -416,7
