Re: [clang] 46a5693 - [FlowSensitive] Fix warnings

2023-12-08 Thread Aaron Ballman via cfe-commits
Thank you for the fix, sorry for the trouble!

~Aaron

On Fri, Dec 8, 2023 at 10:56 AM Kazu Hirata via cfe-commits
 wrote:
>
>
> Author: Kazu Hirata
> Date: 2023-12-08T07:56:45-08:00
> New Revision: 46a56931251eba767929f6a2110da5b1bcbc5eb9
>
> URL: 
> https://github.com/llvm/llvm-project/commit/46a56931251eba767929f6a2110da5b1bcbc5eb9
> DIFF: 
> https://github.com/llvm/llvm-project/commit/46a56931251eba767929f6a2110da5b1bcbc5eb9.diff
>
> LOG: [FlowSensitive] Fix warnings
>
> This patch fixes:
>
>   clang/lib/Analysis/FlowSensitive/HTMLLogger.cpp:376:22: error:
>   comparison of integers of different signs: 'unsigned int' and
>   'TokenInfo::(unnamed enum at
>   clang/lib/Analysis/FlowSensitive/HTMLLogger.cpp:356:7)'
>   [-Werror,-Wsign-compare]
>
>   clang/lib/Analysis/FlowSensitive/HTMLLogger.cpp:385:23: error:
>   comparison of integers of different signs: 'unsigned int' and
>   'TokenInfo::(unnamed enum at
>   clang/lib/Analysis/FlowSensitive/HTMLLogger.cpp:356:7)'
>   [-Werror,-Wsign-compare]
>
> etc
>
> Added:
>
>
> Modified:
> clang/lib/Analysis/FlowSensitive/HTMLLogger.cpp
>
> Removed:
>
>
>
> 
> diff  --git a/clang/lib/Analysis/FlowSensitive/HTMLLogger.cpp 
> b/clang/lib/Analysis/FlowSensitive/HTMLLogger.cpp
> index baa099d2f3fcf..2a7bfce535015 100644
> --- a/clang/lib/Analysis/FlowSensitive/HTMLLogger.cpp
> +++ b/clang/lib/Analysis/FlowSensitive/HTMLLogger.cpp
> @@ -353,7 +353,7 @@ class HTMLLogger : public Logger {
>
>  // TokenInfo stores the BB and set of elements that a token is part of.
>  struct TokenInfo {
> -  enum { Missing = -1 };
> +  enum : unsigned { Missing = static_cast(-1) };
>
>// The basic block this is part of.
>// This is the BB of the stmt with the smallest containing range.
>
>
>
> ___
> cfe-commits mailing list
> cfe-commits@lists.llvm.org
> https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits


[clang] 46a5693 - [FlowSensitive] Fix warnings

2023-12-08 Thread Kazu Hirata via cfe-commits

Author: Kazu Hirata
Date: 2023-12-08T07:56:45-08:00
New Revision: 46a56931251eba767929f6a2110da5b1bcbc5eb9

URL: 
https://github.com/llvm/llvm-project/commit/46a56931251eba767929f6a2110da5b1bcbc5eb9
DIFF: 
https://github.com/llvm/llvm-project/commit/46a56931251eba767929f6a2110da5b1bcbc5eb9.diff

LOG: [FlowSensitive] Fix warnings

This patch fixes:

  clang/lib/Analysis/FlowSensitive/HTMLLogger.cpp:376:22: error:
  comparison of integers of different signs: 'unsigned int' and
  'TokenInfo::(unnamed enum at
  clang/lib/Analysis/FlowSensitive/HTMLLogger.cpp:356:7)'
  [-Werror,-Wsign-compare]

  clang/lib/Analysis/FlowSensitive/HTMLLogger.cpp:385:23: error:
  comparison of integers of different signs: 'unsigned int' and
  'TokenInfo::(unnamed enum at
  clang/lib/Analysis/FlowSensitive/HTMLLogger.cpp:356:7)'
  [-Werror,-Wsign-compare]

etc

Added: 


Modified: 
clang/lib/Analysis/FlowSensitive/HTMLLogger.cpp

Removed: 




diff  --git a/clang/lib/Analysis/FlowSensitive/HTMLLogger.cpp 
b/clang/lib/Analysis/FlowSensitive/HTMLLogger.cpp
index baa099d2f3fcf..2a7bfce535015 100644
--- a/clang/lib/Analysis/FlowSensitive/HTMLLogger.cpp
+++ b/clang/lib/Analysis/FlowSensitive/HTMLLogger.cpp
@@ -353,7 +353,7 @@ class HTMLLogger : public Logger {
 
 // TokenInfo stores the BB and set of elements that a token is part of.
 struct TokenInfo {
-  enum { Missing = -1 };
+  enum : unsigned { Missing = static_cast(-1) };
 
   // The basic block this is part of.
   // This is the BB of the stmt with the smallest containing range.



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits