[clang] Fix build dllexport/dllimport issues when doing a shared build for Windows using GCC (PR #66881)

[Martin Storsjö via cfe-commits]

mstorsjo wrote:

> This is superseded by https://github.com/llvm/llvm-project/pull/71393 which 
> was merged now.

I'll close this one for now, as I believe the issue has been fixed differently.

https://github.com/llvm/llvm-project/pull/66881
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Fix build dllexport/dllimport issues when doing a shared build for Windows using GCC (PR #66881)

[Martin Storsjö via cfe-commits]

https://github.com/mstorsjo closed 
https://github.com/llvm/llvm-project/pull/66881
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Fix build dllexport/dllimport issues when doing a shared build for Windows using GCC (PR #66881)

[Martin Storsjö via cfe-commits]

mstorsjo wrote:

This is superseded by #71393 which was merged now.

https://github.com/llvm/llvm-project/pull/66881
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Fix build dllexport/dllimport issues when doing a shared build for Windows using GCC (PR #66881)

[Martin Storsjö via cfe-commits]

mstorsjo wrote:

Thanks, I wasn't aware of this issue (I don't routinely try building with 
`-DBUILD_SHARED_LIBS=ON`, which I presume is what you've done to trigger this). 
See 592e935e115ffb451eb9b782376711dab6558fe0 for earlier context on this issue; 
therefore I'd prefer to fix this as I do in #71393; can you confirm if that 
change works for you as well?

https://github.com/llvm/llvm-project/pull/66881
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Fix build dllexport/dllimport issues when doing a shared build for Windows using GCC (PR #66881)

[Brecht Sanders via cfe-commits]

https://github.com/brechtsanders created 
https://github.com/llvm/llvm-project/pull/66881

Fix build dllexport/dllimport issues when doing a shared build for Windows 
using GCC

>From b524ba27418a78a7314af53d36adefb947f2960d Mon Sep 17 00:00:00 2001
From: Brecht Sanders 
Date: Wed, 20 Sep 2023 11:48:54 +0200
Subject: [PATCH] Update Interpreter.h

Fix build dllexport/dllimport issues when doing a shared build for Windows
---
 clang/include/clang/Interpreter/Interpreter.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/clang/include/clang/Interpreter/Interpreter.h 
b/clang/include/clang/Interpreter/Interpreter.h
index 43573fb1a4b8915..e8a8745919a33aa 100644
--- a/clang/include/clang/Interpreter/Interpreter.h
+++ b/clang/include/clang/Interpreter/Interpreter.h
@@ -40,7 +40,7 @@ class IncrementalExecutor;
 class IncrementalParser;
 
 /// Create a pre-configured \c CompilerInstance for incremental processing.
-class IncrementalCompilerBuilder {
+class REPL_EXTERNAL_VISIBILITY IncrementalCompilerBuilder {
 public:
   IncrementalCompilerBuilder() {}
 
@@ -73,7 +73,7 @@ class IncrementalCompilerBuilder {
 };
 
 /// Provides top-level interfaces for incremental compilation and execution.
-class Interpreter {
+class REPL_EXTERNAL_VISIBILITY Interpreter {
   std::unique_ptr TSCtx;
   std::unique_ptr IncrParser;
   std::unique_ptr IncrExecutor;

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits