llvmbot wrote:
@llvm/pr-subscribers-clang-codegen
@llvm/pr-subscribers-clang
Author: Justin Bogner (bogner)
Changes
After 11a6799740f8 "[clang][CodeGen] Omit pre-opt link when post-opt is link
requested (#85672)" I'm seeing a new warning:
BackendConsumer.h:37:22: error: private field 'FileMgr' is not used
[-Werror,-Wunused-private-field]
Remove the field since it's no longer used.
---
Full diff: https://github.com/llvm/llvm-project/pull/91500.diff
2 Files Affected:
- (modified) clang/lib/CodeGen/BackendConsumer.h (+3-4)
- (modified) clang/lib/CodeGen/CodeGenAction.cpp (+8-11)
``diff
diff --git a/clang/lib/CodeGen/BackendConsumer.h
b/clang/lib/CodeGen/BackendConsumer.h
index f9edbe901bb8..0fe9929dca2b 100644
--- a/clang/lib/CodeGen/BackendConsumer.h
+++ b/clang/lib/CodeGen/BackendConsumer.h
@@ -34,7 +34,6 @@ class BackendConsumer : public ASTConsumer {
const CodeGenOptions
const TargetOptions
const LangOptions
- const FileManager
std::unique_ptr AsmOutStream;
ASTContext *Context;
IntrusiveRefCntPtr FS;
@@ -76,7 +75,7 @@ class BackendConsumer : public ASTConsumer {
const PreprocessorOptions ,
const CodeGenOptions ,
const TargetOptions , const LangOptions ,
- const FileManager , const std::string ,
+ const std::string ,
SmallVector LinkModules,
std::unique_ptr OS, llvm::LLVMContext ,
CoverageSourceInfo *CoverageInfo = nullptr);
@@ -90,8 +89,8 @@ class BackendConsumer : public ASTConsumer {
const PreprocessorOptions ,
const CodeGenOptions ,
const TargetOptions , const LangOptions ,
- const FileManager , llvm::Module *Module,
- SmallVector LinkModules, llvm::LLVMContext ,
+ llvm::Module *Module, SmallVector LinkModules,
+ llvm::LLVMContext ,
CoverageSourceInfo *CoverageInfo = nullptr);
llvm::Module *getModule() const;
diff --git a/clang/lib/CodeGen/CodeGenAction.cpp
b/clang/lib/CodeGen/CodeGenAction.cpp
index 0255f05b1f90..6d3efdb5ffe3 100644
--- a/clang/lib/CodeGen/CodeGenAction.cpp
+++ b/clang/lib/CodeGen/CodeGenAction.cpp
@@ -114,13 +114,12 @@ BackendConsumer::BackendConsumer(
const HeaderSearchOptions ,
const PreprocessorOptions , const CodeGenOptions ,
const TargetOptions , const LangOptions ,
-const FileManager , const std::string ,
-SmallVector LinkModules,
+const std::string , SmallVector LinkModules,
std::unique_ptr OS, LLVMContext ,
CoverageSourceInfo *CoverageInfo)
: Diags(Diags), Action(Action), HeaderSearchOpts(HeaderSearchOpts),
CodeGenOpts(CodeGenOpts), TargetOpts(TargetOpts), LangOpts(LangOpts),
- FileMgr(FileMgr), AsmOutStream(std::move(OS)), Context(nullptr), FS(VFS),
+ AsmOutStream(std::move(OS)), Context(nullptr), FS(VFS),
LLVMIRGeneration("irgen", "LLVM IR Generation Time"),
LLVMIRGenerationRefCount(0),
Gen(CreateLLVMCodeGen(Diags, InFile, std::move(VFS), HeaderSearchOpts,
@@ -140,12 +139,11 @@ BackendConsumer::BackendConsumer(
const HeaderSearchOptions ,
const PreprocessorOptions , const CodeGenOptions ,
const TargetOptions , const LangOptions ,
-const FileManager , llvm::Module *Module,
-SmallVector LinkModules, LLVMContext ,
-CoverageSourceInfo *CoverageInfo)
+llvm::Module *Module, SmallVector LinkModules,
+LLVMContext , CoverageSourceInfo *CoverageInfo)
: Diags(Diags), Action(Action), HeaderSearchOpts(HeaderSearchOpts),
CodeGenOpts(CodeGenOpts), TargetOpts(TargetOpts), LangOpts(LangOpts),
- FileMgr(FileMgr), Context(nullptr), FS(VFS),
+ Context(nullptr), FS(VFS),
LLVMIRGeneration("irgen", "LLVM IR Generation Time"),
LLVMIRGenerationRefCount(0),
Gen(CreateLLVMCodeGen(Diags, "", std::move(VFS), HeaderSearchOpts,
PPOpts,
@@ -1022,9 +1020,8 @@ CodeGenAction::CreateASTConsumer(CompilerInstance ,
StringRef InFile) {
std::unique_ptr Result(new BackendConsumer(
BA, CI.getDiagnostics(), (),
CI.getHeaderSearchOpts(), CI.getPreprocessorOpts(), CI.getCodeGenOpts(),
- CI.getTargetOpts(), CI.getLangOpts(), CI.getFileManager(),
- std::string(InFile), std::move(LinkModules), std::move(OS), *VMContext,
- CoverageInfo));
+ CI.getTargetOpts(), CI.getLangOpts(), std::string(InFile),
+ std::move(LinkModules), std::move(OS), *VMContext, CoverageInfo));
BEConsumer = Result.get();
// Enable generating macro debug info only when debug info is not disabled
and
@@ -1195,7 +1192,7 @@ void CodeGenAction::ExecuteAction() {
BackendConsumer Result(BA, CI.getDiagnostics(), (),
CI.getHeaderSearchOpts(), CI.getPreprocessorOpts(),
CI.getCodeGenOpts(), CI.getTargetOpts(),
- CI.getLangOpts(),
