Re: [clang-tools-extra] r304583 - [clang-tidy] Add `const` to operator() to fix a warning.

[Kim Gräsman via cfe-commits]

This is even an error in VS2017, I've just fixed a number of instances of
this in an internal codebase.

- Kim

Den 6 juni 2017 4:32 em skrev "Alexander Kornienko via cfe-commits" <
cfe-commits@lists.llvm.org>:

> On Mon, Jun 5, 2017 at 7:11 PM, David Blaikie  wrote:
>
>> what was the warning?
>>
>
> I don't remember the exact warning text, but the idea was that a non-const
> operator() could not be called. The change is reasonable in any case: the
> operator() here has no reason to be non-const.
>
>
>>
>> On Fri, Jun 2, 2017 at 11:48 AM Alexander Kornienko via cfe-commits <
>> cfe-commits@lists.llvm.org> wrote:
>>
>>> Author: alexfh
>>> Date: Fri Jun  2 13:47:50 2017
>>> New Revision: 304583
>>>
>>> URL: http://llvm.org/viewvc/llvm-project?rev=304583=rev
>>> Log:
>>> [clang-tidy] Add `const` to operator() to fix a warning.
>>>
>>> Modified:
>>> clang-tools-extra/trunk/clang-tidy/misc/LambdaFunctionNameCheck.h
>>>
>>> Modified: clang-tools-extra/trunk/clang-tidy/misc/LambdaFunctionNameCh
>>> eck.h
>>> URL: http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/
>>> clang-tidy/misc/LambdaFunctionNameCheck.h?rev=304583=
>>> 304582=304583=diff
>>> 
>>> ==
>>> --- clang-tools-extra/trunk/clang-tidy/misc/LambdaFunctionNameCheck.h
>>> (original)
>>> +++ clang-tools-extra/trunk/clang-tidy/misc/LambdaFunctionNameCheck.h
>>> Fri Jun  2 13:47:50 2017
>>> @@ -25,7 +25,7 @@ namespace misc {
>>>  class LambdaFunctionNameCheck : public ClangTidyCheck {
>>>  public:
>>>struct SourceRangeLessThan {
>>> -bool operator()(const SourceRange , const SourceRange ) {
>>> +bool operator()(const SourceRange , const SourceRange ) const {
>>>if (L.getBegin() == R.getBegin()) {
>>>  return L.getEnd() < R.getEnd();
>>>}
>>>
>>>
>>> ___
>>> cfe-commits mailing list
>>> cfe-commits@lists.llvm.org
>>> http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
>>>
>>
>
> ___
> cfe-commits mailing list
> cfe-commits@lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
>
>
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [clang-tools-extra] r304583 - [clang-tidy] Add `const` to operator() to fix a warning.

[Alexander Kornienko via cfe-commits]

On Mon, Jun 5, 2017 at 7:11 PM, David Blaikie  wrote:

> what was the warning?
>

I don't remember the exact warning text, but the idea was that a non-const
operator() could not be called. The change is reasonable in any case: the
operator() here has no reason to be non-const.


>
> On Fri, Jun 2, 2017 at 11:48 AM Alexander Kornienko via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
>> Author: alexfh
>> Date: Fri Jun  2 13:47:50 2017
>> New Revision: 304583
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=304583=rev
>> Log:
>> [clang-tidy] Add `const` to operator() to fix a warning.
>>
>> Modified:
>> clang-tools-extra/trunk/clang-tidy/misc/LambdaFunctionNameCheck.h
>>
>> Modified: clang-tools-extra/trunk/clang-tidy/misc/
>> LambdaFunctionNameCheck.h
>> URL: http://llvm.org/viewvc/llvm-project/clang-tools-extra/
>> trunk/clang-tidy/misc/LambdaFunctionNameCheck.h?rev=
>> 304583=304582=304583=diff
>> 
>> ==
>> --- clang-tools-extra/trunk/clang-tidy/misc/LambdaFunctionNameCheck.h
>> (original)
>> +++ clang-tools-extra/trunk/clang-tidy/misc/LambdaFunctionNameCheck.h
>> Fri Jun  2 13:47:50 2017
>> @@ -25,7 +25,7 @@ namespace misc {
>>  class LambdaFunctionNameCheck : public ClangTidyCheck {
>>  public:
>>struct SourceRangeLessThan {
>> -bool operator()(const SourceRange , const SourceRange ) {
>> +bool operator()(const SourceRange , const SourceRange ) const {
>>if (L.getBegin() == R.getBegin()) {
>>  return L.getEnd() < R.getEnd();
>>}
>>
>>
>> ___
>> cfe-commits mailing list
>> cfe-commits@lists.llvm.org
>> http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
>>
>
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [clang-tools-extra] r304583 - [clang-tidy] Add `const` to operator() to fix a warning.

[David Blaikie via cfe-commits]

what was the warning?

On Fri, Jun 2, 2017 at 11:48 AM Alexander Kornienko via cfe-commits <
cfe-commits@lists.llvm.org> wrote:

> Author: alexfh
> Date: Fri Jun  2 13:47:50 2017
> New Revision: 304583
>
> URL: http://llvm.org/viewvc/llvm-project?rev=304583=rev
> Log:
> [clang-tidy] Add `const` to operator() to fix a warning.
>
> Modified:
> clang-tools-extra/trunk/clang-tidy/misc/LambdaFunctionNameCheck.h
>
> Modified: clang-tools-extra/trunk/clang-tidy/misc/LambdaFunctionNameCheck.h
> URL:
> http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/clang-tidy/misc/LambdaFunctionNameCheck.h?rev=304583=304582=304583=diff
>
> ==
> --- clang-tools-extra/trunk/clang-tidy/misc/LambdaFunctionNameCheck.h
> (original)
> +++ clang-tools-extra/trunk/clang-tidy/misc/LambdaFunctionNameCheck.h Fri
> Jun  2 13:47:50 2017
> @@ -25,7 +25,7 @@ namespace misc {
>  class LambdaFunctionNameCheck : public ClangTidyCheck {
>  public:
>struct SourceRangeLessThan {
> -bool operator()(const SourceRange , const SourceRange ) {
> +bool operator()(const SourceRange , const SourceRange ) const {
>if (L.getBegin() == R.getBegin()) {
>  return L.getEnd() < R.getEnd();
>}
>
>
> ___
> cfe-commits mailing list
> cfe-commits@lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
>
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] r304583 - [clang-tidy] Add `const` to operator() to fix a warning.

[Alexander Kornienko via cfe-commits]

Author: alexfh
Date: Fri Jun  2 13:47:50 2017
New Revision: 304583

URL: http://llvm.org/viewvc/llvm-project?rev=304583=rev
Log:
[clang-tidy] Add `const` to operator() to fix a warning.

Modified:
clang-tools-extra/trunk/clang-tidy/misc/LambdaFunctionNameCheck.h

Modified: clang-tools-extra/trunk/clang-tidy/misc/LambdaFunctionNameCheck.h
URL: 
http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/clang-tidy/misc/LambdaFunctionNameCheck.h?rev=304583=304582=304583=diff
==
--- clang-tools-extra/trunk/clang-tidy/misc/LambdaFunctionNameCheck.h (original)
+++ clang-tools-extra/trunk/clang-tidy/misc/LambdaFunctionNameCheck.h Fri Jun  
2 13:47:50 2017
@@ -25,7 +25,7 @@ namespace misc {
 class LambdaFunctionNameCheck : public ClangTidyCheck {
 public:
   struct SourceRangeLessThan {
-bool operator()(const SourceRange , const SourceRange ) {
+bool operator()(const SourceRange , const SourceRange ) const {
   if (L.getBegin() == R.getBegin()) {
 return L.getEnd() < R.getEnd();
   }


___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits