Re: [clang-tools-extra] r363975 - [clang-tidy] Fail gracefully upon empty database fields

2019-06-21 Thread Serge Guelton via cfe-commits 
On Fri, Jun 21, 2019 at 08:16:42AM +, douglas.y...@sony.com wrote:
> Hi Serge,
> 
> The test you added here is failing on the PS4 Windows build bot, can you take 
> a look?

Sure, thanks for fwding it!

> http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/26513/steps/test/logs/stdio

The error message seems to be OS-dependant, I do have a ttrivial patch, do you 
have means to reproduce the issue?

-- serge

> FAIL: Clang Tools :: clang-tidy/empty-database.cpp (14917 of 50455)
>  TEST 'Clang Tools :: clang-tidy/empty-database.cpp' 
> FAILED 
> Script:
> --
> : 'RUN: at line 1';   not clang-tidy -p 
> C:\ps4-buildslave2\llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast\llvm.src\tools\clang\tools\extra\test\clang-tidy/Inputs/empty-database
>  
> C:\ps4-buildslave2\llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast\llvm.src\tools\clang\tools\extra\test\clang-tidy\empty-database.cpp
>  2>&1 | FileCheck 
> C:\ps4-buildslave2\llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast\llvm.src\tools\clang\tools\extra\test\clang-tidy\empty-database.cpp
> --
> Exit Code: 1
> 
> Command Output (stdout):
> --
> $ ":" "RUN: at line 1"
> $ "not" "clang-tidy" "-p" 
> "C:\ps4-buildslave2\llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast\llvm.src\tools\clang\tools\extra\test\clang-tidy/Inputs/empty-database"
>  
> "C:\ps4-buildslave2\llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast\llvm.src\tools\clang\tools\extra\test\clang-tidy\empty-database.cpp"
> note: command had no output on stdout or stderr
> error: command failed with exit status: 1
> $ "FileCheck" 
> "C:\ps4-buildslave2\llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast\llvm.src\tools\clang\tools\extra\test\clang-tidy\empty-database.cpp"
> # command stderr:
> C:\ps4-buildslave2\llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast\llvm.src\tools\clang\tools\extra\test\clang-tidy\empty-database.cpp:3:11:
>  error: CHECK: expected string not found in input
> 
> // CHECK: LLVM ERROR: Cannot chdir into ""!
> 
>   ^
> 
> :1:1: note: scanning from here
> 
> Skipping 
> C:\ps4-buildslave2\llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast\llvm.src\tools\clang\tools\extra\test\clang-tidy\empty-database.cpp.
>  Compile command not found.
> 
> ^
> 
> :1:150: note: possible intended match here
> 
> Skipping 
> C:\ps4-buildslave2\llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast\llvm.src\tools\clang\tools\extra\test\clang-tidy\empty-database.cpp.
>  Compile command not found.
> 
>   
>        ^
> 
> 
> error: command failed with exit status: 1
> 
> Douglas Yung
> 
> -Original Message-
> From: cfe-commits  On Behalf Of Serge 
> Guelton via cfe-commits
> Sent: Thursday, June 20, 2019 13:26
> To: cfe-commits@lists.llvm.org
> Subject: [clang-tools-extra] r363975 - [clang-tidy] Fail gracefully upon 
> empty database fields
> 
> Author: serge_sans_paille
> Date: Thu Jun 20 13:25:59 2019
> New Revision: 363975
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=363975=rev
> Log:
> [clang-tidy] Fail gracefully upon empty database fields
> 
> Fix bz#42281
> 
> Differential Revision: https://reviews.llvm.org/D63613
> 
> Added:
> clang-tools-extra/trunk/test/clang-tidy/empty-database/
> clang-tools-extra/trunk/test/clang-tidy/empty-database.cpp
> 
> clang-tools-extra/trunk/test/clang-tidy/empty-database/compile_commands.json
> 
> Added: clang-tools-extra/trunk/test/clang-tidy/empty-database.cpp
> URL: 
> http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/test/clang-tidy/empty-database.cpp?rev=363975=auto
> ==
> --- clang-tools-extra/trunk/test/clang-tidy/empty-database.cpp (added)
> +++ clang-tools-extra/trunk/test/clang-tidy/empty-database.cpp Thu Jun 20 
> 13:25:59 2019
> @@ -0,0 +1,3 @@
> +// RUN: not clang-tidy -p %S/empty-database %s 2>&1 | FileCheck %s
> +
> +// CHECK: LLVM ERROR: Cannot chdir into ""!
> 
> Added: 
> clang-tools-extra/trunk/test/clang-tidy/empty-database/compile_commands.json
> URL: 
> http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/test/clang-tidy/empty-database/compile_commands.json?rev=363975=auto
> ==
> --- 
> clang-tools-extra/trunk/test/clang-tidy/empty-database/compile_commands.json 
> (added)
> +++ 
> clang-tools-extra/tr

RE: [clang-tools-extra] r363975 - [clang-tidy] Fail gracefully upon empty database fields

2019-06-21 Thread via cfe-commits 
Hi Serge,

The test you added here is failing on the PS4 Windows build bot, can you take a 
look?

http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/26513/steps/test/logs/stdio

FAIL: Clang Tools :: clang-tidy/empty-database.cpp (14917 of 50455)
 TEST 'Clang Tools :: clang-tidy/empty-database.cpp' FAILED 

Script:
--
: 'RUN: at line 1';   not clang-tidy -p 
C:\ps4-buildslave2\llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast\llvm.src\tools\clang\tools\extra\test\clang-tidy/Inputs/empty-database
 
C:\ps4-buildslave2\llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast\llvm.src\tools\clang\tools\extra\test\clang-tidy\empty-database.cpp
 2>&1 | FileCheck 
C:\ps4-buildslave2\llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast\llvm.src\tools\clang\tools\extra\test\clang-tidy\empty-database.cpp
--
Exit Code: 1

Command Output (stdout):
--
$ ":" "RUN: at line 1"
$ "not" "clang-tidy" "-p" 
"C:\ps4-buildslave2\llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast\llvm.src\tools\clang\tools\extra\test\clang-tidy/Inputs/empty-database"
 
"C:\ps4-buildslave2\llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast\llvm.src\tools\clang\tools\extra\test\clang-tidy\empty-database.cpp"
note: command had no output on stdout or stderr
error: command failed with exit status: 1
$ "FileCheck" 
"C:\ps4-buildslave2\llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast\llvm.src\tools\clang\tools\extra\test\clang-tidy\empty-database.cpp"
# command stderr:
C:\ps4-buildslave2\llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast\llvm.src\tools\clang\tools\extra\test\clang-tidy\empty-database.cpp:3:11:
 error: CHECK: expected string not found in input

// CHECK: LLVM ERROR: Cannot chdir into ""!

  ^

:1:1: note: scanning from here

Skipping 
C:\ps4-buildslave2\llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast\llvm.src\tools\clang\tools\extra\test\clang-tidy\empty-database.cpp.
 Compile command not found.

^

:1:150: note: possible intended match here

Skipping 
C:\ps4-buildslave2\llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast\llvm.src\tools\clang\tools\extra\test\clang-tidy\empty-database.cpp.
 Compile command not found.


 ^


error: command failed with exit status: 1

Douglas Yung

-Original Message-
From: cfe-commits  On Behalf Of Serge 
Guelton via cfe-commits
Sent: Thursday, June 20, 2019 13:26
To: cfe-commits@lists.llvm.org
Subject: [clang-tools-extra] r363975 - [clang-tidy] Fail gracefully upon empty 
database fields

Author: serge_sans_paille
Date: Thu Jun 20 13:25:59 2019
New Revision: 363975

URL: http://llvm.org/viewvc/llvm-project?rev=363975=rev
Log:
[clang-tidy] Fail gracefully upon empty database fields

Fix bz#42281

Differential Revision: https://reviews.llvm.org/D63613

Added:
clang-tools-extra/trunk/test/clang-tidy/empty-database/
clang-tools-extra/trunk/test/clang-tidy/empty-database.cpp
clang-tools-extra/trunk/test/clang-tidy/empty-database/compile_commands.json

Added: clang-tools-extra/trunk/test/clang-tidy/empty-database.cpp
URL: 
http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/test/clang-tidy/empty-database.cpp?rev=363975=auto
==
--- clang-tools-extra/trunk/test/clang-tidy/empty-database.cpp (added)
+++ clang-tools-extra/trunk/test/clang-tidy/empty-database.cpp Thu Jun 20 
13:25:59 2019
@@ -0,0 +1,3 @@
+// RUN: not clang-tidy -p %S/empty-database %s 2>&1 | FileCheck %s
+
+// CHECK: LLVM ERROR: Cannot chdir into ""!

Added: 
clang-tools-extra/trunk/test/clang-tidy/empty-database/compile_commands.json
URL: 
http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/test/clang-tidy/empty-database/compile_commands.json?rev=363975=auto
==
--- 
clang-tools-extra/trunk/test/clang-tidy/empty-database/compile_commands.json 
(added)
+++ 
clang-tools-extra/trunk/test/clang-tidy/empty-database/compile_commands.json 
Thu Jun 20 13:25:59 2019
@@ -0,0 +1,4 @@
+[{
+"directory":"",
+"file":"/tmp/","arguments":[]
+}]


___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] r363975 - [clang-tidy] Fail gracefully upon empty database fields

2019-06-20 Thread Serge Guelton via cfe-commits 
Author: serge_sans_paille
Date: Thu Jun 20 13:25:59 2019
New Revision: 363975

URL: http://llvm.org/viewvc/llvm-project?rev=363975=rev
Log:
[clang-tidy] Fail gracefully upon empty database fields

Fix bz#42281

Differential Revision: https://reviews.llvm.org/D63613

Added:
clang-tools-extra/trunk/test/clang-tidy/empty-database/
clang-tools-extra/trunk/test/clang-tidy/empty-database.cpp
clang-tools-extra/trunk/test/clang-tidy/empty-database/compile_commands.json

Added: clang-tools-extra/trunk/test/clang-tidy/empty-database.cpp
URL: 
http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/test/clang-tidy/empty-database.cpp?rev=363975=auto
==
--- clang-tools-extra/trunk/test/clang-tidy/empty-database.cpp (added)
+++ clang-tools-extra/trunk/test/clang-tidy/empty-database.cpp Thu Jun 20 
13:25:59 2019
@@ -0,0 +1,3 @@
+// RUN: not clang-tidy -p %S/empty-database %s 2>&1 | FileCheck %s
+
+// CHECK: LLVM ERROR: Cannot chdir into ""!

Added: 
clang-tools-extra/trunk/test/clang-tidy/empty-database/compile_commands.json
URL: 
http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/test/clang-tidy/empty-database/compile_commands.json?rev=363975=auto
==
--- 
clang-tools-extra/trunk/test/clang-tidy/empty-database/compile_commands.json 
(added)
+++ 
clang-tools-extra/trunk/test/clang-tidy/empty-database/compile_commands.json 
Thu Jun 20 13:25:59 2019
@@ -0,0 +1,4 @@
+[{
+"directory":"",
+"file":"/tmp/","arguments":[]
+}]


___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits