[libcxx] r295417 - Work around Clang assertion when testing C++17 deduction guides with '-g'.
Author: ericwf Date: Thu Feb 16 23:04:09 2017 New Revision: 295417 URL: http://llvm.org/viewvc/llvm-project?rev=295417&view=rev Log: Work around Clang assertion when testing C++17 deduction guides with '-g'. Modified: libcxx/trunk/test/std/strings/basic.string/string.cons/implicit_deduction_guides.pass.cpp Modified: libcxx/trunk/test/std/strings/basic.string/string.cons/implicit_deduction_guides.pass.cpp URL: http://llvm.org/viewvc/llvm-project/libcxx/trunk/test/std/strings/basic.string/string.cons/implicit_deduction_guides.pass.cpp?rev=295417&r1=295416&r2=295417&view=diff == --- libcxx/trunk/test/std/strings/basic.string/string.cons/implicit_deduction_guides.pass.cpp (original) +++ libcxx/trunk/test/std/strings/basic.string/string.cons/implicit_deduction_guides.pass.cpp Thu Feb 16 23:04:09 2017 @@ -10,6 +10,10 @@ // UNSUPPORTED: c++98, c++03, c++11, c++14 // UNSUPPORTED: libcpp-no-deduction-guides +// FIXME(EricWF): As of 16/Feb/2017 Clang hits an assertion when compiling this +// test with '-g' (as the sanitizers do). +// XFAIL: ubsan, asan, msan, tsan + // // Test that the constructors offered by std::basic_string are formulated ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Re: [libcxx] r295417 - Work around Clang assertion when testing C++17 deduction guides with '-g'.
Hi Eric Looks like the issue is fixed in r295794? Now green dragon is failing due to XPASS. http://lab.llvm.org:8080/green/job/clang-stage2-cmake-RgSan_check/3018/testReport/ Can we remove that XFAILs in these two files? std/strings/basic_string/string_cons.implicit_deduction_guides.pass.cpp std/strings/string_view/string_view_cons.implicit_deduction_guides.pass.cpp Thanks Steven > On Feb 16, 2017, at 9:04 PM, Eric Fiselier via cfe-commits > wrote: > > Author: ericwf > Date: Thu Feb 16 23:04:09 2017 > New Revision: 295417 > > URL: http://llvm.org/viewvc/llvm-project?rev=295417&view=rev > Log: > Work around Clang assertion when testing C++17 deduction guides with '-g'. > > Modified: > > libcxx/trunk/test/std/strings/basic.string/string.cons/implicit_deduction_guides.pass.cpp > > Modified: > libcxx/trunk/test/std/strings/basic.string/string.cons/implicit_deduction_guides.pass.cpp > URL: > http://llvm.org/viewvc/llvm-project/libcxx/trunk/test/std/strings/basic.string/string.cons/implicit_deduction_guides.pass.cpp?rev=295417&r1=295416&r2=295417&view=diff > == > --- > libcxx/trunk/test/std/strings/basic.string/string.cons/implicit_deduction_guides.pass.cpp > (original) > +++ > libcxx/trunk/test/std/strings/basic.string/string.cons/implicit_deduction_guides.pass.cpp > Thu Feb 16 23:04:09 2017 > @@ -10,6 +10,10 @@ > // UNSUPPORTED: c++98, c++03, c++11, c++14 > // UNSUPPORTED: libcpp-no-deduction-guides > > +// FIXME(EricWF): As of 16/Feb/2017 Clang hits an assertion when compiling > this > +// test with '-g' (as the sanitizers do). > +// XFAIL: ubsan, asan, msan, tsan > + > // > > // Test that the constructors offered by std::basic_string are formulated > > > ___ > cfe-commits mailing list > cfe-commits@lists.llvm.org > http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Re: [libcxx] r295417 - Work around Clang assertion when testing C++17 deduction guides with '-g'.
Hi Eric This has been failing for one week on green dragon. I think all the bots running sanitizer should pick up the clang with the fix already if they are building from trunk. Should I try remove the XFAIL? Steven > On Feb 23, 2017, at 11:48 AM, Steven Wu wrote: > > Hi Eric > > Looks like the issue is fixed in r295794? Now green dragon is failing due to > XPASS. > http://lab.llvm.org:8080/green/job/clang-stage2-cmake-RgSan_check/3018/testReport/ > > Can we remove that XFAILs in these two files? > std/strings/basic_string/string_cons.implicit_deduction_guides.pass.cpp > std/strings/string_view/string_view_cons.implicit_deduction_guides.pass.cpp > > Thanks > > Steven > >> On Feb 16, 2017, at 9:04 PM, Eric Fiselier via cfe-commits >> wrote: >> >> Author: ericwf >> Date: Thu Feb 16 23:04:09 2017 >> New Revision: 295417 >> >> URL: http://llvm.org/viewvc/llvm-project?rev=295417&view=rev >> Log: >> Work around Clang assertion when testing C++17 deduction guides with '-g'. >> >> Modified: >> >> libcxx/trunk/test/std/strings/basic.string/string.cons/implicit_deduction_guides.pass.cpp >> >> Modified: >> libcxx/trunk/test/std/strings/basic.string/string.cons/implicit_deduction_guides.pass.cpp >> URL: >> http://llvm.org/viewvc/llvm-project/libcxx/trunk/test/std/strings/basic.string/string.cons/implicit_deduction_guides.pass.cpp?rev=295417&r1=295416&r2=295417&view=diff >> == >> --- >> libcxx/trunk/test/std/strings/basic.string/string.cons/implicit_deduction_guides.pass.cpp >> (original) >> +++ >> libcxx/trunk/test/std/strings/basic.string/string.cons/implicit_deduction_guides.pass.cpp >> Thu Feb 16 23:04:09 2017 >> @@ -10,6 +10,10 @@ >> // UNSUPPORTED: c++98, c++03, c++11, c++14 >> // UNSUPPORTED: libcpp-no-deduction-guides >> >> +// FIXME(EricWF): As of 16/Feb/2017 Clang hits an assertion when compiling >> this >> +// test with '-g' (as the sanitizers do). >> +// XFAIL: ubsan, asan, msan, tsan >> + >> // >> >> // Test that the constructors offered by std::basic_string are formulated >> >> >> ___ >> cfe-commits mailing list >> cfe-commits@lists.llvm.org >> http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits > ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Re: [libcxx] r295417 - Work around Clang assertion when testing C++17 deduction guides with '-g'.
For those watch the bots, Eric upgrade the bots with the new compiler and I remove the XFAIL in r296385. Thanks Steven > On Feb 23, 2017, at 11:48 AM, Steven Wu via cfe-commits > wrote: > > Hi Eric > > Looks like the issue is fixed in r295794? Now green dragon is failing due to > XPASS. > http://lab.llvm.org:8080/green/job/clang-stage2-cmake-RgSan_check/3018/testReport/ > > Can we remove that XFAILs in these two files? > std/strings/basic_string/string_cons.implicit_deduction_guides.pass.cpp > std/strings/string_view/string_view_cons.implicit_deduction_guides.pass.cpp > > Thanks > > Steven > >> On Feb 16, 2017, at 9:04 PM, Eric Fiselier via cfe-commits >> wrote: >> >> Author: ericwf >> Date: Thu Feb 16 23:04:09 2017 >> New Revision: 295417 >> >> URL: http://llvm.org/viewvc/llvm-project?rev=295417&view=rev >> Log: >> Work around Clang assertion when testing C++17 deduction guides with '-g'. >> >> Modified: >> >> libcxx/trunk/test/std/strings/basic.string/string.cons/implicit_deduction_guides.pass.cpp >> >> Modified: >> libcxx/trunk/test/std/strings/basic.string/string.cons/implicit_deduction_guides.pass.cpp >> URL: >> http://llvm.org/viewvc/llvm-project/libcxx/trunk/test/std/strings/basic.string/string.cons/implicit_deduction_guides.pass.cpp?rev=295417&r1=295416&r2=295417&view=diff >> == >> --- >> libcxx/trunk/test/std/strings/basic.string/string.cons/implicit_deduction_guides.pass.cpp >> (original) >> +++ >> libcxx/trunk/test/std/strings/basic.string/string.cons/implicit_deduction_guides.pass.cpp >> Thu Feb 16 23:04:09 2017 >> @@ -10,6 +10,10 @@ >> // UNSUPPORTED: c++98, c++03, c++11, c++14 >> // UNSUPPORTED: libcpp-no-deduction-guides >> >> +// FIXME(EricWF): As of 16/Feb/2017 Clang hits an assertion when compiling >> this >> +// test with '-g' (as the sanitizers do). >> +// XFAIL: ubsan, asan, msan, tsan >> + >> // >> >> // Test that the constructors offered by std::basic_string are formulated >> >> >> ___ >> cfe-commits mailing list >> cfe-commits@lists.llvm.org >> http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits > > ___ > cfe-commits mailing list > cfe-commits@lists.llvm.org > http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
