Re: [libcxxabi] r308470 - Drop 'svn' suffix from version number.

2017-09-11 Thread Hans Wennborg via cfe-commits 
Sorry, I completely missed that this affected the version string on
released binaries; I was even a reviewer on r312043 :-/ For Windows
release builds, the version info gets set explicitly, but not for
other builds.

We should have merged r312043 to 5.0.0.. perhaps it will go into 5.0.1.

 - Hans

On Sun, Sep 10, 2017 at 11:51 AM, Shoaib Meenai via cfe-commits
 wrote:
> Note that Reid restored the old behavior in r312043.
>
> Configuring with -DLLVM_APPEND_VC_REV=OFF should also restore the old
> behavior, I believe.
>
> On 9/9/17, 1:55 PM, "cfe-commits on behalf of Dimitry Andric via cfe-commits" 
>  
> wrote:
>
> On 19 Jul 2017, at 16:04, Hans Wennborg via cfe-commits 
>  wrote:
> >
> > Author: hans
> > Date: Wed Jul 19 07:04:19 2017
> > New Revision: 308470
> >
> > URL: http://llvm.org/viewvc/llvm-project?rev=308470&view=rev
> > Log:
> > Drop 'svn' suffix from version number.
>
> [Replying to this commit, since I don't have r308469 (which does the same 
> for llvm itself) in my mailboxes.]
>
> Note this approach isn't effective anymore after Rafael's
> https://reviews.llvm.org/rL306858, which turns on the LLVM_APPEND_VC_REV
> option by default.
>
> The handling of that option will overwrite the PACKAGE_VERSION value set
> earlier in CMakeLists.txt, with the value returned from
> add_version_info_from_vcs().  When using Subversion, that will always be
> of the form X.Y.Zsvn-rNN.
>
> I noticed this when preparing the 5.0.0 final import into FreeBSD, where
> for example "opt -version" outputs:
>
> LLVM (http://llvm.org/):
>   LLVM version 5.0.0svn-r312559
>   Optimized build with assertions.
>   Default target: x86_64-unknown-freebsd12.0
>   Host CPU: ivybridge
>
> -Dimitry
>
>
>
> ___
> cfe-commits mailing list
> cfe-commits@lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [libcxxabi] r308470 - Drop 'svn' suffix from version number.

2017-09-10 Thread Shoaib Meenai via cfe-commits 
Note that Reid restored the old behavior in r312043.

Configuring with -DLLVM_APPEND_VC_REV=OFF should also restore the old
behavior, I believe.

On 9/9/17, 1:55 PM, "cfe-commits on behalf of Dimitry Andric via cfe-commits" 
 
wrote:

On 19 Jul 2017, at 16:04, Hans Wennborg via cfe-commits 
 wrote:
> 
> Author: hans
> Date: Wed Jul 19 07:04:19 2017
> New Revision: 308470
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=308470&view=rev
> Log:
> Drop 'svn' suffix from version number.

[Replying to this commit, since I don't have r308469 (which does the same 
for llvm itself) in my mailboxes.]

Note this approach isn't effective anymore after Rafael's
https://reviews.llvm.org/rL306858, which turns on the LLVM_APPEND_VC_REV
option by default.

The handling of that option will overwrite the PACKAGE_VERSION value set
earlier in CMakeLists.txt, with the value returned from
add_version_info_from_vcs().  When using Subversion, that will always be
of the form X.Y.Zsvn-rNN.

I noticed this when preparing the 5.0.0 final import into FreeBSD, where
for example "opt -version" outputs:

LLVM (http://llvm.org/):
  LLVM version 5.0.0svn-r312559
  Optimized build with assertions.
  Default target: x86_64-unknown-freebsd12.0
  Host CPU: ivybridge

-Dimitry



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [libcxxabi] r308470 - Drop 'svn' suffix from version number.

2017-09-09 Thread Dimitry Andric via cfe-commits 
On 19 Jul 2017, at 16:04, Hans Wennborg via cfe-commits 
 wrote:
> 
> Author: hans
> Date: Wed Jul 19 07:04:19 2017
> New Revision: 308470
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=308470&view=rev
> Log:
> Drop 'svn' suffix from version number.

[Replying to this commit, since I don't have r308469 (which does the same for 
llvm itself) in my mailboxes.]

Note this approach isn't effective anymore after Rafael's
https://reviews.llvm.org/rL306858, which turns on the LLVM_APPEND_VC_REV
option by default.

The handling of that option will overwrite the PACKAGE_VERSION value set
earlier in CMakeLists.txt, with the value returned from
add_version_info_from_vcs().  When using Subversion, that will always be
of the form X.Y.Zsvn-rNN.

I noticed this when preparing the 5.0.0 final import into FreeBSD, where
for example "opt -version" outputs:

LLVM (http://llvm.org/):
  LLVM version 5.0.0svn-r312559
  Optimized build with assertions.
  Default target: x86_64-unknown-freebsd12.0
  Host CPU: ivybridge

-Dimitry



signature.asc
Description: Message signed with OpenPGP
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxxabi] r308470 - Drop 'svn' suffix from version number.

2017-07-19 Thread Hans Wennborg via cfe-commits 
Author: hans
Date: Wed Jul 19 07:04:19 2017
New Revision: 308470

URL: http://llvm.org/viewvc/llvm-project?rev=308470&view=rev
Log:
Drop 'svn' suffix from version number.

Modified:
libcxxabi/branches/release_50/CMakeLists.txt

Modified: libcxxabi/branches/release_50/CMakeLists.txt
URL: 
http://llvm.org/viewvc/llvm-project/libcxxabi/branches/release_50/CMakeLists.txt?rev=308470&r1=308469&r2=308470&view=diff
==
--- libcxxabi/branches/release_50/CMakeLists.txt (original)
+++ libcxxabi/branches/release_50/CMakeLists.txt Wed Jul 19 07:04:19 2017
@@ -21,7 +21,7 @@ if (CMAKE_SOURCE_DIR STREQUAL CMAKE_CURR
   project(libcxxabi CXX C)
 
   set(PACKAGE_NAME libcxxabi)
-  set(PACKAGE_VERSION 5.0.0svn)
+  set(PACKAGE_VERSION 5.0.0)
   set(PACKAGE_STRING "${PACKAGE_NAME} ${PACKAGE_VERSION}")
   set(PACKAGE_BUGREPORT "llvm-b...@lists.llvm.org")
 


___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits