[libunwind] [libunwind] Fix an inconsistent indentation (NFC) (PR #72314)
https://github.com/ldionne closed https://github.com/llvm/llvm-project/pull/72314 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[libunwind] [libunwind] Fix an inconsistent indentation (NFC) (PR #72314)
ldionne wrote: LGTM, the AIX failure seems unrelated. https://github.com/llvm/llvm-project/pull/72314 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[libunwind] [libunwind] Fix an inconsistent indentation (NFC) (PR #72314)
https://github.com/arichardson approved this pull request. https://github.com/llvm/llvm-project/pull/72314 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[libunwind] [libunwind] Fix an inconsistent indentation (NFC) (PR #72314)
arichardson wrote: > > Making it consistent is good, but it sounds like we should update the > > .clang-format config file or reformat this whole file to not be indented. > > I'm not sure what the clang-format policy for libunwind is. How about landing > this as is and updating `.clang-format` or excluding this file as a > follow-up, in a way you and other libunwind maintainers think is appropriate? Sorry if that wasn't obvious, I think your change should be merged. I just noticed that the current style does not match the configured one which should eventually be fixed as a follow up change. https://github.com/llvm/llvm-project/pull/72314 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[libunwind] [libunwind] Fix an inconsistent indentation (NFC) (PR #72314)
aheejin wrote: > Making it consistent is good, but it sounds like we should update the > .clang-format config file or reformat this whole file to not be indented. I'm not sure what the clang-format policy for libunwind is. How about landing this as is and updating `.clang-format` or excluding this file as a follow-up, if libunwind maintainers think that's necessary? https://github.com/llvm/llvm-project/pull/72314 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[libunwind] [libunwind] Fix an inconsistent indentation (NFC) (PR #72314)
https://github.com/arichardson commented: Making it consistent is good, but it sounds like we should update the .clang-format config file or reformat this whole file to not be indented. https://github.com/llvm/llvm-project/pull/72314 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[libunwind] [libunwind] Fix an inconsistent indentation (NFC) (PR #72314)
https://github.com/mstorsjo approved this pull request. LGTM, thanks! (I have no idea how I botched that previous fix commit...) https://github.com/llvm/llvm-project/pull/72314 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[libunwind] [libunwind] Fix an inconsistent indentation (NFC) (PR #72314)
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff a40900211a9c187a69b0c3028056275387ce7f1a 6fdc1096db89073020ffb9daa248d0c18c8992ee -- libunwind/include/__libunwind_config.h `` View the diff from clang-format here. ``diff diff --git a/libunwind/include/__libunwind_config.h b/libunwind/include/__libunwind_config.h index 8db336b2d7..c5ee5fee8d 100644 --- a/libunwind/include/__libunwind_config.h +++ b/libunwind/include/__libunwind_config.h @@ -199,7 +199,7 @@ # define _LIBUNWIND_TARGET_RISCV 1 # define _LIBUNWIND_TARGET_VE 1 # define _LIBUNWIND_TARGET_S390X 1 -# define _LIBUNWIND_TARGET_LOONGARCH 1 +#define _LIBUNWIND_TARGET_LOONGARCH 1 # define _LIBUNWIND_CONTEXT_SIZE 167 # define _LIBUNWIND_CURSOR_SIZE 204 # define _LIBUNWIND_HIGHEST_DWARF_REGISTER 287 `` https://github.com/llvm/llvm-project/pull/72314 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[libunwind] [libunwind] Fix an inconsistent indentation (NFC) (PR #72314)
llvmbot wrote: @llvm/pr-subscribers-libunwind Author: Heejin Ahn (aheejin) Changes A fix was tried in https://github.com/llvm/llvm-project/commit/d080b5f1737b4040aa74a5614ae01338f28cd714 but the line is still inconsistent with the surrounding code. --- Full diff: https://github.com/llvm/llvm-project/pull/72314.diff 1 Files Affected: - (modified) libunwind/include/__libunwind_config.h (+1-1) ``diff diff --git a/libunwind/include/__libunwind_config.h b/libunwind/include/__libunwind_config.h index 2444e7286b637f1..8db336b2d727ce7 100644 --- a/libunwind/include/__libunwind_config.h +++ b/libunwind/include/__libunwind_config.h @@ -199,7 +199,7 @@ # define _LIBUNWIND_TARGET_RISCV 1 # define _LIBUNWIND_TARGET_VE 1 # define _LIBUNWIND_TARGET_S390X 1 - #define _LIBUNWIND_TARGET_LOONGARCH 1 +# define _LIBUNWIND_TARGET_LOONGARCH 1 # define _LIBUNWIND_CONTEXT_SIZE 167 # define _LIBUNWIND_CURSOR_SIZE 204 # define _LIBUNWIND_HIGHEST_DWARF_REGISTER 287 `` https://github.com/llvm/llvm-project/pull/72314 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[libunwind] [libunwind] Fix an inconsistent indentation (NFC) (PR #72314)
https://github.com/aheejin created https://github.com/llvm/llvm-project/pull/72314 A fix was tried in https://github.com/llvm/llvm-project/commit/d080b5f1737b4040aa74a5614ae01338f28cd714 but the line is still inconsistent with the surrounding code. >From 6fdc1096db89073020ffb9daa248d0c18c8992ee Mon Sep 17 00:00:00 2001 From: Heejin Ahn Date: Tue, 14 Nov 2023 13:42:00 -0800 Subject: [PATCH] [libunwind] Fix an inconsistent indentation (NFC) A fix was tried in https://github.com/llvm/llvm-project/commit/d080b5f1737b4040aa74a5614ae01338f28cd714 but the line is still inconsistent with the surrounding code. --- libunwind/include/__libunwind_config.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libunwind/include/__libunwind_config.h b/libunwind/include/__libunwind_config.h index 2444e7286b637f1..8db336b2d727ce7 100644 --- a/libunwind/include/__libunwind_config.h +++ b/libunwind/include/__libunwind_config.h @@ -199,7 +199,7 @@ # define _LIBUNWIND_TARGET_RISCV 1 # define _LIBUNWIND_TARGET_VE 1 # define _LIBUNWIND_TARGET_S390X 1 - #define _LIBUNWIND_TARGET_LOONGARCH 1 +# define _LIBUNWIND_TARGET_LOONGARCH 1 # define _LIBUNWIND_CONTEXT_SIZE 167 # define _LIBUNWIND_CURSOR_SIZE 204 # define _LIBUNWIND_HIGHEST_DWARF_REGISTER 287 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
