[libunwind] [libunwind] Move errno.h and signal.h includes under the block where they're needed (PR #78054)
https://github.com/ldionne closed https://github.com/llvm/llvm-project/pull/78054 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[libunwind] [libunwind] Move errno.h and signal.h includes under the block where they're needed (PR #78054)
ajordanr-google wrote: Done! Thanks for the heads up on the email. I'm not too familiar with the GitHub workflow still. Also thanks for this fix PR. https://github.com/llvm/llvm-project/pull/78054 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[libunwind] [libunwind] Move errno.h and signal.h includes under the block where they're needed (PR #78054)
https://github.com/arichardson approved this pull request. https://github.com/llvm/llvm-project/pull/78054 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[libunwind] [libunwind] Move errno.h and signal.h includes under the block where they're needed (PR #78054)
ldionne wrote: CC @ajordanr-google By the way, I noticed that you checked the "hide my email address" Github feature, which leads to your commits being authored as `Jordan R AW <103465530+ajordanr-goo...@users.noreply.github.com>`. Please uncheck that, we strive to make it easy to track who is the author of a commit. https://github.com/llvm/llvm-project/pull/78054 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[libunwind] [libunwind] Move errno.h and signal.h includes under the block where they're needed (PR #78054)
llvmbot wrote: @llvm/pr-subscribers-libunwind Author: Louis Dionne (ldionne) Changes Commit fc1c478709e3 added includes of signal.h and errno.h to UnwindCursor.hpp. The library previously built on platforms where these headers are not provided. These headers should be included only in the case where they are actually needed, i.e. on Linux. --- Full diff: https://github.com/llvm/llvm-project/pull/78054.diff 1 Files Affected: - (modified) libunwind/src/UnwindCursor.hpp (+2-2) ``diff diff --git a/libunwind/src/UnwindCursor.hpp b/libunwind/src/UnwindCursor.hpp index 8517d328bd058b..7753936a5894a3 100644 --- a/libunwind/src/UnwindCursor.hpp +++ b/libunwind/src/UnwindCursor.hpp @@ -12,8 +12,6 @@ #define __UNWINDCURSOR_HPP__ #include "cet_unwind.h" -#include -#include #include #include #include @@ -35,6 +33,8 @@ #if defined(_LIBUNWIND_TARGET_LINUX) && \ (defined(_LIBUNWIND_TARGET_AARCH64) || defined(_LIBUNWIND_TARGET_RISCV) || \ defined(_LIBUNWIND_TARGET_S390X)) +#include +#include #include #include #include `` https://github.com/llvm/llvm-project/pull/78054 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[libunwind] [libunwind] Move errno.h and signal.h includes under the block where they're needed (PR #78054)
https://github.com/ldionne created https://github.com/llvm/llvm-project/pull/78054 Commit fc1c478709e3 added includes of and to UnwindCursor.hpp. The library previously built on platforms where these headers are not provided. These headers should be included only in the case where they are actually needed, i.e. on Linux. >From 985019e12b10539b5b47bdce7b9a77e24f8b5abe Mon Sep 17 00:00:00 2001 From: Louis Dionne Date: Sat, 13 Jan 2024 12:39:44 -0500 Subject: [PATCH] [libunwind] Move errno.h and signal.h includes under the block where they're needed Commit fc1c478709e3 added includes of and to UnwindCursor.hpp. The library previously built on platforms where these headers are not provided. These headers should be included only in the case where they are actually needed, i.e. on Linux. --- libunwind/src/UnwindCursor.hpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libunwind/src/UnwindCursor.hpp b/libunwind/src/UnwindCursor.hpp index 8517d328bd058b..7753936a5894a3 100644 --- a/libunwind/src/UnwindCursor.hpp +++ b/libunwind/src/UnwindCursor.hpp @@ -12,8 +12,6 @@ #define __UNWINDCURSOR_HPP__ #include "cet_unwind.h" -#include -#include #include #include #include @@ -35,6 +33,8 @@ #if defined(_LIBUNWIND_TARGET_LINUX) && \ (defined(_LIBUNWIND_TARGET_AARCH64) || defined(_LIBUNWIND_TARGET_RISCV) || \ defined(_LIBUNWIND_TARGET_S390X)) +#include +#include #include #include #include ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
