[openmp] [clang] [llvm] [OpenMP] Remove `register_requires` global constructor (PR #80460)

[Gheorghe-Teodor Bercea via cfe-commits]

@@ -199,7 +199,7 @@ static int initLibrary(DeviceTy &Device) {
 Entry.size) != OFFLOAD_SUCCESS)
   REPORT("Failed to write symbol for USM %s\n", Entry.name);
   }
-} else {
+} else if (Entry.addr) {

doru1004 wrote:

Should we check for size > 0 too? 

https://github.com/llvm/llvm-project/pull/80460
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[openmp] [clang] [llvm] [OpenMP] Remove `register_requires` global constructor (PR #80460)

[Gheorghe-Teodor Bercea via cfe-commits]

@@ -199,7 +199,7 @@ static int initLibrary(DeviceTy &Device) {
 Entry.size) != OFFLOAD_SUCCESS)
   REPORT("Failed to write symbol for USM %s\n", Entry.name);
   }
-} else {
+} else if (Entry.addr) {

doru1004 wrote:

Or is that too restrictive

https://github.com/llvm/llvm-project/pull/80460
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[openmp] [clang] [llvm] [OpenMP] Remove `register_requires` global constructor (PR #80460)

[Joseph Huber via cfe-commits]

@@ -199,7 +199,7 @@ static int initLibrary(DeviceTy &Device) {
 Entry.size) != OFFLOAD_SUCCESS)
   REPORT("Failed to write symbol for USM %s\n", Entry.name);
   }
-} else {
+} else if (Entry.addr) {

jhuber6 wrote:

Isn't that already done in the `if` above?

https://github.com/llvm/llvm-project/pull/80460
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[openmp] [clang] [llvm] [OpenMP] Remove `register_requires` global constructor (PR #80460)

[Gheorghe-Teodor Bercea via cfe-commits]

@@ -199,7 +199,7 @@ static int initLibrary(DeviceTy &Device) {
 Entry.size) != OFFLOAD_SUCCESS)
   REPORT("Failed to write symbol for USM %s\n", Entry.name);
   }
-} else {
+} else if (Entry.addr) {

doru1004 wrote:

So it will only enter this branch if size is 0 and then if the address is not 
nullptr.

https://github.com/llvm/llvm-project/pull/80460
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[openmp] [clang] [llvm] [OpenMP] Remove `register_requires` global constructor (PR #80460)

[Joseph Huber via cfe-commits]

@@ -199,7 +199,7 @@ static int initLibrary(DeviceTy &Device) {
 Entry.size) != OFFLOAD_SUCCESS)
   REPORT("Failed to write symbol for USM %s\n", Entry.name);
   }
-} else {
+} else if (Entry.addr) {

jhuber6 wrote:

Yes, I'll make the offloading entries less dumb in the future. I don't like how 
for working w/ CUDA and stuff we need `cuda_offloading_entries` and  whatnot as 
well. I've been planning on merging them and simply having a field for the 
language kind and stuff. Been planning on doing that for awhile.

https://github.com/llvm/llvm-project/pull/80460
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[openmp] [clang] [llvm] [OpenMP] Remove `register_requires` global constructor (PR #80460)

[Sergio Afonso via cfe-commits]

https://github.com/skatrak edited 
https://github.com/llvm/llvm-project/pull/80460
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[openmp] [clang] [llvm] [OpenMP] Remove `register_requires` global constructor (PR #80460)

[Joseph Huber via cfe-commits]

@@ -6872,35 +6883,6 @@ void OpenMPIRBuilder::loadOffloadInfoMetadata(StringRef 
HostFilePath) {
   loadOffloadInfoMetadata(*M.get());
 }
 
-Function *OpenMPIRBuilder::createRegisterRequires(StringRef Name) {

jhuber6 wrote:

Thanks for the heads up. Do you know if there will be any other changes 
required to make the requires information use the "new" format?

https://github.com/llvm/llvm-project/pull/80460
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits