Re: Diagnostics improvements for 3.9
I've merged the lot in r278020. Thanks, Hans On Fri, Aug 5, 2016 at 7:43 PM, Hans Wennborg wrote: > These all sgtm for 3.9. Go ahead and merge with > utils/release/merge.sh, or I'll do it when I get in on Monday. > > Cheers, > Hans > > On Fri, Aug 5, 2016 at 6:52 PM, Richard Trieu wrote: >> Typos and unused test variables fixed in r277900 >> >> On Fri, Aug 5, 2016 at 6:46 PM, Richard Smith wrote: >>> >>> On Fri, Aug 5, 2016 at 6:33 PM, Richard Smith >>> wrote: These all look OK for the branch. Hans, the second one fixes a crasher, so I'd like to take at least that one. The others fix warning false positives (which are not regressions) and look fairly safe. >>> >>> >>> Correction: looks like the final one is in fact a fix for a diagnostic >>> regression. >>> On Fri, Aug 5, 2016 at 4:39 PM, Richard Trieu wrote: > > Hans, Richard, > > These are some last minute diagnostic improvements for 3.9. > > http://llvm.org/viewvc/llvm-project?rev=277796&view=rev > r277796 > Don't warn when negative values, like -1, are used to initialize > unsigned bit fields. > > http://llvm.org/viewvc/llvm-project?rev=277797&view=rev > r277797 > Fix crash with type alias in Template Type Diffing (You have a typo Internalal in this.) > > http://llvm.org/viewvc/llvm-project?rev=277866&view=rev > r277866 > Fix false positive in -Wunsequenced and templates > > http://llvm.org/viewvc/llvm-project?rev=277889&view=rev > r277889 > Fixes for two false positives in -Wreturn-stack-address dealing with > parameter variables and reference to pointer types. (Test has some x3 variables that are unused.) >>> >>> >> ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Re: Diagnostics improvements for 3.9
These all sgtm for 3.9. Go ahead and merge with utils/release/merge.sh, or I'll do it when I get in on Monday. Cheers, Hans On Fri, Aug 5, 2016 at 6:52 PM, Richard Trieu wrote: > Typos and unused test variables fixed in r277900 > > On Fri, Aug 5, 2016 at 6:46 PM, Richard Smith wrote: >> >> On Fri, Aug 5, 2016 at 6:33 PM, Richard Smith >> wrote: >>> >>> These all look OK for the branch. Hans, the second one fixes a crasher, >>> so I'd like to take at least that one. The others fix warning false >>> positives (which are not regressions) and look fairly safe. >> >> >> Correction: looks like the final one is in fact a fix for a diagnostic >> regression. >> >>> >>> On Fri, Aug 5, 2016 at 4:39 PM, Richard Trieu wrote: Hans, Richard, These are some last minute diagnostic improvements for 3.9. http://llvm.org/viewvc/llvm-project?rev=277796&view=rev r277796 Don't warn when negative values, like -1, are used to initialize unsigned bit fields. http://llvm.org/viewvc/llvm-project?rev=277797&view=rev r277797 Fix crash with type alias in Template Type Diffing >>> >>> >>> (You have a typo Internalal in this.) >>> http://llvm.org/viewvc/llvm-project?rev=277866&view=rev r277866 Fix false positive in -Wunsequenced and templates http://llvm.org/viewvc/llvm-project?rev=277889&view=rev r277889 Fixes for two false positives in -Wreturn-stack-address dealing with parameter variables and reference to pointer types. >>> >>> >>> (Test has some x3 variables that are unused.) >> >> > ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Re: Diagnostics improvements for 3.9
Typos and unused test variables fixed in r277900 On Fri, Aug 5, 2016 at 6:46 PM, Richard Smith wrote: > On Fri, Aug 5, 2016 at 6:33 PM, Richard Smith > wrote: > >> These all look OK for the branch. Hans, the second one fixes a crasher, >> so I'd like to take at least that one. The others fix warning false >> positives (which are not regressions) and look fairly safe. >> > > Correction: looks like the final one is in fact a fix for a diagnostic > regression. > > >> On Fri, Aug 5, 2016 at 4:39 PM, Richard Trieu wrote: >> >>> Hans, Richard, >>> >>> These are some last minute diagnostic improvements for 3.9. >>> >>> http://llvm.org/viewvc/llvm-project?rev=277796&view=rev >>> r277796 >>> Don't warn when negative values, like -1, are used to initialize >>> unsigned bit fields. >>> >>> http://llvm.org/viewvc/llvm-project?rev=277797&view=rev >>> r277797 >>> Fix crash with type alias in Template Type Diffing >>> >> >> (You have a typo Internalal in this.) >> >> >>> http://llvm.org/viewvc/llvm-project?rev=277866&view=rev >>> r277866 >>> Fix false positive in -Wunsequenced and templates >>> >>> http://llvm.org/viewvc/llvm-project?rev=277889&view=rev >>> r277889 >>> Fixes for two false positives in -Wreturn-stack-address dealing with >>> parameter variables and reference to pointer types. >>> >> >> (Test has some x3 variables that are unused.) >> > > ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Re: Diagnostics improvements for 3.9
On Fri, Aug 5, 2016 at 6:33 PM, Richard Smith wrote: > These all look OK for the branch. Hans, the second one fixes a crasher, so > I'd like to take at least that one. The others fix warning false positives > (which are not regressions) and look fairly safe. > Correction: looks like the final one is in fact a fix for a diagnostic regression. > On Fri, Aug 5, 2016 at 4:39 PM, Richard Trieu wrote: > >> Hans, Richard, >> >> These are some last minute diagnostic improvements for 3.9. >> >> http://llvm.org/viewvc/llvm-project?rev=277796&view=rev >> r277796 >> Don't warn when negative values, like -1, are used to initialize unsigned >> bit fields. >> >> http://llvm.org/viewvc/llvm-project?rev=277797&view=rev >> r277797 >> Fix crash with type alias in Template Type Diffing >> > > (You have a typo Internalal in this.) > > >> http://llvm.org/viewvc/llvm-project?rev=277866&view=rev >> r277866 >> Fix false positive in -Wunsequenced and templates >> >> http://llvm.org/viewvc/llvm-project?rev=277889&view=rev >> r277889 >> Fixes for two false positives in -Wreturn-stack-address dealing with >> parameter variables and reference to pointer types. >> > > (Test has some x3 variables that are unused.) > ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Re: Diagnostics improvements for 3.9
These all look OK for the branch. Hans, the second one fixes a crasher, so I'd like to take at least that one. The others fix warning false positives (which are not regressions) and look fairly safe. On Fri, Aug 5, 2016 at 4:39 PM, Richard Trieu wrote: > Hans, Richard, > > These are some last minute diagnostic improvements for 3.9. > > http://llvm.org/viewvc/llvm-project?rev=277796&view=rev > r277796 > Don't warn when negative values, like -1, are used to initialize unsigned > bit fields. > > http://llvm.org/viewvc/llvm-project?rev=277797&view=rev > r277797 > Fix crash with type alias in Template Type Diffing > (You have a typo Internalal in this.) > http://llvm.org/viewvc/llvm-project?rev=277866&view=rev > r277866 > Fix false positive in -Wunsequenced and templates > > http://llvm.org/viewvc/llvm-project?rev=277889&view=rev > r277889 > Fixes for two false positives in -Wreturn-stack-address dealing with > parameter variables and reference to pointer types. > (Test has some x3 variables that are unused.) ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Diagnostics improvements for 3.9
Hans, Richard, These are some last minute diagnostic improvements for 3.9. http://llvm.org/viewvc/llvm-project?rev=277796&view=rev r277796 Don't warn when negative values, like -1, are used to initialize unsigned bit fields. http://llvm.org/viewvc/llvm-project?rev=277797&view=rev r277797 Fix crash with type alias in Template Type Diffing http://llvm.org/viewvc/llvm-project?rev=277866&view=rev r277866 Fix false positive in -Wunsequenced and templates http://llvm.org/viewvc/llvm-project?rev=277889&view=rev r277889 Fixes for two false positives in -Wreturn-stack-address dealing with parameter variables and reference to pointer types. Richard ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
