Re: Fwd: patch file for bug 38557

[Owen Pan via cfe-commits]

Hi Jonas,

Thank you very much! I just created a phabricator account and created a
revision for another bug (https://reviews.llvm.org/D50699). I don't know
exactly how to add my test case like you did for me, so I just uploaded it.
I also added the reviewers listed by bugs.llvm.org.

How do I "take over" the revision you created for me?

Thanks,
Owen

On Tue, Aug 14, 2018 at 4:16 AM Jonas Toth 
wrote:

> Hi Owen,
>
> thank you for your patch. I created a revision for it to pass review:
> https://reviews.llvm.org/D50697
>
> If you do have an phabricator account you can take over, otherwise we can
> get it into trunk for you :)
>
> All the best, Jonas
>
> Am 14.08.2018 um 12:30 schrieb Owen Pan via cfe-commits:
>
> Hi,
>
> Attached is the patch file for Bug 38557 (
> https://bugs.llvm.org/show_bug.cgi?id=38557).
>
> Thanks,
> Owen
>
>
> ___
> cfe-commits mailing 
> listcfe-comm...@lists.llvm.orghttp://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
>
>
>
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: Fwd: patch file for bug 38557

[Jonas Toth via cfe-commits]

Hi Owen,

thank you for your patch. I created a revision for it to pass review:
https://reviews.llvm.org/D50697

If you do have an phabricator account you can take over, otherwise we
can get it into trunk for you :)

All the best, Jonas


Am 14.08.2018 um 12:30 schrieb Owen Pan via cfe-commits:
> Hi,
>
> Attached is the patch file for Bug 38557
> (https://bugs.llvm.org/show_bug.cgi?id=38557).
>
> Thanks,
> Owen
>
>
> ___
> cfe-commits mailing list
> cfe-commits@lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: Fwd: patch file for bug 38557

[Jonas Toth via cfe-commits]

Do you have a phabricator account? Otherwise I will create a revision
for you (ofc mentioning your name in the commit message) for review.


Am 14.08.2018 um 12:30 schrieb Owen Pan via cfe-commits:
> Hi,
>
> Attached is the patch file for Bug 38557
> (https://bugs.llvm.org/show_bug.cgi?id=38557).
>
> Thanks,
> Owen
>
>
> ___
> cfe-commits mailing list
> cfe-commits@lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Fwd: patch file for bug 38557

[Owen Pan via cfe-commits]

Hi,

Attached is the patch file for Bug 38557 (
https://bugs.llvm.org/show_bug.cgi?id=38557).

Thanks,
Owen
Index: UnwrappedLineParser.cpp
===
--- UnwrappedLineParser.cpp	(revision 339102)
+++ UnwrappedLineParser.cpp	(working copy)
@@ -350,7 +350,10 @@
   break;
 case tok::kw_default: {
   unsigned StoredPosition = Tokens->getPosition();
-  FormatToken *Next = Tokens->getNextToken();
+  FormatToken *Next;
+  do {
+Next = Tokens->getNextToken();
+  } while (Next && Next->is(tok::comment));
   FormatTok = Tokens->setPosition(StoredPosition);
   if (Next && Next->isNot(tok::colon)) {
 // default not followed by ':' is not a case label; treat it like
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits