Re: [PATCH] D128059: [Clang] Add a warning on invalid UTF-8 in comments.

[Corentin via cfe-commits]

I'll be unavailable the next 2 weeks, feel free to do it if you want!

On Fri, Jun 9, 2023, 21:10 Tom Honermann via Phabricator <
revi...@reviews.llvm.org> wrote:

> tahonermann added a comment.
>
> @cor3ntin, sorry for failing to keep up with reviews; I know this has
> already been committed. I did spot a couple of typos should you feel
> inclined to address them.
>
>
>
> 
> Comment at: clang/lib/Lex/Lexer.cpp:2695
> +  // diagnostic only once per entire ill-formed subsequence to avoid
> +  // emiting to many diagnostics (see
> http://unicode.org/review/pr-121.html).
> +  bool UnicodeDecodingAlreadyDiagnosed = false;
> 
>
>
>
> 
> Comment at: clang/lib/Lex/Lexer.cpp:2398
> +  // diagnostic only once per entire ill-formed subsequence to avoid
> +  // emiting to many diagnostics (see
> http://unicode.org/review/pr-121.html).
> +  bool UnicodeDecodingAlreadyDiagnosed = false;
> 
>
>
>
> Repository:
>   rG LLVM Github Monorepo
>
> CHANGES SINCE LAST ACTION
>   https://reviews.llvm.org/D128059/new/
>
> https://reviews.llvm.org/D128059
>
>
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D128059: [Clang] Add a warning on invalid UTF-8 in comments.

[Corentin via cfe-commits]

My plan is to do that for all papers once past plenary to
keep consistency with cxx_status.

On Tue, Jul 5, 2022 at 6:13 PM Aaron Ballman via Phabricator <
revi...@reviews.llvm.org> wrote:

> aaron.ballman added reviewers: tahonermann, clang-language-wg.
> aaron.ballman added inline comments.
>
>
> 
> Comment at: clang/docs/ReleaseNotes.rst:271
> +- Added ``-Winvalid-utf8`` which diagnoses invalid UTF-8 code unit
> sequences in
> +  comments.
>
> 
> Should we mention `P2295R5` now that it's at least core approved?
> Something like:
> %%%
> ...unit sequences in comments; in support of `P2295R5 <
> http://wg21.link/P2295R5>`_.
> %%%
>
>
> Repository:
>   rG LLVM Github Monorepo
>
> CHANGES SINCE LAST ACTION
>   https://reviews.llvm.org/D128059/new/
>
> https://reviews.llvm.org/D128059
>
>
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits