Re: [PATCH] D13802: [OPENMP] Make -fopenmp to turn on OpenMP support by default.

[Alexey Bataev via cfe-commits]

Hi Hans,
I asked Chandler to look at this once again but seems to me he is very 
busy. Maybe you could ping him also?

Best regards,
Alexey Bataev
=
Software Engineer
Intel Compiler Team

09.12.2015 0:35, Hans Wennborg пишет:
> hans added a comment.
>
> Alexey & Chandler: Is there any ongoing communication here?
>
> It would be great if we could resolve this, or at least figure out what the 
> status is, before we branch for 3.8 in a month or so.
>
>
> http://reviews.llvm.org/D13802
>
>
>

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D13802: [OPENMP] Make -fopenmp to turn on OpenMP support by default.

[Chandler Carruth via cfe-commits]

chandlerc accepted this revision.
chandlerc added a comment.
This revision is now accepted and ready to land.

Sorry I was a bit slow -- was out when commented in Nov, and was slow catching 
back up the past two weeks.

I've done some more testing, and the check-libomp is passing very nicely now! 
=D Ship it! Also make sure you follow up with the broader set of build bots to 
have them include this repository in the checkout.

Minor documentation tweak below, but feel free to land everything. =D I'm 
excited, it'll be interesting to see if anything else breaks, but so far it 
seems to be working well for me.



Comment at: docs/GettingStarted.rst:58-62
@@ -57,1 +57,7 @@
 
+#. Checkout Libomp (required for OpenMP support) **[Optional]**:
+
+   * ``cd where-you-want-llvm-to-live``
+   * ``cd llvm/projects``
+   * ``svn co http://llvm.org/svn/llvm-project/openmp/trunk openmp``
+

I'd skip the optional tag -- as you've nicely documented, its required for 
OpenMP support.


http://reviews.llvm.org/D13802



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D13802: [OPENMP] Make -fopenmp to turn on OpenMP support by default.

[Alexey Bataev via cfe-commits]

This revision was automatically updated to reflect the committed changes.
ABataev marked an inline comment as done.
Closed by commit rL255222: [OPENMP] Make -fopenmp to turn on OpenMP support by 
default. (authored by ABataev).

Changed prior to commit:
  http://reviews.llvm.org/D13802?vs=38374=42382#toc

Repository:
  rL LLVM

http://reviews.llvm.org/D13802

Files:
  llvm/trunk/autoconf/configure.ac
  llvm/trunk/configure
  llvm/trunk/docs/GettingStarted.rst
  llvm/trunk/docs/ReleaseProcess.rst
  llvm/trunk/utils/release/test-release.sh

Index: llvm/trunk/utils/release/test-release.sh
===
--- llvm/trunk/utils/release/test-release.sh
+++ llvm/trunk/utils/release/test-release.sh
@@ -34,7 +34,7 @@
 do_libs="yes"
 do_libunwind="yes"
 do_test_suite="yes"
-do_openmp="no"
+do_openmp="yes"
 BuildDir="`pwd`"
 use_autoconf="no"
 ExtraConfigureFlags=""
@@ -62,7 +62,7 @@
 echo " -no-libs Disable check-out & build libcxx/libcxxabi/libunwind"
 echo " -no-libunwindDisable check-out & build libunwind"
 echo " -no-test-suite   Disable check-out & build test-suite"
-echo " -openmp  Check out and build the OpenMP run-time (experimental)"
+echo " -no-openmp   Disable check-out & build libomp"
 }
 
 if [ `uname -s` = "Darwin" ]; then
@@ -143,8 +143,8 @@
 -no-test-suite )
 do_test_suite="no"
 ;;
--openmp )
-do_openmp="yes"
+-no-openmp )
+do_openmp="no"
 ;;
 -help | --help | -h | --h | -\? )
 usage
@@ -293,6 +293,9 @@
 if [ -d $BuildDir/compiler-rt.src ] && [ ! -h compiler-rt ]; then
 ln -s ../../compiler-rt.src compiler-rt
 fi
+if [ -d $BuildDir/openmp.src ] && [ ! -h openmp ]; then
+ln -s ../../openmp.src openmp
+fi
 if [ -d $BuildDir/libcxx.src ] && [ ! -h libcxx ]; then
 ln -s ../../libcxx.src libcxx
 fi
@@ -443,46 +446,6 @@
 cd $cwd
 }
 
-# Build and package the OpenMP run-time. This is still experimental and not
-# meant for official testing in the release, but as a way for providing
-# binaries as a convenience to those who want to try it out.
-function build_OpenMP() {
-cwd=`pwd`
-
-rm -rf $BuildDir/Phase3/openmp
-rm -rf $BuildDir/Phase3/openmp.install
-mkdir -p $BuildDir/Phase3/openmp
-cd $BuildDir/Phase3/openmp
-clang=$BuildDir/Phase3/Release/llvmCore-$Release-$RC.install/usr/local/bin/clang
-
-echo "#" cmake -DCMAKE_C_COMPILER=${clang} -DCMAKE_CXX_COMPILER=${clang}++ \
--DCMAKE_BUILD_TYPE=Release -DLIBOMP_MICRO_TESTS=on \
-$BuildDir/openmp.src/runtime
-cmake -DCMAKE_C_COMPILER=${clang} -DCMAKE_CXX_COMPILER=${clang}++ \
--DCMAKE_BUILD_TYPE=Release -DLIBOMP_MICRO_TESTS=on \
-$BuildDir/openmp.src/runtime
-
-echo "# Building OpenMP run-time"
-echo "# ${MAKE} -j $NumJobs VERBOSE=1"
-${MAKE} -j $NumJobs VERBOSE=1
-echo "# ${MAKE} libomp-micro-tests VERBOSE=1"
-${MAKE} libomp-micro-tests VERBOSE=1
-echo "# ${MAKE} install DESTDIR=$BuildDir/Phase3/openmp.install"
-${MAKE} install DESTDIR=$BuildDir/Phase3/openmp.install
-
-OpenMPPackage=OpenMP-$Release
-if [ $RC != "final" ]; then
-OpenMPPackage=$OpenMPPackage-$RC
-fi
-OpenMPPackage=$OpenMPPackage-$Triple
-
-mv $BuildDir/Phase3/openmp.install/usr/local $BuildDir/$OpenMPPackage
-cd $BuildDir
-tar cvfJ $BuildDir/$OpenMPPackage.tar.xz $OpenMPPackage
-mv $OpenMPPackage $BuildDir/Phase3/openmp.install/usr/local
-cd $cwd
-}
-
 # Exit if any command fails
 # Note: pipefail is necessary for running build commands through
 # a pipe (i.e. it changes the output of ``false | tee /dev/null ; echo $?``)
@@ -594,10 +557,6 @@
 fi
 done
 
-if [ $do_openmp = "yes" ]; then
-  build_OpenMP
-fi
-
 ) 2>&1 | tee $LogDir/testing.$Release-$RC.log
 
 package_release
Index: llvm/trunk/docs/ReleaseProcess.rst
===
--- llvm/trunk/docs/ReleaseProcess.rst
+++ llvm/trunk/docs/ReleaseProcess.rst
@@ -53,7 +53,7 @@
 ---
 
 This script will check-out, configure and compile LLVM+Clang (+ most add-ons, like ``compiler-rt``,
-``libcxx`` and ``clang-extra-tools``) in three stages, and will test the final stage.
+``libcxx``, ``libomp`` and ``clang-extra-tools``) in three stages, and will test the final stage.
 It'll have installed the final binaries on the Phase3/Releasei(+Asserts) directory, and
 that's the one you should use for the test-suite and other external tests.
 
Index: llvm/trunk/docs/GettingStarted.rst
===
--- llvm/trunk/docs/GettingStarted.rst
+++ llvm/trunk/docs/GettingStarted.rst
@@ -55,6 +55,12 @@
* ``cd llvm/projects``
* ``svn co http://llvm.org/svn/llvm-project/compiler-rt/trunk compiler-rt``
 
+#. Checkout Libomp 

Re: [PATCH] D13802: [OPENMP] Make -fopenmp to turn on OpenMP support by default.

[Alexey Bataev via cfe-commits]

ABataev marked an inline comment as done.
ABataev added a comment.

Chandler, thank you very much for review!



Comment at: docs/GettingStarted.rst:58-62
@@ -57,1 +57,7 @@
 
+#. Checkout Libomp (required for OpenMP support) **[Optional]**:
+
+   * ``cd where-you-want-llvm-to-live``
+   * ``cd llvm/projects``
+   * ``svn co http://llvm.org/svn/llvm-project/openmp/trunk openmp``
+

chandlerc wrote:
> I'd skip the optional tag -- as you've nicely documented, its required for 
> OpenMP support.
Ok, removed


http://reviews.llvm.org/D13802



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D13802: [OPENMP] Make -fopenmp to turn on OpenMP support by default.

[Hans Wennborg via cfe-commits]

hans added a comment.

Alexey & Chandler: Is there any ongoing communication here?

It would be great if we could resolve this, or at least figure out what the 
status is, before we branch for 3.8 in a month or so.


http://reviews.llvm.org/D13802



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D13802: [OPENMP] Make -fopenmp to turn on OpenMP support by default.

[Tom Stellard via cfe-commits]

tstellarAMD resigned from this revision.
tstellarAMD removed a reviewer: tstellarAMD.
tstellarAMD added a comment.

Hans already commented on the release script changes, and I agrre they look 
good.


http://reviews.llvm.org/D13802



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D13802: [OPENMP] Make -fopenmp to turn on OpenMP support by default.

[Alexey Bataev via cfe-commits]

ABataev added a comment.

Chandler, gcc buildbot greenified, tests for clang are fixed. Hans Wennborg 
accepted this patch. Could accept this patch?


http://reviews.llvm.org/D13802



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D13802: [OPENMP] Make -fopenmp to turn on OpenMP support by default.

[Jack Howarth via cfe-commits]

jhowarth added a comment.

The CMakeLists.txt change cited is in top-level of the clang sources and not in 
the llvm top-level.


http://reviews.llvm.org/D13802



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D13802: [OPENMP] Make -fopenmp to turn on OpenMP support by default.

[Alexey Bataev via cfe-commits]

ABataev added a comment.

In http://reviews.llvm.org/D13802#276755, @hfinkel wrote:

> In http://reviews.llvm.org/D13802#275471, @chandlerc wrote:
>
> > In http://reviews.llvm.org/D13802#274847, @ABataev wrote:
> >
> > > Hi Chandler, thanks for the review.
> > >
> > > In http://reviews.llvm.org/D13802#272053, @chandlerc wrote:
> > >
> > > > I've also had one test fail, and then start passing for me on Linux 
> > > > (after fixing the above). I haven't had it fail again, but I don't have 
> > > > a good way of running tests repeatedly (see below, llvm-lit doesn't yet 
> > > > work). It might be good to give the test suite a good 10 or 50 runs and 
> > > > see if anything starts failing. I'll do that overnight and report back 
> > > > if so.
> > >
> > >
> > > Actually, these tests are written so, that they repeats about 1000 times 
> > > to be sure that they are correct. But some of them might be sensible to 
> > > system load.
> >
> >
> > Hmm, so I think we need to find some way to make some of these tests more 
> > reliable.
> >
> > With the fix from http://reviews.llvm.org/D14055 patched in (minus the flag 
> > change in it) I am seeing tests fail pretty regularly:
> >
> >   libomp :: worksharing/for/omp_for_schedule_auto.c
>
>
> Credit goes to a colleague of mine, Ray Loy, for spotting this. This test has 
> a race condition. The updates to the global sum1 are not protected by any 
> kind of synchronization.
>
>   sum1 = sum0;
>   
>
> the for pragma is missing a private(sum1) clause?
>
> > This test seems to fail pretty frequently for me. Maybe as much as half the 
> > time.
>
> > 
>
> >   libomp :: worksharing/sections/omp_sections_nowait.c
>
>
> In omp_testsuite.h, we have this:
>
>   /* following times are in seconds */
>   #define SLEEPTIME 0.1
>   
>
> and this test, and also omp_flush.c, are sensitive to this. If the machine is 
> heavily loaded, or otherwise configured, so the threads involved don't all 
> get scheduled within 0.1 seconds, this will certainly fail.
>
> Also, does this test have a race condition? Specifically, should there be a
>
>   #pragma omp flush(count)
>   
>
> before
>
>   if (count == 0)
>   
>
> I think there should be.
>
> > This test fails less frequently, but still have seen it a few times.
>
> > 
>
> >   libomp :: flush/omp_flush.c
>
> >
>
> > 
>
> > I've seen this test fail just once...
>
>
> This is trying to test the memory flush pragma by having one thread write and 
> flush, and a second thread wait for a fixed time, flush and read. As 
> mentioned above, this is sensitive to SLEEPTIME.


Hal, thanks for pointing this. I'll take a look and try to fix these tests.


http://reviews.llvm.org/D13802



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D13802: [OPENMP] Make -fopenmp to turn on OpenMP support by default.

[Alexey Bataev via cfe-commits]

ABataev added a comment.

In http://reviews.llvm.org/D13802#277270, @jhowarth wrote:

> The proposed patches here to change the default behavior of -fopenmp from 
> -fopenmp=libgomp to -fopenmp=libomp seem to only handle the configure-based 
> build. The following change required to switch over the crake-based build to 
> default -fopenmp to libomp  is missing.
>
>   Index: CMakeLists.txt
>   ===
>   --- CMakeLists.txt  (revision 251539)
>   +++ CMakeLists.txt  (working copy)
>   @@ -196,7 +196,7 @@ set(GCC_INSTALL_PREFIX "" CACHE PATH "Di
>set(DEFAULT_SYSROOT "" CACHE PATH
>  "Default  to all compiler invocations for --sysroot=." )
>   
>   -set(CLANG_DEFAULT_OPENMP_RUNTIME "libgomp" CACHE STRING
>   +set(CLANG_DEFAULT_OPENMP_RUNTIME "libomp" CACHE STRING
>  "Default OpenMP runtime used by -fopenmp.")
>   
>set(CLANG_VENDOR "" CACHE STRING
>


This patch is for clang and it is accepted already. But I'm going to land all 
patches for -fopenmp only when llvm and libomp changes are accepted.


http://reviews.llvm.org/D13802



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D13802: [OPENMP] Make -fopenmp to turn on OpenMP support by default.

[Jack Howarth via cfe-commits]

jhowarth added a subscriber: jhowarth.
jhowarth added a comment.

The proposed patches here to change the default behavior of -fopenmp from 
-fopenmp=libgomp to -fopenmp=libomp seem to only handle the configure-based 
build. The following change required to switch over the crake-based build to 
default -fopenmp to libomp  is missing.

  Index: CMakeLists.txt
  ===
  --- CMakeLists.txt(revision 251539)
  +++ CMakeLists.txt(working copy)
  @@ -196,7 +196,7 @@ set(GCC_INSTALL_PREFIX "" CACHE PATH "Di
   set(DEFAULT_SYSROOT "" CACHE PATH
 "Default  to all compiler invocations for --sysroot=." )
   
  -set(CLANG_DEFAULT_OPENMP_RUNTIME "libgomp" CACHE STRING
  +set(CLANG_DEFAULT_OPENMP_RUNTIME "libomp" CACHE STRING
 "Default OpenMP runtime used by -fopenmp.")
   
   set(CLANG_VENDOR "" CACHE STRING


http://reviews.llvm.org/D13802



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D13802: [OPENMP] Make -fopenmp to turn on OpenMP support by default.

[Alexey Bataev via cfe-commits]

ABataev added reviewers: hans, tstellarAMD.
ABataev updated this revision to Diff 38374.
ABataev marked an inline comment as done.

http://reviews.llvm.org/D13802

Files:
  autoconf/configure.ac
  configure
  docs/GettingStarted.rst
  docs/ReleaseProcess.rst
  utils/release/test-release.sh

Index: autoconf/configure.ac
===
--- autoconf/configure.ac
+++ autoconf/configure.ac
@@ -1340,7 +1340,7 @@
 AC_ARG_WITH(clang-default-openmp-runtime,
   AS_HELP_STRING([--with-clang-default-openmp-runtime],
 [The default OpenMP runtime for Clang.]),,
-withval="libgomp")
+withval="libomp")
 AC_DEFINE_UNQUOTED(CLANG_DEFAULT_OPENMP_RUNTIME,"$withval",
[Default OpenMP runtime used by -fopenmp.])
 
Index: utils/release/test-release.sh
===
--- utils/release/test-release.sh
+++ utils/release/test-release.sh
@@ -34,7 +34,7 @@
 do_libs="yes"
 do_libunwind="yes"
 do_test_suite="yes"
-do_openmp="no"
+do_openmp="yes"
 BuildDir="`pwd`"
 use_autoconf="no"
 ExtraConfigureFlags=""
@@ -62,7 +62,7 @@
 echo " -no-libs Disable check-out & build libcxx/libcxxabi/libunwind"
 echo " -no-libunwindDisable check-out & build libunwind"
 echo " -no-test-suite   Disable check-out & build test-suite"
-echo " -openmp  Check out and build the OpenMP run-time (experimental)"
+echo " -no-openmp   Disable check-out & build libomp"
 }
 
 if [ `uname -s` = "Darwin" ]; then
@@ -143,8 +143,8 @@
 -no-test-suite )
 do_test_suite="no"
 ;;
--openmp )
-do_openmp="yes"
+-no-openmp )
+do_openmp="no"
 ;;
 -help | --help | -h | --h | -\? )
 usage
@@ -293,6 +293,9 @@
 if [ -d $BuildDir/compiler-rt.src ] && [ ! -h compiler-rt ]; then
 ln -s ../../compiler-rt.src compiler-rt
 fi
+if [ -d $BuildDir/openmp.src ] && [ ! -h openmp ]; then
+ln -s ../../openmp.src openmp
+fi
 if [ -d $BuildDir/libcxx.src ] && [ ! -h libcxx ]; then
 ln -s ../../libcxx.src libcxx
 fi
@@ -443,46 +446,6 @@
 cd $cwd
 }
 
-# Build and package the OpenMP run-time. This is still experimental and not
-# meant for official testing in the release, but as a way for providing
-# binaries as a convenience to those who want to try it out.
-function build_OpenMP() {
-cwd=`pwd`
-
-rm -rf $BuildDir/Phase3/openmp
-rm -rf $BuildDir/Phase3/openmp.install
-mkdir -p $BuildDir/Phase3/openmp
-cd $BuildDir/Phase3/openmp
-clang=$BuildDir/Phase3/Release/llvmCore-$Release-$RC.install/usr/local/bin/clang
-
-echo "#" cmake -DCMAKE_C_COMPILER=${clang} -DCMAKE_CXX_COMPILER=${clang}++ \
--DCMAKE_BUILD_TYPE=Release -DLIBOMP_MICRO_TESTS=on \
-$BuildDir/openmp.src/runtime
-cmake -DCMAKE_C_COMPILER=${clang} -DCMAKE_CXX_COMPILER=${clang}++ \
--DCMAKE_BUILD_TYPE=Release -DLIBOMP_MICRO_TESTS=on \
-$BuildDir/openmp.src/runtime
-
-echo "# Building OpenMP run-time"
-echo "# ${MAKE} -j $NumJobs VERBOSE=1"
-${MAKE} -j $NumJobs VERBOSE=1
-echo "# ${MAKE} libomp-micro-tests VERBOSE=1"
-${MAKE} libomp-micro-tests VERBOSE=1
-echo "# ${MAKE} install DESTDIR=$BuildDir/Phase3/openmp.install"
-${MAKE} install DESTDIR=$BuildDir/Phase3/openmp.install
-
-OpenMPPackage=OpenMP-$Release
-if [ $RC != "final" ]; then
-OpenMPPackage=$OpenMPPackage-$RC
-fi
-OpenMPPackage=$OpenMPPackage-$Triple
-
-mv $BuildDir/Phase3/openmp.install/usr/local $BuildDir/$OpenMPPackage
-cd $BuildDir
-tar cvfJ $BuildDir/$OpenMPPackage.tar.xz $OpenMPPackage
-mv $OpenMPPackage $BuildDir/Phase3/openmp.install/usr/local
-cd $cwd
-}
-
 # Exit if any command fails
 # Note: pipefail is necessary for running build commands through
 # a pipe (i.e. it changes the output of ``false | tee /dev/null ; echo $?``)
@@ -594,10 +557,6 @@
 fi
 done
 
-if [ $do_openmp = "yes" ]; then
-  build_OpenMP
-fi
-
 ) 2>&1 | tee $LogDir/testing.$Release-$RC.log
 
 package_release
Index: docs/ReleaseProcess.rst
===
--- docs/ReleaseProcess.rst
+++ docs/ReleaseProcess.rst
@@ -53,7 +53,7 @@
 ---
 
 This script will check-out, configure and compile LLVM+Clang (+ most add-ons, like ``compiler-rt``,
-``libcxx`` and ``clang-extra-tools``) in three stages, and will test the final stage.
+``libcxx``, ``libomp`` and ``clang-extra-tools``) in three stages, and will test the final stage.
 It'll have installed the final binaries on the Phase3/Releasei(+Asserts) directory, and
 that's the one you should use for the test-suite and other external tests.
 
Index: docs/GettingStarted.rst
===
--- docs/GettingStarted.rst
+++ docs/GettingStarted.rst
@@ -55,6 

Re: [PATCH] D13802: [OPENMP] Make -fopenmp to turn on OpenMP support by default.

[Alexey Bataev via cfe-commits]

ABataev marked an inline comment as done.
ABataev added a comment.

Hi Chandler, thanks for the review.

In http://reviews.llvm.org/D13802#272053, @chandlerc wrote:

> Some minor issues below. Also, Hans and Tom should have a glance at the 
> release bits of this, I don't know any of that stuff.
>
> Also, there are still some bugs with check-libomp. The immediate one I 
> noticed was that when i run it in a clean build with enough parallelism, it 
> fails to find the just-built clang binary. I suspect that the 'check-libomp' 
> CMake target is missing dependencies on all of the binaries used when running 
> the lit tests because it copied the libc++ CMake rules for it. While the 
> libc++ CMake rules are *mostly* a good proxy, the *testing* strategy for 
> libc++ is notably different here. In fact, libomp's testing is (IMO) quite a 
> bit *better* here, and uncovers a nasty missing dependency.
>
> The libc++ test suite tests libc++ with the *host* compiler, not the 
> just-built compiler. This has some advantages and disadvantages, but for a 
> library with close coupling to the compiler (such as compiler-rt or libomp) 
> it is inappropriate. Your libomp tests very correctly use the just-built 
> Clang, but the CMake needs to model this now. You can see in 
> projects/compiler-rt/test/CMakeLists.txt lines 19-33 how compiler-rt sets up 
> variables with these tools (clang, clang-headers, etc) which end up used on 
> line 99 of projects/compiler-rt/test/asan/CMakeLists.txt for example.
>
> I don't know what all tools you need (other than clang and probably 
> clang-headers), probably not as many as the sanitizers do, so I'll let you 
> put together a correct patch here. I've hacked around it locally to test 
> further.


I created a separate patch for libomp, that fixes this issue.

> I've also had one test fail, and then start passing for me on Linux (after 
> fixing the above). I haven't had it fail again, but I don't have a good way 
> of running tests repeatedly (see below, llvm-lit doesn't yet work). It might 
> be good to give the test suite a good 10 or 50 runs and see if anything 
> starts failing. I'll do that overnight and report back if so.


Actually, these tests are written so, that they repeats about 1000 times to be 
sure that they are correct. But some of them might be sensible to system load.



Comment at: configure:5953
@@ -5952,3 +5952,3 @@
 else
-  withval="libgomp"
+  withval="libomp"
 fi

chandlerc wrote:
> You should be modifying the configure.ac file and regenerating this?
Ok, done


Comment at: utils/llvm-lit/llvm-lit.in:42-46
@@ -41,2 +41,7 @@
 
+openmp_obj_root = os.path.join(llvm_obj_root, 'projects', 'openmp')
+if os.path.exists(openmp_obj_root):
+builtin_parameters['openmp_site_basedir'] = \
+os.path.join(openmp_obj_root, 'runtime', 'test')
+
 if __name__=='__main__':

chandlerc wrote:
> This change is independent of enabling anything; can you break it out?
> 
> Also, manually patching this bit in order to test things didn't actually 
> allow me to use llvm-lit with libomp, so I don't think this is quite working 
> as intended yet.
Ok, reverted it


http://reviews.llvm.org/D13802



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D13802: [OPENMP] Make -fopenmp to turn on OpenMP support by default.

[Hans Wennborg via cfe-commits]

hans added a comment.

The release script change looks good to me. Better than good actually; it's a 
great improvement :-)


http://reviews.llvm.org/D13802



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits