Re: [PATCH] D18462: Fix for clang_Cursor_getSpellingNameRange()

2016-09-15 Thread Benjamin Kramer via cfe-commits 
bkramer accepted this revision.
bkramer added a comment.

looks good from my side.


https://reviews.llvm.org/D18462



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D18462: Fix for clang_Cursor_getSpellingNameRange()

2016-09-15 Thread Milian Wolff via cfe-commits 
milianw accepted this revision.
milianw added a comment.
This revision is now accepted and ready to land.

agreed, lgtm but someone else must accept this upstream


https://reviews.llvm.org/D18462



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D18462: Fix for clang_Cursor_getSpellingNameRange()

2016-09-15 Thread Kevin Funk via cfe-commits 
kfunk added a comment.

@other LLVM devs: Please review so we can finally ship this?



Comment at: tools/libclang/CIndex.cpp:4311
@@ -4311,1 +4310,3 @@
+  C.kind == CXCursor_ConversionFunction ||
+  C.kind == CXCursor_FunctionDecl) {
 if (pieceIndex > 0)

skalinichev wrote:
> What about function templates?
> 
> E.g.: template  double operator "" _x();
Still broken for function template. The fix isn't as easy as adding another 
check for `C.kind == CXCursor=FunctionTemplate`, though.

We should fix this in another patch.


https://reviews.llvm.org/D18462



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D18462: Fix for clang_Cursor_getSpellingNameRange()

2016-09-12 Thread Manuel Klimek via cfe-commits 
klimek added a reviewer: bkramer.
klimek added a comment.

+Benjamin


https://reviews.llvm.org/D18462



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D18462: Fix for clang_Cursor_getSpellingNameRange()

2016-09-11 Thread Milian Wolff via cfe-commits 
milianw added a comment.

ping, any update on this?


https://reviews.llvm.org/D18462



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D18462: Fix for clang_Cursor_getSpellingNameRange()

2016-03-26 Thread Sergey Kalinichev via cfe-commits 
skalinichev added inline comments.


Comment at: tools/libclang/CIndex.cpp:4311
@@ -4311,1 +4310,3 @@
+  C.kind == CXCursor_ConversionFunction ||
+  C.kind == CXCursor_FunctionDecl) {
 if (pieceIndex > 0)

What about function templates?

E.g.: template  double operator "" _x();


http://reviews.llvm.org/D18462



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits