Re: [PATCH] D21082: Do not assume that -fsanitize=address is valid option in clang tests
christof added a comment. In http://reviews.llvm.org/D21082#451393, @kubabrecka wrote: > This doesn’t make sense to me, Clang is able to produce ASanified code even > when the compiler itself isn’t ASanified (that’s what LLVM_USE_SANITIZER > does). Where exactly is this test failing? Right. I was confused about the meaning of that feature. The test fails with: clang-3.9: error: unsupported option '-fsanitize=address' for target 'aarch64-arm-none-eabi’ The patch suggested by vitalybuka seems to work. So I suggest we go for that. Repository: rL LLVM http://reviews.llvm.org/D21082 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Re: [PATCH] D21082: Do not assume that -fsanitize=address is valid option in clang tests
vitalybuka added a comment. http://reviews.llvm.org/D21117 Repository: rL LLVM http://reviews.llvm.org/D21082 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Re: [PATCH] D21082: Do not assume that -fsanitize=address is valid option in clang tests
vitalybuka added a comment. Oh, I see, most asan tests in clang use cross-compiler, e.g.: -target x86_64-linux-gnu Repository: rL LLVM http://reviews.llvm.org/D21082 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Re: [PATCH] D21082: Do not assume that -fsanitize=address is valid option in clang tests
vitalybuka requested changes to this revision. vitalybuka added a comment. This revision now requires changes to proceed. It was accepted accidentally. Repository: rL LLVM http://reviews.llvm.org/D21082 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Re: [PATCH] D21082: Do not assume that -fsanitize=address is valid option in clang tests
vitalybuka accepted this revision. vitalybuka added a comment. This revision is now accepted and ready to land. Actually there are other tests with -fsanitize=address I see only difference in %clang vs %clang_cc1? Could you try this? Repository: rL LLVM http://reviews.llvm.org/D21082 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Re: [PATCH] D21082: Do not assume that -fsanitize=address is valid option in clang tests
vitalybuka added a comment. I guess you can remove // UNSUPPORTED: mingw32 added by cfe/trunk@271509 Repository: rL LLVM http://reviews.llvm.org/D21082 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Re: [PATCH] D21082: Do not assume that -fsanitize=address is valid option in clang tests
kubabrecka added a subscriber: kubabrecka. kubabrecka added a comment. This doesn’t make sense to me, Clang is able to produce ASanified code even when the compiler itself isn’t ASanified (that’s what LLVM_USE_SANITIZER does). Where exactly is this test failing? Repository: rL LLVM http://reviews.llvm.org/D21082 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
